[{"id":4030,"web_url":"https://patchwork.libcamera.org/comment/4030/","msgid":"<20200316153829.GF2260535@oden.dyn.berto.se>","date":"2020-03-16T15:38:29","subject":"Re: [libcamera-devel] [PATCH 6/9] libcamera: camera: Propagate\n\terror value from importFrameBuffer","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-03-15 01:57:25 +0200, Laurent Pinchart wrote:\n> The PipelineHandler::importFrameBuffer() function, called by\n> Camera::start() may return an error, but its return value is ignored.\n> Propagate it to the caller to fix this.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/camera.cpp | 6 ++++--\n> 1 file changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 63b1f7729937..9c432adb1d97 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -931,8 +931,10 @@ int Camera::start()\n> \t\tif (allocator_ && !allocator_->buffers(stream).empty())\n> \t\t\tcontinue;\n> \n> -\t\tp_->pipe_->invokeMethod(&PipelineHandler::importFrameBuffers,\n> -\t\t\t\t\tConnectionTypeDirect, this, stream);\n> +\t\tret = p_->pipe_->invokeMethod(&PipelineHandler::importFrameBuffers,\n> +\t\t\t\t\t ConnectionTypeDirect, this, stream);\n> +\t\tif (ret < 0)\n> +\t\t\treturn ret;\n> \t}\n> \n> \tret = p_->pipe_->invokeMethod(&PipelineHandler::start,\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9222E6041A\n\tfor ;\n\tMon, 16 Mar 2020 16:38:31 +0100 (CET)","by mail-lf1-x142.google.com with SMTP id b186so14345344lfg.11\n\tfor ;\n\tMon, 16 Mar 2020 08:38:31 -0700 (PDT)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\tj124sm214047lfj.27.2020.03.16.08.38.29\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 16 Mar 2020 08:38:29 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=gMcJK25pvLOEQMFSrkVYofIA4k2W+BlrubrCGKo+C5M=;\n\tb=g+EguWggdEZ/R5GgiD+yHgvKHTKS1O0xoBlFYRMKSES7pxZ/pjW4TWJV2mq1AHuQCG\n\tFxRrivLk3ZxfuzJ2q/wz0nRvwPlAu7gvtN1GKJu5XADOBY1I9lEAek/8oVo7aUsMu9FH\n\tTS31RcsI02Fu7ZqE0ptxTK3ITaDgO/gOUXEwtOwwjyfDWnR5FX729Rww0Bc1dKrVsZpz\n\tbfIbEVZbr9M9SIaNcAWg0ui1dTyRX7E3reWtvNG0t5hljr2AR+J5VVxROPVuvJxE174D\n\tLQCzESD/HBOkXUEEGokg3uRZJn2q4nGGwwtzFI1NmPV6Np5/36oGcFQ8hQl+U87Y9MEU\n\tg7Rg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=gMcJK25pvLOEQMFSrkVYofIA4k2W+BlrubrCGKo+C5M=;\n\tb=TxF0YHKsbS5UHIutbvDQw+1ClTbMIkziJmjbMv7FEd224kCormnnoaoyhL2bmXqJpY\n\tXUPlaTgnGQSLR8PiMKFOB9rOp9wbvILZ6PwxGad7Gt5kGO2JQ24HSUkRpqwWiphNgkM2\n\tz3e8lS0y+udp3CmeAq16NxdTkNTpg0Tw7PXiKld9gNsvzahhHHokMYWgfgGycIGBfR6I\n\tHKXYpx4YiIskjdcCPncCEtLA+B21ZUbFxkb7oAtgEgFMLOAttvLsKI9zVbVfnLKknxot\n\tl+EX94fYq+jxVKgEcWpPhFDIg8bloOjlBA2Km3EJNNPcgRmqjwBzzXqycwIcbxfbUzZ7\n\tk2Rg==","X-Gm-Message-State":"ANhLgQ3yLVNhokO/EMgQKx0AFsW+toesrD0QPY6/Mpyesr12+9Y2NBKN\n\tHX4mM2cUdVAj2GhsA3alo8ypGw==","X-Google-Smtp-Source":"ADFU+vs7djcikQB2W4NWo/E6tdTDgP3PU7t8I/zZyX6hWGg5VcHIpY0OpZOtTSd8PMIR0P04dFvUMw==","X-Received":"by 2002:a19:6406:: with SMTP id\n\ty6mr17303918lfb.125.1584373110825; \n\tMon, 16 Mar 2020 08:38:30 -0700 (PDT)","Date":"Mon, 16 Mar 2020 16:38:29 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200316153829.GF2260535@oden.dyn.berto.se>","References":"<20200314235728.15495-1-laurent.pinchart@ideasonboard.com>\n\t<20200314235728.15495-7-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200314235728.15495-7-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 6/9] libcamera: camera: Propagate\n\terror value from importFrameBuffer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 16 Mar 2020 15:38:31 -0000"}}]