[{"id":4267,"web_url":"https://patchwork.libcamera.org/comment/4267/","msgid":"<74d57248-a812-4ee2-7b72-5d83025f3790@ideasonboard.com>","date":"2020-03-24T18:17:44","subject":"Re: [libcamera-devel] [PATCH v3 5/6] libcamera: sensor: Add OV5670\n\tcamera sensor","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo\n\nOn 09/03/2020 18:04, Jacopo Mondi wrote:\n> Add OV5670CameraSensor class to handle Omnivision OV5670 image sensor\n\n/Add /Add an /\n\n/handle Omnivision /handle the Omnivision /\n\n> and register it to the camera sensor factory and initialize its pixel\n> array properties by overriding CameraSensor::initProperties() method.\n> \n\nIn General, I think this is a pretty good way to collate both the fixed\nsensor specific data, along with the 'dynamic control' data which will\nbe obtained from V4L2.\n\n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Kieran Bingham \n\nNow we just need to add some more starting point sensor devices here...\n\n> \n> ---\n> v2 -> v3:\n> - Squash class introduction and patches registration\n> - Update to use the new properties names\n> ---\n> src/libcamera/meson.build | 1 +\n> src/libcamera/sensor/meson.build | 3 ++\n> src/libcamera/sensor/ov5670.cpp | 60 ++++++++++++++++++++++++++++++++\n> 3 files changed, 64 insertions(+)\n> create mode 100644 src/libcamera/sensor/meson.build\n> create mode 100644 src/libcamera/sensor/ov5670.cpp\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 87fa09cde63d..358c784baa20 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -57,6 +57,7 @@ includes = [\n> \n> subdir('pipeline')\n> subdir('proxy')\n> +subdir('sensor')\n> \n> libatomic = cc.find_library('atomic', required : false)\n> libdl = cc.find_library('dl')\n> diff --git a/src/libcamera/sensor/meson.build b/src/libcamera/sensor/meson.build\n> new file mode 100644\n> index 000000000000..7af70370cf5c\n> --- /dev/null\n> +++ b/src/libcamera/sensor/meson.build\n> @@ -0,0 +1,3 @@\n> +libcamera_sources += files([\n> + 'ov5670.cpp',\n> +])\n> diff --git a/src/libcamera/sensor/ov5670.cpp b/src/libcamera/sensor/ov5670.cpp\n> new file mode 100644\n> index 000000000000..a027a0816e58\n> --- /dev/null\n> +++ b/src/libcamera/sensor/ov5670.cpp\n> @@ -0,0 +1,60 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2020, Google Inc.\n> + *\n> + * ov5670.cpp - OV5670 camera sensor\n> + */\n> +\n> +#include \n> +\n> +#include \"camera_sensor.h\"\n> +\n> +/**\n> + * \\file ov5670.cpp\n> + * \\brief Omnivision OV5670 image sensor\n> + */\n> +\n> +namespace libcamera {\n> +\n> +class OV5670 final : public CameraSensor\n> +{\n> +public:\n> +\tOV5670(const MediaEntity *entity);\n> +\tint initProperties();\n> +};\n> +\n> +/**\n> + * \\class OV5670\n> + * \\brief Camera sensor class for Omnivision OV5670 image sensor\n> + */\n> +\n> +/**\n> + * \\brief Construct the ov5670 sensor class\n> + * \\param[in] entity The media entity representing the sensor\n> + */\n> +OV5670::OV5670(const MediaEntity *entity)\n> +\t: CameraSensor(entity)\n> +{\n> +}\n> +\n> +/**\n> + * \\brief Initialize Camera properties with ov5670 specific values\n> + * \\return 0 on success, a negative error code otherwise\n> + */\n> +int OV5670::initProperties()\n> +{\n> +\t/* Pixel Array Properties. */\n> +\tproperties_.set(properties::PixelArraySize, { 2.9457f, 2.214f });\n> +\tproperties_.set(properties::PixelArrayBounds, { 2592, 1944 });\n> +\tproperties_.set(properties::PixelArrays, { 2592, 1944 });\n> +\tproperties_.set(properties::ActiveAreaSizes, { 16, 6, 2560, 1920 });\n> +\tproperties_.set(properties::BayerFilterArrangement,\n> +\t\t\tproperties::BayerFilterGRBG);\n\nAh, now I see this in use - I see how the 'name spacing' is used on the\nproperties..\n\n> +\tproperties_.set(properties::ISOSensitivityRange, { 50, 800 });\n\nI wonder if we need a discrete list of ISO sensitivities or if it's\nvalid to use a continuous range between the min/max?\n\n> +\n> +\treturn CameraSensor::initProperties();\n> +}\n> +\n> +REGISTER_CAMERA_SENSOR(OV5670, \"ov5670\");\n> +\n> +}; /* namespace libcamera */\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7332B60411\n\tfor ;\n\tTue, 24 Mar 2020 19:17:48 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A0FB32D2;\n\tTue, 24 Mar 2020 19:17:47 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"YTo06HRx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1585073867;\n\tbh=nKwgrh5p1u8ZBha3XPQg+pQ3YVuvVlMWmzVaopm4krg=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=YTo06HRxgVI2mc8HfSv82DDHjmUr+KKQF2Z/5cYencv6Wxpa5yY1FmrhwQeUGnelL\n\tzGYQNucRW/5Q2/NyPOpYTvE40XT+LCDpBHPchADitfA1yuxnBHJblTSUSyUsILuWtT\n\tZqgDVH30/x7etPcM+ae0832JUHuOqN6USQZuKbZU=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20200309180444.725757-1-jacopo@jmondi.org>\n\t<20200309180444.725757-6-jacopo@jmondi.org>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<74d57248-a812-4ee2-7b72-5d83025f3790@ideasonboard.com>","Date":"Tue, 24 Mar 2020 18:17:44 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200309180444.725757-6-jacopo@jmondi.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v3 5/6] libcamera: sensor: Add OV5670\n\tcamera sensor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 24 Mar 2020 18:17:48 -0000"}}]