[{"id":4158,"web_url":"https://patchwork.libcamera.org/comment/4158/","msgid":"<20200320213958.GT5193@pendragon.ideasonboard.com>","date":"2020-03-20T21:39:58","subject":"Re: [libcamera-devel] [PATCH 09/11] libcamera: v4l2_controls:\n\tSupport U8 array controls","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Mon, Mar 09, 2020 at 05:24:12PM +0100, Jacopo Mondi wrote:\n> Add support for array controls of type V4L2_CTRL_TYPE_U8.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/v4l2_controls.cpp | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> diff --git a/src/libcamera/v4l2_controls.cpp b/src/libcamera/v4l2_controls.cpp\n> index 4861f9778df3..8e2415f2a6df 100644\n> --- a/src/libcamera/v4l2_controls.cpp\n> +++ b/src/libcamera/v4l2_controls.cpp\n> @@ -60,6 +60,9 @@ std::string v4l2_ctrl_name(const struct v4l2_query_ext_ctrl &ctrl)\n> ControlType v4l2_ctrl_type(const struct v4l2_query_ext_ctrl &ctrl)\n> {\n> \tswitch (ctrl.type) {\n> +\tcase V4L2_CTRL_TYPE_U8:\n> +\t\treturn ControlTypeByte;\n> +\n> \tcase V4L2_CTRL_TYPE_BOOLEAN:\n> \t\treturn ControlTypeBool;\n> \n> @@ -119,6 +122,12 @@ V4L2ControlId::V4L2ControlId(const struct v4l2_query_ext_ctrl &ctrl)\n> V4L2ControlInfo::V4L2ControlInfo(const struct v4l2_query_ext_ctrl &ctrl)\n> {\n> \tswitch (ctrl.type) {\n> +\tcase V4L2_CTRL_TYPE_U8:\n> +\t\tControlInfo::operator=(ControlInfo(static_cast(ctrl.minimum),\n> +\t\t\t\t\t\t static_cast(ctrl.maximum),\n> +\t\t\t\t\t\t static_cast(ctrl.default_value)));\n> +\t\tbreak;\n> +\n> \tcase V4L2_CTRL_TYPE_BOOLEAN:\n> \t\tControlInfo::operator=(ControlInfo(static_cast(ctrl.minimum),\n> \t\t\t\t\t\t static_cast(ctrl.maximum),","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CC6BF60416\n\tfor ;\n\tFri, 20 Mar 2020 22:40:04 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 46040504;\n\tFri, 20 Mar 2020 22:40:04 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584740404;\n\tbh=+bWeAbGhhEFzryR1Z7CpqTnklXRJ94B+TFPca0FCus8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=q4WCEUzHN61cOJBrn7bL3IddVv98WKdNLABPOhQXSgury6AnfUzGnNx0ittoknp6B\n\tOSP9/r0h4HR3rnTGnRRP+gNmM1uMg3U+JnQu0zzyLTeWEANp02oJJwpZHU6bEwB2+6\n\tXKdLQzIKiUhMKUdIPvJN0VwePU/MsNk6PiVzjW8A=","Date":"Fri, 20 Mar 2020 23:39:58 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200320213958.GT5193@pendragon.ideasonboard.com>","References":"<20200309162414.720306-1-jacopo@jmondi.org>\n\t<20200309162414.720306-10-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200309162414.720306-10-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 09/11] libcamera: v4l2_controls:\n\tSupport U8 array controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 20 Mar 2020 21:40:05 -0000"}}]