{"id":3074,"url":"https://patchwork.libcamera.org/api/patches/3074/?format=json","web_url":"https://patchwork.libcamera.org/patch/3074/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200309162414.720306-10-jacopo@jmondi.org>","date":"2020-03-09T16:24:12","name":"[libcamera-devel,09/11] libcamera: v4l2_controls: Support U8 array controls","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"20d5d9a2039bbeb1f0b1b6d737cf95dada903301","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3074/mbox/","series":[{"id":716,"url":"https://patchwork.libcamera.org/api/series/716/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=716","date":"2020-03-09T16:24:03","name":"Adda support for V4L2 array control and strings","version":1,"mbox":"https://patchwork.libcamera.org/series/716/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3074/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3074/checks/","tags":{},"headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 88C7E62930\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  9 Mar 2020 17:21:31 +0100 (CET)","from uno.lan (93-34-114-233.ip49.fastwebnet.it [93.34.114.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 4313760008\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  9 Mar 2020 16:21:31 +0000 (UTC)"],"X-Originating-IP":"93.34.114.233","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Mon,  9 Mar 2020 17:24:12 +0100","Message-Id":"<20200309162414.720306-10-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.25.0","In-Reply-To":"<20200309162414.720306-1-jacopo@jmondi.org>","References":"<20200309162414.720306-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 09/11] libcamera: v4l2_controls: Support\n\tU8 array controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 09 Mar 2020 16:21:32 -0000"},"content":"Add support for array controls of type V4L2_CTRL_TYPE_U8.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/v4l2_controls.cpp | 9 +++++++++\n 1 file changed, 9 insertions(+)","diff":"diff --git a/src/libcamera/v4l2_controls.cpp b/src/libcamera/v4l2_controls.cpp\nindex 4861f9778df3..8e2415f2a6df 100644\n--- a/src/libcamera/v4l2_controls.cpp\n+++ b/src/libcamera/v4l2_controls.cpp\n@@ -60,6 +60,9 @@ std::string v4l2_ctrl_name(const struct v4l2_query_ext_ctrl &ctrl)\n ControlType v4l2_ctrl_type(const struct v4l2_query_ext_ctrl &ctrl)\n {\n \tswitch (ctrl.type) {\n+\tcase V4L2_CTRL_TYPE_U8:\n+\t\treturn ControlTypeByte;\n+\n \tcase V4L2_CTRL_TYPE_BOOLEAN:\n \t\treturn ControlTypeBool;\n \n@@ -119,6 +122,12 @@ V4L2ControlId::V4L2ControlId(const struct v4l2_query_ext_ctrl &ctrl)\n V4L2ControlInfo::V4L2ControlInfo(const struct v4l2_query_ext_ctrl &ctrl)\n {\n \tswitch (ctrl.type) {\n+\tcase V4L2_CTRL_TYPE_U8:\n+\t\tControlInfo::operator=(ControlInfo(static_cast<uint8_t>(ctrl.minimum),\n+\t\t\t\t\t\t   static_cast<uint8_t>(ctrl.maximum),\n+\t\t\t\t\t\t   static_cast<uint8_t>(ctrl.default_value)));\n+\t\tbreak;\n+\n \tcase V4L2_CTRL_TYPE_BOOLEAN:\n \t\tControlInfo::operator=(ControlInfo(static_cast<bool>(ctrl.minimum),\n \t\t\t\t\t\t   static_cast<bool>(ctrl.maximum),\n","prefixes":["libcamera-devel","09/11"]}