[{"id":4154,"web_url":"https://patchwork.libcamera.org/comment/4154/","msgid":"<20200320211403.GP5193@pendragon.ideasonboard.com>","date":"2020-03-20T21:14:03","subject":"Re: [libcamera-devel] [PATCH 06/11] libcamera: v4l2_controls: Cache\n\tquery control information","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Mar 09, 2020 at 05:24:09PM +0100, Jacopo Mondi wrote:\n> Cache the V4L2 control info retrieved with VIDIOC_QUERY_EXT_CTRL\n> at control listing time for later use.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/include/v4l2_device.h | 1 +\n> src/libcamera/v4l2_device.cpp | 1 +\n> 2 files changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/include/v4l2_device.h b/src/libcamera/include/v4l2_device.h\n> index 6bfddefe336c..e1fd048cc85a 100644\n> --- a/src/libcamera/include/v4l2_device.h\n> +++ b/src/libcamera/include/v4l2_device.h\n> @@ -48,6 +48,7 @@ private:\n> \t\t\t const struct v4l2_ext_control *v4l2Ctrls,\n> \t\t\t unsigned int count);\n> \n> +\tstd::map ctrlsInfo_;\n\nTo match the next field, I would call this controlInfo_ (controlInfos_\nwould have been better, but that would be an English error as\ninformation is uncountable).\n\nReviewed-by: Laurent Pinchart \n\n> \tstd::vector> controlIds_;\n> \tControlInfoMap controls_;\n> \tstd::string deviceNode_;\n> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> index 179476e9afad..65e97f92b01f 100644\n> --- a/src/libcamera/v4l2_device.cpp\n> +++ b/src/libcamera/v4l2_device.cpp\n> @@ -382,6 +382,7 @@ void V4L2Device::listControls()\n> \n> \t\tcontrolIds_.emplace_back(std::make_unique(ctrl));\n> \t\tctrls.emplace(controlIds_.back().get(), V4L2ControlInfo(ctrl));\n> +\t\tctrlsInfo_[ctrl.id] = ctrl;\n> \t}\n> \n> \tcontrols_ = std::move(ctrls);","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 646E360416\n\tfor ;\n\tFri, 20 Mar 2020 22:14:10 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D5321504;\n\tFri, 20 Mar 2020 22:14:09 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584738850;\n\tbh=2jNLt056WRTc5VJjL6XZS30J5hZPFadnucrKsblgJ1c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=iJxrGzcjjGX91uh5VQ1mKe3+xAaQUyt429S8UajgF9Lk6KGrm6Kxo4RqYcX4Y78Pt\n\tPjQjDzZ2uvEbVFn13UXJLdq29fA0tx9qNXwGiO/Oe7w/rKsNv1IcQJc4qsoijZGML5\n\ty0xmgbI3ciQSh9jtX4t2WX7hcSqj9TCVV2dXVvpc=","Date":"Fri, 20 Mar 2020 23:14:03 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200320211403.GP5193@pendragon.ideasonboard.com>","References":"<20200309162414.720306-1-jacopo@jmondi.org>\n\t<20200309162414.720306-7-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200309162414.720306-7-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 06/11] libcamera: v4l2_controls: Cache\n\tquery control information","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 20 Mar 2020 21:14:10 -0000"}}]