[{"id":4126,"web_url":"https://patchwork.libcamera.org/comment/4126/","msgid":"<20200320120941.7x2rhielzbm2stt2@uno.localdomain>","date":"2020-03-20T12:09:41","subject":"Re: [libcamera-devel] [PATCH 04/11] test: controls: control_value:\n\tTest string control type","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Mar 09, 2020 at 05:24:07PM +0100, Jacopo Mondi wrote:\n> From: Laurent Pinchart \n>\n> Add test cases for the string control type. As strings are implemented\n> as char arrays, arrays of strings are not supported.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> test/controls/control_value.cpp | 22 ++++++++++++++++++++++\n> 1 file changed, 22 insertions(+)\n>\n> diff --git a/test/controls/control_value.cpp b/test/controls/control_value.cpp\n> index a7ebf60f6a6a..ad8e05d0b1a9 100644\n> --- a/test/controls/control_value.cpp\n> +++ b/test/controls/control_value.cpp\n> @@ -235,6 +235,28 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n>\n> +\t\t/*\n> +\t\t * String type.\n> +\t\t */\n> +\t\tstd::string string{ \"libcamera\" };\n> +\t\tvalue.set(string);\n> +\t\tif (value.isNone() || !value.isArray() ||\n> +\t\t value.type() != ControlTypeString ||\n> +\t\t value.numElements() != string.size()) {\n> +\t\t\tcerr << \"Control type mismatch after setting to string\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (value.get() != string) {\n> +\t\t\tcerr << \"Control value mismatch after setting to string\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (value.toString() != string) {\n> +\t\t\tcerr << \"Control string mismatch after setting to string\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> \t\treturn TestPass;\n> \t}\n> };\n> --\n> 2.25.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4982160416\n\tfor ;\n\tFri, 20 Mar 2020 13:06:45 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 06A8E4000D\n\tfor ;\n\tFri, 20 Mar 2020 12:06:44 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Fri, 20 Mar 2020 13:09:41 +0100","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200320120941.7x2rhielzbm2stt2@uno.localdomain>","References":"<20200309162414.720306-1-jacopo@jmondi.org>\n\t<20200309162414.720306-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200309162414.720306-5-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 04/11] test: controls: control_value:\n\tTest string control type","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 20 Mar 2020 12:06:45 -0000"}}]