[{"id":4131,"web_url":"https://patchwork.libcamera.org/comment/4131/","msgid":"","date":"2020-03-20T13:38:02","subject":"Re: [libcamera-devel] [PATCH v2 1/6] libcamera: controls: Specify\n\tmanual gain units and change exposure units","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 09/03/2020 12:33, Naushir Patuck wrote:\n> Use micro-seconds for ManualExposure. This is changed from milli-\n> seconds. The latter would not allow very low exposure times.\n> \n> ManualGain switch to use a float to allow fractional gain adjustments.\n\n\"Switch ManualGain to use a float\" ...?\n\n> \n> Signed-off-by: Naushir Patuck \n> ---\n> src/libcamera/control_ids.yaml | 13 ++++++++++---\n> 1 file changed, 10 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index 4befec74..5bbe65ae 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -44,10 +44,17 @@ controls:\n> \n> - ManualExposure:\n> type: int32_t\n\nNot directly against this patch, but I can't imagine having a negative\nexposure time - so should this be uint32_t?\n\n> - description: Specify a fixed exposure time in milli-seconds\n> + description: |\n> + Specify a fixed exposure time in micro-seconds to be applied in the\n> + sensor device.\n> +\n> + \\sa ManualGain\n> \n> - ManualGain:\n> - type: int32_t\n> - description: Specify a fixed gain parameter\n> + type: float\n> + description: |\n> + Specify a fixed gain value to be applied in the pipeline. This gain is\n> + applied to all colour channels.\n> \n> + \\sa ManualExposure\n> ...\n> \n\nOtherwise, this sounds good to me.\n\nReviewed-by: Kieran Bingham ","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 37F3060416\n\tfor ;\n\tFri, 20 Mar 2020 14:38:06 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 964A5504;\n\tFri, 20 Mar 2020 14:38:05 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584711485;\n\tbh=/d496Yw9P/x+jKyafnkScMCwQDIjZpltExswIkLPOFU=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=B0Tr1K+PhQXpNivO/amXz5Zq8lUeEkC44regh8mlTCEO/6TlXL14tIcNaYJAxrLgC\n\t7mIb1ylySpKswWzH2UBZ+9gZ/niWYKLeWXAJdVdydwneZWIKmQ6W6KKU0Wf6SeWvun\n\tWkcrSSEVTbJGrohgz6DIujNF2RHT2Tby14S9uaAA=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200309123319.630-1-naush@raspberrypi.com>\n\t<20200309123319.630-2-naush@raspberrypi.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Fri, 20 Mar 2020 13:38:02 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200309123319.630-2-naush@raspberrypi.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2 1/6] libcamera: controls: Specify\n\tmanual gain units and change exposure units","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 20 Mar 2020 13:38:06 -0000"}},{"id":4134,"web_url":"https://patchwork.libcamera.org/comment/4134/","msgid":"<20200320140529.GI5193@pendragon.ideasonboard.com>","date":"2020-03-20T14:05:29","subject":"Re: [libcamera-devel] [PATCH v2 1/6] libcamera: controls: Specify\n\tmanual gain units and change exposure units","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Fri, Mar 20, 2020 at 01:38:02PM +0000, Kieran Bingham wrote:\n> On 09/03/2020 12:33, Naushir Patuck wrote:\n> > Use micro-seconds for ManualExposure. This is changed from milli-\n> > seconds. The latter would not allow very low exposure times.\n> > \n> > ManualGain switch to use a float to allow fractional gain adjustments.\n> \n> \"Switch ManualGain to use a float\" ...?\n> \n> > Signed-off-by: Naushir Patuck \n> > ---\n> > src/libcamera/control_ids.yaml | 13 ++++++++++---\n> > 1 file changed, 10 insertions(+), 3 deletions(-)\n> > \n> > diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> > index 4befec74..5bbe65ae 100644\n> > --- a/src/libcamera/control_ids.yaml\n> > +++ b/src/libcamera/control_ids.yaml\n> > @@ -44,10 +44,17 @@ controls:\n> > \n> > - ManualExposure:\n> > type: int32_t\n> \n> Not directly against this patch, but I can't imagine having a negative\n> exposure time - so should this be uint32_t?\n\nWe don't have unsigned int controls :-)\n\n> > - description: Specify a fixed exposure time in milli-seconds\n> > + description: |\n> > + Specify a fixed exposure time in micro-seconds to be applied in the\n> > + sensor device.\n> > +\n> > + \\sa ManualGain\n> > \n> > - ManualGain:\n> > - type: int32_t\n> > - description: Specify a fixed gain parameter\n> > + type: float\n> > + description: |\n> > + Specify a fixed gain value to be applied in the pipeline. This gain is\n> > + applied to all colour channels.\n> > \n> > + \\sa ManualExposure\n> > ...\n> > \n> \n> Otherwise, this sounds good to me.\n> \n> Reviewed-by: Kieran Bingham ","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0AC0160416\n\tfor ;\n\tFri, 20 Mar 2020 15:05:36 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8508B504;\n\tFri, 20 Mar 2020 15:05:35 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584713135;\n\tbh=YOUcQ0lm1ogU7XCdgQDSUEo3mUWGRFYOIp4imfcrB4U=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hQZf+ivYK86pblRmhvPaXmsc4j50EF0JnVdMW4aUhM6q+saY1PUF5K2PdX3eECWYs\n\tiEhwpoCoGd04jmFIrOzFLL/XZu16jWM5c8TfTmfN6MKwMv7wGIpd7xA5GhYBreMltj\n\tdM6QotixWjW2oGhReoLQOCJrBfKpkyVwQQ/5bOyE=","Date":"Fri, 20 Mar 2020 16:05:29 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<20200320140529.GI5193@pendragon.ideasonboard.com>","References":"<20200309123319.630-1-naush@raspberrypi.com>\n\t<20200309123319.630-2-naush@raspberrypi.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 1/6] libcamera: controls: Specify\n\tmanual gain units and change exposure units","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 20 Mar 2020 14:05:36 -0000"}},{"id":4140,"web_url":"https://patchwork.libcamera.org/comment/4140/","msgid":"<6b0a7fa2-60a8-f508-c820-c158e4fba0aa@ideasonboard.com>","date":"2020-03-20T14:35:36","subject":"Re: [libcamera-devel] [PATCH v2 1/6] libcamera: controls: Specify\n\tmanual gain units and change exposure units","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 20/03/2020 14:05, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> On Fri, Mar 20, 2020 at 01:38:02PM +0000, Kieran Bingham wrote:\n>> On 09/03/2020 12:33, Naushir Patuck wrote:\n>>> Use micro-seconds for ManualExposure. This is changed from milli-\n>>> seconds. The latter would not allow very low exposure times.\n>>>\n>>> ManualGain switch to use a float to allow fractional gain adjustments.\n>>\n>> \"Switch ManualGain to use a float\" ...?\n>>\n>>> Signed-off-by: Naushir Patuck \n>>> ---\n>>> src/libcamera/control_ids.yaml | 13 ++++++++++---\n>>> 1 file changed, 10 insertions(+), 3 deletions(-)\n>>>\n>>> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n>>> index 4befec74..5bbe65ae 100644\n>>> --- a/src/libcamera/control_ids.yaml\n>>> +++ b/src/libcamera/control_ids.yaml\n>>> @@ -44,10 +44,17 @@ controls:\n>>> \n>>> - ManualExposure:\n>>> type: int32_t\n>>\n>> Not directly against this patch, but I can't imagine having a negative\n>> exposure time - so should this be uint32_t?\n> \n> We don't have unsigned int controls :-)\n\nAh well then I guess we can't use a uint32_t ...\n\nIs that just a restriction due to ControlValue templates?\nPresumably we 'could' have them - but maybe it's not needed.\n\n> \n>>> - description: Specify a fixed exposure time in milli-seconds\n>>> + description: |\n>>> + Specify a fixed exposure time in micro-seconds to be applied in the\n>>> + sensor device.\n>>> +\n>>> + \\sa ManualGain\n>>> \n>>> - ManualGain:\n>>> - type: int32_t\n>>> - description: Specify a fixed gain parameter\n>>> + type: float\n>>> + description: |\n>>> + Specify a fixed gain value to be applied in the pipeline. This gain is\n>>> + applied to all colour channels.\n>>> \n>>> + \\sa ManualExposure\n>>> ...\n>>>\n>>\n>> Otherwise, this sounds good to me.\n>>\n>> Reviewed-by: Kieran Bingham \n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1280860415\n\tfor ;\n\tFri, 20 Mar 2020 15:35:41 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5B585504;\n\tFri, 20 Mar 2020 15:35:40 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584714940;\n\tbh=CQNUpy1q4GlFSXPTEGodRyv7wkggkdY23pS61fLr/Bk=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=enrzZiPb2hcogjqhPU4bXAyEyT9bs9Pl8Cx02AjrBsjg2P4TYes/tMV/oJty+cFt0\n\t0iq+GntVPfuCSJoERm1u9dBUSnUVVJiJOJAmE/Is6QQBZbCGIR2RL4BeUlhvrfC6ba\n\tIIndLtjtXT3PDDMsktF6rrfUisb3H/89/olYavZc=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200309123319.630-1-naush@raspberrypi.com>\n\t<20200309123319.630-2-naush@raspberrypi.com>\n\t\n\t<20200320140529.GI5193@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<6b0a7fa2-60a8-f508-c820-c158e4fba0aa@ideasonboard.com>","Date":"Fri, 20 Mar 2020 14:35:36 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200320140529.GI5193@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2 1/6] libcamera: controls: Specify\n\tmanual gain units and change exposure units","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 20 Mar 2020 14:35:41 -0000"}},{"id":4143,"web_url":"https://patchwork.libcamera.org/comment/4143/","msgid":"<20200320144413.GM5193@pendragon.ideasonboard.com>","date":"2020-03-20T14:44:13","subject":"Re: [libcamera-devel] [PATCH v2 1/6] libcamera: controls: Specify\n\tmanual gain units and change exposure units","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Fri, Mar 20, 2020 at 02:35:36PM +0000, Kieran Bingham wrote:\n> On 20/03/2020 14:05, Laurent Pinchart wrote:\n> > On Fri, Mar 20, 2020 at 01:38:02PM +0000, Kieran Bingham wrote:\n> >> On 09/03/2020 12:33, Naushir Patuck wrote:\n> >>> Use micro-seconds for ManualExposure. This is changed from milli-\n> >>> seconds. The latter would not allow very low exposure times.\n> >>>\n> >>> ManualGain switch to use a float to allow fractional gain adjustments.\n> >>\n> >> \"Switch ManualGain to use a float\" ...?\n> >>\n> >>> Signed-off-by: Naushir Patuck \n> >>> ---\n> >>> src/libcamera/control_ids.yaml | 13 ++++++++++---\n> >>> 1 file changed, 10 insertions(+), 3 deletions(-)\n> >>>\n> >>> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> >>> index 4befec74..5bbe65ae 100644\n> >>> --- a/src/libcamera/control_ids.yaml\n> >>> +++ b/src/libcamera/control_ids.yaml\n> >>> @@ -44,10 +44,17 @@ controls:\n> >>> \n> >>> - ManualExposure:\n> >>> type: int32_t\n> >>\n> >> Not directly against this patch, but I can't imagine having a negative\n> >> exposure time - so should this be uint32_t?\n> > \n> > We don't have unsigned int controls :-)\n> \n> Ah well then I guess we can't use a uint32_t ...\n> \n> Is that just a restriction due to ControlValue templates?\n> Presumably we 'could' have them - but maybe it's not needed.\n\nWe could, but I think it would complexify the API, especially for V4L2\ncontrols, and you'll have to be very, very careful to add a U suffix to\nyour integer literal when calling some of the functions, otherwise\nyou'll get undefined behaviour without a compiler warning. 32-bit vs.\n64-bit is already painful enough :-)\n\n> >>> - description: Specify a fixed exposure time in milli-seconds\n> >>> + description: |\n> >>> + Specify a fixed exposure time in micro-seconds to be applied in the\n> >>> + sensor device.\n> >>> +\n> >>> + \\sa ManualGain\n> >>> \n> >>> - ManualGain:\n> >>> - type: int32_t\n> >>> - description: Specify a fixed gain parameter\n> >>> + type: float\n> >>> + description: |\n> >>> + Specify a fixed gain value to be applied in the pipeline. This gain is\n> >>> + applied to all colour channels.\n> >>> \n> >>> + \\sa ManualExposure\n> >>> ...\n> >>>\n> >>\n> >> Otherwise, this sounds good to me.\n> >>\n> >> Reviewed-by: Kieran Bingham ","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 28EA460415\n\tfor ;\n\tFri, 20 Mar 2020 15:44:20 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 99880504;\n\tFri, 20 Mar 2020 15:44:19 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584715459;\n\tbh=U9WJmEjTm7sB1KCnsRhIe0/xtf3lm7yax2SFo6fgdNc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=NVsUH0E9z1QDtzce7QrtzOezT1V6FaE26MyxuEBbJK4w29clGb2xNhTY0dgAjNN6s\n\t5iXWszE2rc1FKrSg3VLjFpfoXJUu7+FZauwZRyeM0WS+Tlsmth/k5ORtHUxpBukBCg\n\thCty9StFqF5ITzFKm5bsUOhD8uZ/FZ4NftTbH4Tg=","Date":"Fri, 20 Mar 2020 16:44:13 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<20200320144413.GM5193@pendragon.ideasonboard.com>","References":"<20200309123319.630-1-naush@raspberrypi.com>\n\t<20200309123319.630-2-naush@raspberrypi.com>\n\t\n\t<20200320140529.GI5193@pendragon.ideasonboard.com>\n\t<6b0a7fa2-60a8-f508-c820-c158e4fba0aa@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<6b0a7fa2-60a8-f508-c820-c158e4fba0aa@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 1/6] libcamera: controls: Specify\n\tmanual gain units and change exposure units","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 20 Mar 2020 14:44:20 -0000"}}]