[{"id":4011,"web_url":"https://patchwork.libcamera.org/comment/4011/","msgid":"<20200308173450.GL2975348@oden.dyn.berto.se>","date":"2020-03-08T17:34:50","subject":"Re: [libcamera-devel] [PATCH v4 6/6] v4l2: v4l2_compat: Use correct\n\tlibcamera_dep dependency","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2020-03-08 02:04:33 +0200, Laurent Pinchart wrote:\n> The v4l2-compat shared library is declared as depending on\n> libcamera_deps. This is not correct, as libcamera_deps contains the\n> dependencies of libcamera itself. The correct dependency for users of\n> libcamera is libcamera_dep.\n> \n> Fixing this allows dropping libcamera_includes from the list of includes\n> required by v4l2-compat, and libcamera from the link_with list, as they\n> are already contained in libcamera_dep. We however need to add an\n> explicit dependency on libdl which was previously provided by\n> libcamera_deps.\n> \n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> Changes since v3:\n> \n> - Inline v4l2_compat_deps and v4l2_compat_includes\n> - Use the libdl dependency object\n> ---\n> src/v4l2/meson.build | 10 ++--------\n> 1 file changed, 2 insertions(+), 8 deletions(-)\n> \n> diff --git a/src/v4l2/meson.build b/src/v4l2/meson.build\n> index 14ee3594747d..efab968f7729 100644\n> --- a/src/v4l2/meson.build\n> +++ b/src/v4l2/meson.build\n> @@ -5,11 +5,6 @@ v4l2_compat_sources = files([\n> 'v4l2_compat_manager.cpp',\n> ])\n> \n> -v4l2_compat_includes = [\n> - libcamera_includes,\n> - libcamera_internal_includes,\n> -]\n> -\n> v4l2_compat_cpp_args = [\n> # Meson enables large file support unconditionally, which redirect file\n> # operations to 64-bit versions. This results in some symbols being\n> @@ -25,7 +20,6 @@ v4l2_compat = shared_library('v4l2-compat',\n> v4l2_compat_sources,\n> name_prefix : '',\n> install : true,\n> - link_with : libcamera,\n> - include_directories : v4l2_compat_includes,\n> - dependencies : libcamera_deps,\n> + include_directories : libcamera_internal_includes,\n> + dependencies : [ libcamera_dep, libdl ],\n> cpp_args : v4l2_compat_cpp_args)\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8B06360422\n\tfor ;\n\tSun, 8 Mar 2020 18:34:51 +0100 (CET)","by mail-lj1-x242.google.com with SMTP id r7so7494472ljp.10\n\tfor ;\n\tSun, 08 Mar 2020 10:34:51 -0700 (PDT)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\ta8sm1856743lfi.83.2020.03.08.10.34.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 08 Mar 2020 10:34:50 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=ZRKBoXE5YwNRY0fMzru1RvkPGykc/9sOc6OUZi4PZLk=;\n\tb=Eq+nrukda6WORSx8/cbxKGVI0AL1ASYTrLGduSbOwWgqppjimX0lKFA4NMvnykNtCE\n\tQvm22I9K19fFmsLxU8JMw8VSHSR6l/ZH7lai35RBEVLhXB3jUNgXqFofOSE0JM4jQQSz\n\tRPZxDe68X0wcw/GhGNsjDKjHtAqhNvQckBsMn9Pvm1q5LdwF6UVuXmE3YG6QMV/Ph2CS\n\tYmMwaon4UND7j+tt1S3/1KFY2TD2/Y8aRqMpLjGoW8IPE5x0hJJCpB2Wd7GGR82yCBbU\n\tPq2U4cAOUo/cv1nYq1uoiJ97bxeigLQKGIFUGq+1QFd5srgQStkSyYM91mBj2172SFrD\n\td8dA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=ZRKBoXE5YwNRY0fMzru1RvkPGykc/9sOc6OUZi4PZLk=;\n\tb=o8mbx2RfyT3VfLwkt03z3rvltgFmp3gp48Uag5LtOTY2XAU8G4ZpJI8M7rxvOCLde9\n\teLypxgiGCPEB5wHkOJ8UgiMzOgcDMAyyZysX7UfcUL6uQ2ufjdt+Ez0y0CJ4hEEubnxy\n\tDvOS4+p3p+LGOVdwLjAfv9FcQ54IEwLSt71l0xk4GjpBndcJaAcTODXk0CRR/Bbx+RL5\n\tmfHzc+JuhESqs5GVSa5wnwAD2qUXmiYaCk3lyxJfaTMgwri4hqUxEG1wRNIz8t9Zauh9\n\t0BXWCzPOQXtL+ytRyOK9tWIP/QWLJ6M1BQUfpKbyPZOCAG8AxV5TvuCW9EmgmjdxDC0f\n\tbNyQ==","X-Gm-Message-State":"ANhLgQ1cUat4BVMwW5xuVE4zgHcokjsl8YqSDpVEdqBHE2M8ETA+ed9f\n\tUk/XmuiMyKdTrduUUBY03fYjamM1BSE=","X-Google-Smtp-Source":"ADFU+vvD1j6h4D9Sx1GUthuLIneKfv4QeJgyDan43zzzeJ0QP8niuuo1Fwe8rtJTLkT/4PskI+zZZA==","X-Received":"by 2002:a2e:b4a4:: with SMTP id q4mr7654212ljm.208.1583688890937;\n\tSun, 08 Mar 2020 10:34:50 -0700 (PDT)","Date":"Sun, 8 Mar 2020 18:34:50 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200308173450.GL2975348@oden.dyn.berto.se>","References":"<20200308000433.2917-1-laurent.pinchart@ideasonboard.com>\n\t<20200308000433.2917-7-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200308000433.2917-7-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 6/6] v4l2: v4l2_compat: Use correct\n\tlibcamera_dep dependency","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 08 Mar 2020 17:34:51 -0000"}}]