[{"id":4010,"web_url":"https://patchwork.libcamera.org/comment/4010/","msgid":"<20200308173302.GK2975348@oden.dyn.berto.se>","date":"2020-03-08T17:33:02","subject":"Re: [libcamera-devel] [PATCH v4 5/6] cam: Link against libatomic if\n\tneeded","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-03-08 02:04:32 +0200, Laurent Pinchart wrote:\n> The cam application makes use if std::atomic<>, link against libatomic\n> if needed.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n> ---\n> Changes since v3:\n> \n> - Use the libatomic dependency object\n> ---\n>  src/cam/meson.build | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/cam/meson.build b/src/cam/meson.build\n> index 478346c59590..2419d648bc17 100644\n> --- a/src/cam/meson.build\n> +++ b/src/cam/meson.build\n> @@ -7,5 +7,5 @@ cam_sources = files([\n>  ])\n>  \n>  cam  = executable('cam', cam_sources,\n> -                  dependencies : libcamera_dep,\n> +                  dependencies : [ libatomic, libcamera_dep ],\n>                    install : true)\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E2F4B60422\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun,  8 Mar 2020 18:33:03 +0100 (CET)","by mail-lf1-x143.google.com with SMTP id s1so5750490lfd.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 08 Mar 2020 10:33:03 -0700 (PDT)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\tg20sm20707851lfb.33.2020.03.08.10.33.02\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 08 Mar 2020 10:33:02 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=+bk74Dvv9VlsY4m4zAEv3bFq4MacLjiqVAt0VtA7Gzw=;\n\tb=ImA49jIDlacPz8/gy2BmJIFbBXmHFdui4g2/vO/DEZS6B5HAIS2z86Gw6yQCMemcsb\n\t3xZFfkRQRq99isQSHAyQEdjnxj8hQVrTeFbkqAhlbg1iF33RDaIsY2BB8gG34MZS04GY\n\t9txZV/FpUYIAiTzXXH0LOtiuedGjbLJPZlxL8XDwYSg8NrmWrnHqQ2lOH78VXkROfJbc\n\tTl/MsXeK3/wbx/FOSQQ0dnvhqdyGXL0GjEB18a8sHOZnzXey5LmQDF9iAjZ7DxRuxWGr\n\tmhho7BGk92lbGRTxdDbGIKIouEFWKS5V1PU9WNq+wJt3Lvc0yxSZvhbtlH+tarScMc9K\n\to6Tw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=+bk74Dvv9VlsY4m4zAEv3bFq4MacLjiqVAt0VtA7Gzw=;\n\tb=hs2aQ3LtjZShqGKlquqNRNq5vcGSYwgBBKeYvQ1cX/ko0bFZfXMRtXjWFd0GSb/zT1\n\twZUNvBgN5irAgBNsKViBH6YRSOD4f7ZtGx3BRcIeWvpq8ICZGxdR/aF/7UOtMML8DB3Y\n\tJ49jBdp7r5B2nW6KjtUgHjh1P0UN7XuOnoiPfqGcdsqgdmkviAWxixXFhPx1sc6sOzo/\n\tDqijgJ4Tp4PVxgjQCs3A8GiZrvdExMDAFu3J73/9vn+xz6Af6zB4OqpJ75EfM//zqCXF\n\tm9sR8TyaHwLSAqKMhVHqU+5S1vb/O1nnG/vF6Vgv52fLHjjqf7X4ukqMv3QqUMZIYrQB\n\tRd3g==","X-Gm-Message-State":"ANhLgQ32+eoh7ohCTv94vo4RiQMbvahSfOJCItwLgmmtV98P8aVHRnWO\n\tqWxvDZ5wV+t3PWhw9S3rdcq2ew==","X-Google-Smtp-Source":"ADFU+vsS4CmI+aiTZJmv81koTbEirSY1uWIX6i07QbzMj4QCE4SNyL+zHT5se1g++W+LG0HNHhKcXA==","X-Received":"by 2002:a19:9155:: with SMTP id y21mr7449676lfj.28.1583688783385;\n\tSun, 08 Mar 2020 10:33:03 -0700 (PDT)","Date":"Sun, 8 Mar 2020 18:33:02 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200308173302.GK2975348@oden.dyn.berto.se>","References":"<20200308000433.2917-1-laurent.pinchart@ideasonboard.com>\n\t<20200308000433.2917-6-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200308000433.2917-6-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 5/6] cam: Link against libatomic if\n\tneeded","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sun, 08 Mar 2020 17:33:04 -0000"}}]