[{"id":4009,"web_url":"https://patchwork.libcamera.org/comment/4009/","msgid":"<20200308173228.GJ2975348@oden.dyn.berto.se>","date":"2020-03-08T17:32:28","subject":"Re: [libcamera-devel] [PATCH v4 4/6] libcamera: meson: Make\n\tlibatomic and libdl dependencies reusable","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-03-08 02:04:31 +0200, Laurent Pinchart wrote:\n> libcamera.so links against libatomic and libdl, and handles those\n> dependencies directly in the shared_object() call. More components\n> within libcamera will need those dependencies, extract them to named\n> variables to make them reusable.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/meson.build | 6 ++++--\n> 1 file changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 1b69bc0dee54..87fa09cde63d 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -58,6 +58,8 @@ includes = [\n> subdir('pipeline')\n> subdir('proxy')\n> \n> +libatomic = cc.find_library('atomic', required : false)\n> +libdl = cc.find_library('dl')\n> libudev = dependency('libudev', required : false)\n> \n> if libudev.found()\n> @@ -93,8 +95,8 @@ version_cpp = vcs_tag(command : [gen_version, meson.build_root()],\n> libcamera_sources += version_cpp\n> \n> libcamera_deps = [\n> - cc.find_library('atomic', required: false),\n> - cc.find_library('dl'),\n> + libatomic,\n> + libdl,\n> libudev,\n> dependency('threads'),\n> ]\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A27DD60422\n\tfor ;\n\tSun, 8 Mar 2020 18:32:30 +0100 (CET)","by mail-lj1-x243.google.com with SMTP id f13so7524892ljp.0\n\tfor ;\n\tSun, 08 Mar 2020 10:32:30 -0700 (PDT)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\tx11sm18812316ljj.47.2020.03.08.10.32.28\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 08 Mar 2020 10:32:29 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=pqtZpFgDjO+sqITSkQKntiiCTx2JcycnrPc3QUyM/iY=;\n\tb=ws55ydnlWguKO/BY1eMnK4RU/MCNTtlDNIhewFS7z+LvC3UtTv4qfB1jct3gtwPYFc\n\tbqtQwBECPOwN1hUPKHEVwPtlvSV+0YQoSeDhb67OeuVdno1r+GIL3fpNC7wnHIcX9Tpf\n\tfDUGN/+Fbcr7Tf2rgsBRusiIHlA6+Mw4ZqfIOTzS+DxewjtZ+Jj4UrY9DAAMs44a+9MI\n\tFnx1AJc9aQCXv+kcEH1kn0oDIiofzo8ns7mnBGGZWmRq1o7GeEdwtSbwfUjUVOUzwux0\n\tNUl8WD5vroQUOmml+sdbGRnFe7eiRPo1cegYxx224k9Aw9Q4hamJOpODUO4IqWc586QD\n\tgQXA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=pqtZpFgDjO+sqITSkQKntiiCTx2JcycnrPc3QUyM/iY=;\n\tb=dkN1FDZs1ZCo78s+7fIvGGQjliHwpNQiQtH4ioyLyr7Mq+PqG16Gg42x3PPZxAlfZP\n\tCAx/By0Anye8cyCkRe6LQhSA9NIkTLPd7gZdkWux5q46xTObZTMuoTEA0Ar3PKN5mOUQ\n\tPRlsA8Wrq2vtHtejgG2JlrVucSBy59WFxldaQUKTLDdNRbQ0qO+sWZAm+TXBRCULp35n\n\t4B7P57dW1dDCuy9E+qObYa44cU6hDaOFEAvEhi8gHnp2FkiU5pKkEnZM5QKLRyLqcyBF\n\tB+g0PELFYjYBy6GCWbuP6o6za0VSd7yjo0A9z+jkJBd4pnC24mbV7E9Y3zbi13TEE88R\n\twM8w==","X-Gm-Message-State":"ANhLgQ0e//bL5flELqoQ1RyWh+xuohhl7O5LzDReAJcq3i4JthIflI9s\n\tZixc1wvtHiqCvcY9o45m8ofDpA==","X-Google-Smtp-Source":"ADFU+vsFpyynzDMnlbYRIECIVJDXwPou5yPIOFnlBysOqn5HmKBVXHfxQgb3DxztNyd5mHB9MtqWGw==","X-Received":"by 2002:a2e:9041:: with SMTP id n1mr5533359ljg.7.1583688749961; \n\tSun, 08 Mar 2020 10:32:29 -0700 (PDT)","Date":"Sun, 8 Mar 2020 18:32:28 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200308173228.GJ2975348@oden.dyn.berto.se>","References":"<20200308000433.2917-1-laurent.pinchart@ideasonboard.com>\n\t<20200308000433.2917-5-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200308000433.2917-5-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 4/6] libcamera: meson: Make\n\tlibatomic and libdl dependencies reusable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 08 Mar 2020 17:32:30 -0000"}}]