[{"id":4008,"web_url":"https://patchwork.libcamera.org/comment/4008/","msgid":"<20200308172136.GI2975348@oden.dyn.berto.se>","date":"2020-03-08T17:21:36","subject":"Re: [libcamera-devel] [PATCH v4 3/6] include: libcamera: meson: Add\n\tlibcamera.h to the libcamera_api array","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-03-08 02:04:30 +0200, Laurent Pinchart wrote:\n> The libcamera_api array is meant to contain all the headers from the\n> libcamera public API, for the purpose of generating documentation and\n> creating the libcamera_dep dependency. libcamera.h is part of the\n> libcamera public API, add it to the array.\n> \n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/meson.build | 2 ++\n> src/libcamera/meson.build | 2 +-\n> 2 files changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n> index 88edf620f69e..23c01d3837ba 100644\n> --- a/include/libcamera/meson.build\n> +++ b/include/libcamera/meson.build\n> @@ -55,6 +55,8 @@ libcamera_h = custom_target('gen-header',\n> install : true,\n> install_dir : join_paths('include', include_dir))\n> \n> +libcamera_api += libcamera_h\n> +\n> version = libcamera_version.split('.')\n> libcamera_version_config = configuration_data()\n> libcamera_version_config.set('LIBCAMERA_VERSION_MAJOR', version[0])\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 88658ac563f7..1b69bc0dee54 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -120,7 +120,7 @@ libcamera = shared_library('camera',\n> build_rpath : '/',\n> dependencies : libcamera_deps)\n> \n> -libcamera_dep = declare_dependency(sources : [libcamera_api, libcamera_ipa_api, libcamera_h],\n> +libcamera_dep = declare_dependency(sources : [libcamera_api, libcamera_ipa_api],\n> include_directories : libcamera_includes,\n> link_with : libcamera)\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3D95160422\n\tfor ;\n\tSun, 8 Mar 2020 18:21:38 +0100 (CET)","by mail-lj1-x243.google.com with SMTP id u12so3296963ljo.2\n\tfor ;\n\tSun, 08 Mar 2020 10:21:38 -0700 (PDT)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\tq4sm18571181ljm.51.2020.03.08.10.21.36\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 08 Mar 2020 10:21:36 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=cQOgVDnKXzXR59ALTD4iCvGQjJcNmr8BE/Idjl5eL54=;\n\tb=KQZRABvn6cdQ/6q1p//ovJsfiwomlQfkR24SdwY4zZumdeefrkEyaZlqeY2aygJrCw\n\tZzEG394Slcm52t/e2WYZ/GN6BBCJurDVYoAs93Fb/9FfqMv3LqU8XaC0tbPhaw3PDxeQ\n\teDg4+/W1dXnEsV98MU+ALsgPdGAcK/X2cZroGZuX1vLr8qeud+fNMhHaRS6Mv5f93zbc\n\treRJ+c3qf6cHbp3cDCo4TzL1UGt8iSd8h6RV7C6MoMGuAgYmEprLVcC+5zKuJUqoDF9E\n\t37HfihM9yuPV+CKjEbfJOnJeFNvzLuX0JTQwqnqSAKrXiroW2gYAF39+lUcouAqn9Rz5\n\teRLg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=cQOgVDnKXzXR59ALTD4iCvGQjJcNmr8BE/Idjl5eL54=;\n\tb=WoFuSd4XK9sq9tKNMr67zDNecf3NoQKDmjAMcjral/PIwOUje4Qyd9Bf3tPDBjTKEf\n\tbobAaL4fsyTOkkjBzdA7tMXj3HuUSfhs4NU2DLPtRYzeoJ9Iv0ezoadxPLTBYOVvRNn3\n\tCxwDDJKOugWWS94z/hodO+BNjUzsLUgczq3b3Pq/k56y/51kkR1quJbb+uJyRN/b+tTR\n\tl/vf16gqkn2EG83m/OULAR6CykYCZVuSvrxTUwi8xvmcHeXx0to5QldDKJCn++9Bwwv8\n\tRZBupR6EXK6zAUC9cnD9n9O7PSLkFZmQ3af5QJKLHMaE37q5rE60ttv7kRn+TavLNjXv\n\tfnMg==","X-Gm-Message-State":"ANhLgQ07g2XObgR7QiZ1O8zo7TIi/cSfy70ShmuWTQ6UcLm1UgvMGQIu\n\t7DqF2CKUDiVJfnKozHZxy8vgkwZ/nj8=","X-Google-Smtp-Source":"ADFU+vvY8wIAruaanN6CFOImKJcS403BZlF0TjJxPqqXWS4ncXEGwht69dFXgnw2/lj8vtKO/Av7gw==","X-Received":"by 2002:a2e:800a:: with SMTP id j10mr4748009ljg.23.1583688097591;\n\tSun, 08 Mar 2020 10:21:37 -0700 (PDT)","Date":"Sun, 8 Mar 2020 18:21:36 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200308172136.GI2975348@oden.dyn.berto.se>","References":"<20200308000433.2917-1-laurent.pinchart@ideasonboard.com>\n\t<20200308000433.2917-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200308000433.2917-4-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 3/6] include: libcamera: meson: Add\n\tlibcamera.h to the libcamera_api array","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 08 Mar 2020 17:21:38 -0000"}}]