[{"id":4007,"web_url":"https://patchwork.libcamera.org/comment/4007/","msgid":"<20200308171319.GH2975348@oden.dyn.berto.se>","date":"2020-03-08T17:13:19","subject":"Re: [libcamera-devel] [PATCH v4 2/6] include: libcamera: meson: Add\n\tcontrol headers to the libcamera_api array","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nThanks for your work.\n\nOn 2020-03-08 02:04:29 +0200, Laurent Pinchart wrote:\n> From: Kieran Bingham \n> \n> The libcamera_api array is meant to contain all the headers from the\n> libcamera public API, for the purpose of generating documentation and\n> creating the libcamera_dep dependency. The generated control headers are\n> part of the libcamera public API, and used to be included in the\n> libcamera_api array until commit f870591a9bf5 (\"libcamera: properties:\n> Add location property\") inadvertently removed them. Add them back.\n> \n> Fixes: f870591a9bf5 (\"libcamera: properties: Add location property\")\n> Signed-off-by: Kieran Bingham \n> [Split the change out and reworded the commit message]\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/meson.build | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n> index f47c583cbbc0..88edf620f69e 100644\n> --- a/include/libcamera/meson.build\n> +++ b/include/libcamera/meson.build\n> @@ -44,6 +44,8 @@ foreach header : control_source_files\n> install_dir : join_paths('include', include_dir))\n> endforeach\n> \n> +libcamera_api += control_headers\n> +\n> gen_header = files('gen-header.sh')\n> \n> libcamera_h = custom_target('gen-header',\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A89F460422\n\tfor ;\n\tSun, 8 Mar 2020 18:13:20 +0100 (CET)","by mail-lj1-x241.google.com with SMTP id d12so7490075lji.4\n\tfor ;\n\tSun, 08 Mar 2020 10:13:20 -0700 (PDT)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\tf9sm1022273ljo.73.2020.03.08.10.13.19\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 08 Mar 2020 10:13:19 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=6uaHImRx9wGISa/VaekYh2lgCVBiyX6xDljaR8Y4hxg=;\n\tb=iuUOM6NLNs7aGa4azwTb8U7DRnj9w28nDDC4yCEAgEkRs/2gFfXM75kMb+SFwLytXh\n\te4//eAt+FHPUZAqfJP0JRLK0vV2F9oWiJXRle9GoXIoC8k40jFi6bdw3dSKt7wOdNlgl\n\t3cNoSO6bMTLuNSk33/QFmj51FuMBBOshV3yd78QltX1Xh54pvHbACGsJ7g7zshKxtkk+\n\tFujNmw4gRpLFNq64xqP3GVI87lSXhyLf2Eh4P+ISUGu+DztJmN5ZbwX97HcoVJqWoQ1j\n\t7wIXrwEtpqCdT65TmHRdyTtA01BdHvlcqOSgZInLJj6/YWHix443ribFHh6Z+cT7AgEQ\n\tHLiA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=6uaHImRx9wGISa/VaekYh2lgCVBiyX6xDljaR8Y4hxg=;\n\tb=C/eVdv0rRXtOGRDGCQuF06e5JXHxdvtNSJBgVYJSmnZVlAMAqy+JNfq4/Nj28zOEZz\n\tNav+m6VxLM+sMKD0xIMTt9hPSGzGseaujIN3XI2fybBHLYdIm/p9htG5pQeT3C4T4oAv\n\t0qsJ0ipzr7OhrjgR1m96xeScgwlEvP4rGRBU65VtUIpOHzfvTZpy8FV5tE97UzNh1adP\n\tNRv0rhdtVb/mfWl4cV+C4T3rwX0RiFYUH9vhDGzQIYc+v2mbBbYwZOI/pLlJZIidmmDR\n\tDPGVO+0BqwOOi7HSp8sNj+4ikqLML0288906Peibbk8snlSht9Bo9gvshQ2t4h62TESw\n\tSH3g==","X-Gm-Message-State":"ANhLgQ31KxuJvcFgjQ332nvFXLP96gY2DBDWqmp2W0z6I0F2RlH+NNMd\n\tST85hceQRTZdlAqpxzw4MuroQw==","X-Google-Smtp-Source":"ADFU+vuqTOOfsGjkzr/2Dgf2OXZlIE9sh8yUKqt62WzaELROAjdHWY/2dWeLP44/N54CHfmpN2pCgA==","X-Received":"by 2002:a2e:9790:: with SMTP id y16mr145847lji.275.1583687600154;\n\tSun, 08 Mar 2020 10:13:20 -0700 (PDT)","Date":"Sun, 8 Mar 2020 18:13:19 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200308171319.GH2975348@oden.dyn.berto.se>","References":"<20200308000433.2917-1-laurent.pinchart@ideasonboard.com>\n\t<20200308000433.2917-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200308000433.2917-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 2/6] include: libcamera: meson: Add\n\tcontrol headers to the libcamera_api array","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 08 Mar 2020 17:13:20 -0000"}}]