[{"id":4006,"web_url":"https://patchwork.libcamera.org/comment/4006/","msgid":"<20200308171151.GG2975348@oden.dyn.berto.se>","date":"2020-03-08T17:11:51","subject":"Re: [libcamera-devel] [PATCH v4 1/6] include: libcamera: Improve\n\tautomation of libcamera.h generation","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2020-03-08 02:04:28 +0200, Laurent Pinchart wrote:\n> The gen-header.sh script that generates libcamera.h takes all .h files\n> in the include/libcamera/ directory, and manually adds the generated\n> control_ids.h and version.h. This is fragile, as shown by the failure to\n> add property_ids.h to the list in commit f870591a9bf5 (\"libcamera:\n> properties: Add location property\").\n> \n> To avoid future omissions, take all the .h.in files into account to\n> generate libcamera.h. This also fixes the missing property_ids.h.\n> \n> Fixes: f870591a9bf5 (\"libcamera: properties: Add location property\")\n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/gen-header.sh | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/gen-header.sh b/include/libcamera/gen-header.sh\n> index 7f7816c9f879..fcb9c5e16d07 100755\n> --- a/include/libcamera/gen-header.sh\n> +++ b/include/libcamera/gen-header.sh\n> @@ -16,10 +16,11 @@ cat < \"$dst_file\"\n> \n> EOF\n> \n> -headers=$(for header in \"$src_dir\"/*.h ; do\n> +headers=$(for header in \"$src_dir\"/*.h \"$src_dir\"/*.h.in ; do\n> \theader=$(basename \"$header\")\n> +\theader=\"${header%.in}\"\n> \techo \"$header\"\n> -done ; echo \"control_ids.h\" ; echo \"version.h\" | sort)\n> +done | sort)\n> \n> for header in $headers ; do\n> \techo \"#include \" >> \"$dst_file\"\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2419D60422\n\tfor ;\n\tSun, 8 Mar 2020 18:11:53 +0100 (CET)","by mail-lf1-x143.google.com with SMTP id s1so5724630lfd.3\n\tfor ;\n\tSun, 08 Mar 2020 10:11:53 -0700 (PDT)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\to23sm10214828ljc.9.2020.03.08.10.11.51\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 08 Mar 2020 10:11:51 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=WlYTQzcai9kiLJ3ts5ob13M3/K13gCi3AqptH+JsxYY=;\n\tb=iVXZ14U3JQjYyEkVHF5biAt4C89cA4oWITksHqvQ4OqCUS09TlM5lhHgKx/u596qYW\n\toDa8N2FQTJGnau2UEAA0KXpgyG/ARw7WiLumCwe9li7MuYpF9NsinSWmdfTRLcLTIair\n\tFYeoe4jMPpA5nLlkFRFUb5oT7WQ3RSI0Dbo6wmtjEkR90kut0YaycT7zpVvSYjCYJt5c\n\tRyCDVPutehDu5c8eH7eO9hLWHRlQXWbYqujUDEHDDUo7PT2zsZ11ofPOLT2RQui+8lYr\n\tvHcJ1rVS7QtZFlcWxQxsWin8XG//ZmobjDAFEecalVYLUDr3CJ8T52VSKb/bD+VqYD69\n\t/yNg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=WlYTQzcai9kiLJ3ts5ob13M3/K13gCi3AqptH+JsxYY=;\n\tb=AaQD0y5wZg1b9vaw7hr/IeoqIikwDG9yYc0A9Rq58QpE+Ie7/xR5xHrTKHugp9vklf\n\tml037w2RLcr19so4CNr3B0vkv7vcsiGTox0x0Ijn96l1o+oajPsYKTZsOcIvCmpY6gC0\n\tBoKpVfh7m9dSEm6eZ/MlZJ6ym68VQb3acIaXfctOT+80a/t6Mw6JlqN1m8rKyZBJE+14\n\tNFfcrXp2ZIQ3hBxwVt1C/RarcNtxkfcPd5qB12Z5LiOZeYl5PwMYe2k1nGqPRfzXQ8u+\n\t+EbdtTmjpH9TQwQz0vp4HA+NBJm3vTScAR9o5+Z71dAcdv3lZKbeVmv04XHIXuHTeSkd\n\trfjQ==","X-Gm-Message-State":"ANhLgQ1dWp26ZlnT5BR6Pjy5kOgcGf7VqDjpg66nqTQrkJpHq9FYZ9pd\n\tiheswDOy6a4rYE8r2RaasAy59qmrv2I=","X-Google-Smtp-Source":"ADFU+vu1w3NpcanzcglGc3qRzIkJwfLgq8aL9e/FWCjilAofJ3ekDOT4Md4LUFUedKH/HVqLzUsNpw==","X-Received":"by 2002:a19:8c4d:: with SMTP id i13mr7395410lfj.42.1583687512490;\n\tSun, 08 Mar 2020 10:11:52 -0700 (PDT)","Date":"Sun, 8 Mar 2020 18:11:51 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200308171151.GG2975348@oden.dyn.berto.se>","References":"<20200308000433.2917-1-laurent.pinchart@ideasonboard.com>\n\t<20200308000433.2917-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200308000433.2917-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 1/6] include: libcamera: Improve\n\tautomation of libcamera.h generation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 08 Mar 2020 17:11:53 -0000"}}]