{"id":3052,"url":"https://patchwork.libcamera.org/api/patches/3052/?format=json","web_url":"https://patchwork.libcamera.org/patch/3052/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200308000433.2917-2-laurent.pinchart@ideasonboard.com>","date":"2020-03-08T00:04:28","name":"[libcamera-devel,v4,1/6] include: libcamera: Improve automation of libcamera.h generation","commit_ref":"00804512c6c091b3062beced6085b1b65badb8b8","pull_url":null,"state":"accepted","archived":false,"hash":"4606308deaafccef2ef4882b21b616c82f8c6e29","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3052/mbox/","series":[{"id":714,"url":"https://patchwork.libcamera.org/api/series/714/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=714","date":"2020-03-08T00:04:27","name":"Fix race condition and other build issues","version":4,"mbox":"https://patchwork.libcamera.org/series/714/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3052/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3052/checks/","tags":{},"headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D1290628F0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun,  8 Mar 2020 01:04:42 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7388724B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun,  8 Mar 2020 01:04:42 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583625882;\n\tbh=8kxyd005ARWtlJ/21kzYQJgWKN/5d6J4zzH+XdfH3Oo=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=fRhMwp4JGSMlRpt0Dqv+HYAzu20znV7c1tlpJdD/REfl4TvFNaYb/M1fwcPhf7Bdm\n\t7F5hjD0v2z5Zo7ta+5azbEBmEjfwnJqbtft2pm3/8uY3gK50zAExmIwoc+borLpaV0\n\tcBF0z44tFzwCoxsonB5n9HfJACLAHtJNlICDUg0w=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Sun,  8 Mar 2020 02:04:28 +0200","Message-Id":"<20200308000433.2917-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200308000433.2917-1-laurent.pinchart@ideasonboard.com>","References":"<20200308000433.2917-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 1/6] include: libcamera: Improve\n\tautomation of libcamera.h generation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sun, 08 Mar 2020 00:04:43 -0000"},"content":"The gen-header.sh script that generates libcamera.h takes all .h files\nin the include/libcamera/ directory, and manually adds the generated\ncontrol_ids.h and version.h. This is fragile, as shown by the failure to\nadd property_ids.h to the list in commit f870591a9bf5 (\"libcamera:\nproperties: Add location property\").\n\nTo avoid future omissions, take all the .h.in files into account to\ngenerate libcamera.h. This also fixes the missing property_ids.h.\n\nFixes: f870591a9bf5 (\"libcamera: properties: Add location property\")\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/libcamera/gen-header.sh | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/include/libcamera/gen-header.sh b/include/libcamera/gen-header.sh\nindex 7f7816c9f879..fcb9c5e16d07 100755\n--- a/include/libcamera/gen-header.sh\n+++ b/include/libcamera/gen-header.sh\n@@ -16,10 +16,11 @@ cat <<EOF > \"$dst_file\"\n \n EOF\n \n-headers=$(for header in \"$src_dir\"/*.h ; do\n+headers=$(for header in \"$src_dir\"/*.h \"$src_dir\"/*.h.in ; do\n \theader=$(basename \"$header\")\n+\theader=\"${header%.in}\"\n \techo \"$header\"\n-done ; echo \"control_ids.h\" ; echo \"version.h\" | sort)\n+done | sort)\n \n for header in $headers ; do\n \techo \"#include <libcamera/$header>\" >> \"$dst_file\"\n","prefixes":["libcamera-devel","v4","1/6"]}