[{"id":4005,"web_url":"https://patchwork.libcamera.org/comment/4005/","msgid":"<20200308164251.GF2975348@oden.dyn.berto.se>","date":"2020-03-08T16:42:51","subject":"Re: [libcamera-devel] [PATCH] test: file-descriptor: Fix undefined\n\tO_TMPFILE compilation error","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-03-07 23:25:29 +0200, Laurent Pinchart wrote:\n> O_TMPFILE is not defined by all libc implementations. libcamera has an\n> internal definition in utils.h to work around this. Include utils.h in\n> the test to fix the compilation error.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> test/file-descriptor.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/test/file-descriptor.cpp b/test/file-descriptor.cpp\n> index 3e5e880093e7..e467f3a7145e 100644\n> --- a/test/file-descriptor.cpp\n> +++ b/test/file-descriptor.cpp\n> @@ -14,6 +14,7 @@\n> #include \n> \n> #include \"test.h\"\n> +#include \"utils.h\"\n> \n> using namespace libcamera;\n> using namespace std;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EAF3960422\n\tfor ;\n\tSun, 8 Mar 2020 17:42:52 +0100 (CET)","by mail-lj1-x241.google.com with SMTP id f10so7430074ljn.6\n\tfor ;\n\tSun, 08 Mar 2020 09:42:52 -0700 (PDT)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\ta14sm357262lfj.71.2020.03.08.09.42.51\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 08 Mar 2020 09:42:51 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=o4cCs1onMK5lRcyDVcyABccGpXrSI22hgQhHGSZwFns=;\n\tb=EALoAB5MIiwKymozQ4YRC6PugMvA8JBZGB/pItRVsy3VpBF6RS5KYxrCH9v91VpHQi\n\tzi3VFXhocWvMoPVCp35XRaJsbAmL/93O0GpEsbuP7eBj+1OOcKL5n1mV0IeIi8Lo9GoK\n\tg3ub9LD1FgA8csDt3RITltZMpSbZprBoqDhaUidmxgBIq9Ng2MjjtfVAQac4ada83f7X\n\t81/Ryszce7Etp7E76kzGUzs3Wbx5wk0EpaeqYvl7PvSiql6hYOrIax9K9n2pmskJDoqM\n\tBPFtuCRcmqCrM/im1PUK+OswWQgn8OCao+uy+Fg2QhALJM1VQEHAfCTOq0ORkLZXQaGw\n\t2DHQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=o4cCs1onMK5lRcyDVcyABccGpXrSI22hgQhHGSZwFns=;\n\tb=Xnn7IIVX58nDJNZa5+zaxVBFJJKPkYLMSaG1uRKeJdys/qRHmksHY63PQNPY0xeiuV\n\tzxanwY2j2hIqLYljnlHR2oLUY5r9npTxIrOWd60kiBx+MlBQJJh9zKAHjcmylsGPPtsB\n\t/uK1jmDp/1k3wIQBKLiuVbeXenOqM4XLB+MH2YyJK9ebHMH4C/UgQ4oi+gFkvPQctbYu\n\tNwP+3RtTeTIQqHdumLnfW15IFBrNs7EJ4lZ9qx4v016wqqQ0BKY8PL1ohaKNiV+TuBJK\n\tz74i5h0YmWJsqLRoI7RSa7b3AXX06whwyeL0Ti5fMadTijlMhN8v8XFl9GP0rk0ehmr4\n\trYnA==","X-Gm-Message-State":"ANhLgQ07sNWZGodFlrA6WSj7+UGWNNdwJZfD9DbDKo5GwxfjC48f+XR+\n\tgSvlI+edHwm7sxWK1YIj9CmIog8O940=","X-Google-Smtp-Source":"ADFU+vuf5jhAw7X/8Gwbedf1/G6h/M8+UQzMqtzboZ3dSv5AOV9w+iENE0Byhfp/NcUG+ZwSrQ8l9Q==","X-Received":"by 2002:a2e:95cd:: with SMTP id\n\ty13mr7488386ljh.147.1583685772358; \n\tSun, 08 Mar 2020 09:42:52 -0700 (PDT)","Date":"Sun, 8 Mar 2020 17:42:51 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200308164251.GF2975348@oden.dyn.berto.se>","References":"<20200307212530.28053-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200307212530.28053-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] test: file-descriptor: Fix undefined\n\tO_TMPFILE compilation error","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 08 Mar 2020 16:42:53 -0000"}}]