[{"id":4004,"web_url":"https://patchwork.libcamera.org/comment/4004/","msgid":"<20200308163719.GE2975348@oden.dyn.berto.se>","date":"2020-03-08T16:37:19","subject":"Re: [libcamera-devel] [PATCH] v4l2: v4l2_camera_proxy: Fix sign\n\tcompare compilation error","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-03-07 23:25:28 +0200, Laurent Pinchart wrote:\n> When compiling for ARM and uClibc, gcc-8.3.0 complains about comparison\n> of integer expressions of different signedness:\n> \n> ../../src/v4l2/v4l2_camera_proxy.cpp: In member function ‘void* V4L2CameraProxy::mmap(void*, size_t, int, int, off_t)’:\n> ../../src/v4l2/v4l2_camera_proxy.cpp:88:25: error: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘off_t’ {aka ‘long int’} [-Werror=sign-compare]\n> if (index * sizeimage_ != offset || length != sizeimage_) {\n> ~~~~~~~~~~~~~~~~~~~^~~~~~~~~\n> \n> Fix the compilation error with a cast.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/v4l2/v4l2_camera_proxy.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index 622520479be0..b620f236499c 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -85,7 +85,8 @@ void *V4L2CameraProxy::mmap(void *addr, size_t length, int prot, int flags,\n> \t}\n> \n> \tunsigned int index = offset / sizeimage_;\n> -\tif (index * sizeimage_ != offset || length != sizeimage_) {\n> +\tif (static_cast(index * sizeimage_) != offset ||\n> +\t length != sizeimage_) {\n> \t\terrno = EINVAL;\n> \t\treturn MAP_FAILED;\n> \t}\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0317260422\n\tfor ;\n\tSun, 8 Mar 2020 17:37:20 +0100 (CET)","by mail-lj1-x241.google.com with SMTP id f10so7421476ljn.6\n\tfor ;\n\tSun, 08 Mar 2020 09:37:20 -0700 (PDT)","from localhost (h-200-138.A463.priv.bahnhof.se. [176.10.200.138])\n\tby smtp.gmail.com with ESMTPSA id\n\tl12sm9146703ljo.71.2020.03.08.09.37.19\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 08 Mar 2020 09:37:19 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=Z4yebAxmYbqjGVozM1/Kx6A+nInBm04qgRxfVDvM9fI=;\n\tb=yrzsT16edhOU7wtE5cs9dY0enN2O8VuTcXRnuYHsV8fVJWxtjUQG8NxuecTwApLQJW\n\twbbIDNR6fdLkXljqeU2jKb16x8Hy3+elLrdmmzum2XNjDpwYe8+gSljfUaTZoCr/vx/+\n\tOLjxz7xrV6kgb2BL3NA17MFI4ky1gz8sTT4yamTycWfamBSTlS1Rcm+KL43h+4CoCOGo\n\t+nQPABdNj28aXqoRmHfYZRQB8oizF4U6ZW8r7zVw/XUyXO29PADjNhu0ln4ZP5bTDU7Z\n\t3LjySVmnFYCAUs9PUSRl9ptuqlBa5IpPKolK7GDpk0AWwbz8emmUlFlkPOedK1Bjfc+k\n\tyUww==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=Z4yebAxmYbqjGVozM1/Kx6A+nInBm04qgRxfVDvM9fI=;\n\tb=VDoUJI7t1UDFejmMoYAk5XD16m81tbCZcFw0Qj0Ra7KF50XBxruolFmhXv9MYEonY5\n\tdwPsM2cYqQkzLC/Pt2MqXBPUudCR+NnEUcrGBhXI2WKM1llGOaOc3aXRM9JXfpN3lfbx\n\tdcLdKrDsuRknDEMVH2aAIo/G+6/pWeG7V+l5ZEWuCsb8DZZgyLhibWeFDJpNrhb7eyOg\n\t8f4mfPkBc4leKYJy44P3lAgddwyXSJMK2/i5cAzWj9Tc0GqjApGJ1Lh0cqi9v2gU1G0l\n\t5nGL53ytVsI+tRD4QJ9g//lLMustOcjYwBdf9ptOqP8KzNtaFg0gPgEwphlVbhx5laB5\n\tFZlg==","X-Gm-Message-State":"ANhLgQ0IUtjxnRY1etrDnwFSb3FAoBjckM43eVUtULa7lGJtnTwIYn8X\n\tGajj7Cb+X42zChGNP4f/g24Rwvijk10=","X-Google-Smtp-Source":"ADFU+vvj5XTElQDIawBJFoF3faa8H5QaTXrAML/cR73I+u0x7Kyiuc+CT6VwIxN00wywtpvDpdBGPg==","X-Received":"by 2002:a2e:9e19:: with SMTP id\n\te25mr7837285ljk.179.1583685440137; \n\tSun, 08 Mar 2020 09:37:20 -0700 (PDT)","Date":"Sun, 8 Mar 2020 17:37:19 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200308163719.GE2975348@oden.dyn.berto.se>","References":"<20200307212530.28053-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200307212530.28053-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] v4l2: v4l2_camera_proxy: Fix sign\n\tcompare compilation error","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 08 Mar 2020 16:37:21 -0000"}}]