{"id":3048,"url":"https://patchwork.libcamera.org/api/patches/3048/?format=json","web_url":"https://patchwork.libcamera.org/patch/3048/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200307212530.28053-1-laurent.pinchart@ideasonboard.com>","date":"2020-03-07T21:25:28","name":"[libcamera-devel] v4l2: v4l2_camera_proxy: Fix sign compare compilation error","commit_ref":"1268751ce6d170dc1aa968f1314c0bb5852b1b8e","pull_url":null,"state":"accepted","archived":false,"hash":"0485aaffd080a2fb475142f46cd63aaa35dc06ac","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3048/mbox/","series":[{"id":711,"url":"https://patchwork.libcamera.org/api/series/711/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=711","date":"2020-03-07T21:25:28","name":"[libcamera-devel] v4l2: v4l2_camera_proxy: Fix sign compare compilation error","version":1,"mbox":"https://patchwork.libcamera.org/series/711/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3048/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3048/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 853786193A\n\tfor ;\n\tSat, 7 Mar 2020 22:25:38 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B5D535F\n\tfor ;\n\tSat, 7 Mar 2020 22:25:37 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583616338;\n\tbh=edz6y8KkVj7nP0TOTFF18hDFpEoZ1ounqq0qRV3Phc0=;\n\th=From:To:Subject:Date:From;\n\tb=YKWnr7MzbX7PojaQOMMnXyfVpOP44PZO2uS9OQfrilDnPQmZmOFKrwKiyO3bM6i0T\n\t8BPSM/D2WnkMPqiDD3mBOcbnrov+IreFiblmR+4/TZeYxEiO+u5pYZ/o7xJw2ZNckU\n\tTs27O1E5bC4zZoC//z2s03YqYCR3eDagQesC0A8Q=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 7 Mar 2020 23:25:28 +0200","Message-Id":"<20200307212530.28053-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] v4l2: v4l2_camera_proxy: Fix sign compare\n\tcompilation error","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 07 Mar 2020 21:25:38 -0000"},"content":"When compiling for ARM and uClibc, gcc-8.3.0 complains about comparison\nof integer expressions of different signedness:\n\n../../src/v4l2/v4l2_camera_proxy.cpp: In member function ‘void* V4L2CameraProxy::mmap(void*, size_t, int, int, off_t)’:\n../../src/v4l2/v4l2_camera_proxy.cpp:88:25: error: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘off_t’ {aka ‘long int’} [-Werror=sign-compare]\n if (index * sizeimage_ != offset || length != sizeimage_) {\n ~~~~~~~~~~~~~~~~~~~^~~~~~~~~\n\nFix the compilation error with a cast.\n\nSigned-off-by: Laurent Pinchart \n---\n src/v4l2/v4l2_camera_proxy.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex 622520479be0..b620f236499c 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -85,7 +85,8 @@ void *V4L2CameraProxy::mmap(void *addr, size_t length, int prot, int flags,\n \t}\n \n \tunsigned int index = offset / sizeimage_;\n-\tif (index * sizeimage_ != offset || length != sizeimage_) {\n+\tif (static_cast(index * sizeimage_) != offset ||\n+\t length != sizeimage_) {\n \t\terrno = EINVAL;\n \t\treturn MAP_FAILED;\n \t}\n","prefixes":["libcamera-devel"]}