[{"id":3993,"web_url":"https://patchwork.libcamera.org/comment/3993/","msgid":"<649c9784-732a-7517-c203-b677a52934cb@ideasonboard.com>","date":"2020-03-07T22:52:29","subject":"Re: [libcamera-devel] [PATCH v3 6/7] v4l2: v4l2_compat: Use correct\n\tlibcamera_dep dependency","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 07/03/2020 21:13, Laurent Pinchart wrote:\n> The v4l2-compat shared library is declared as depending on\n> libcamera_deps. This is not correct, as libcamera_deps contains the\n> dependencies of libcamera itself. The correct dependency for users of\n> libcamera is libcamera_dep.\n> \n> Fixing this allows dropping libcamera_includes from the list of includes\n> required by v4l2-compat, and libcamera from the link_with list, as they\n> are already contained in libcamera_dep. We however need to add an\n> explicit dependency on libdl which was previously provided by\n> libcamera_deps.\n> \n> Signed-off-by: Laurent Pinchart \n\nAha excellent, and also this brings in libcamera_api as a dependency to\nv4l2_compat which it seems wasn't before!\n\n\nFrom:\n\nhttps://gitlab.com/libcamera/libcamera/-/jobs/463333443\nbefore this patch to:\nhttps://gitlab.com/libcamera/libcamera/-/jobs/463335113\n\nWhere it can clearly be seen that the v4l2_compat library is now built\nmuch later in the sequences (and all generated files are now first which\nis good).\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/v4l2/meson.build | 16 +++++++++-------\n> 1 file changed, 9 insertions(+), 7 deletions(-)\n> \n> diff --git a/src/v4l2/meson.build b/src/v4l2/meson.build\n> index 14ee3594747d..91f4170da852 100644\n> --- a/src/v4l2/meson.build\n> +++ b/src/v4l2/meson.build\n> @@ -5,11 +5,6 @@ v4l2_compat_sources = files([\n> 'v4l2_compat_manager.cpp',\n> ])\n> \n> -v4l2_compat_includes = [\n> - libcamera_includes,\n> - libcamera_internal_includes,\n> -]\n> -\n> v4l2_compat_cpp_args = [\n> # Meson enables large file support unconditionally, which redirect file\n> # operations to 64-bit versions. This results in some symbols being\n> @@ -21,11 +16,18 @@ v4l2_compat_cpp_args = [\n> '-fvisibility=hidden',\n> ]\n> \n> +v4l2_compat_deps = [\n> + cc.find_library('dl'),\n> +]\n> +\n> +v4l2_compat_includes = [\n> + libcamera_internal_includes,\n\nHrm ... this could presumably now go straight into the\ninclude_directories declaration below.\n\nDo you think it will grow and merit staying as it's own array?\n\n> +]\n> +\n> v4l2_compat = shared_library('v4l2-compat',\n> v4l2_compat_sources,\n> name_prefix : '',\n> install : true,\n> - link_with : libcamera,\n> include_directories : v4l2_compat_includes,\n> - dependencies : libcamera_deps,\n> + dependencies : [ libcamera_dep, v4l2_compat_deps ],\n> cpp_args : v4l2_compat_cpp_args)\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 825AE62826\n\tfor ;\n\tSat, 7 Mar 2020 23:52:32 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A17945F;\n\tSat, 7 Mar 2020 23:52:31 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583621552;\n\tbh=pYNDlp8CQ3+1+SvbBmkE8swv/OnZAb8UIFV+hxtqZ8A=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=k51zGgDb9J9HMeKc2Snbjxk78Dhngvv2bxg1gYaO/bqNMa0lZjkFbsVrUy2Wwpchp\n\ti/pT4BHKz+UT0eEQoH+MeoXLJNU4v1Ra1s3ZbIbN+AQ42wtEQSmHkr1Rnzs1L93MAx\n\ty204srsiQgWXKOEnNn7O9WP0HX0Qu7RiTXABxIXw=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200307211326.26994-1-laurent.pinchart@ideasonboard.com>\n\t<20200307211326.26994-7-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<649c9784-732a-7517-c203-b677a52934cb@ideasonboard.com>","Date":"Sat, 7 Mar 2020 22:52:29 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200307211326.26994-7-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v3 6/7] v4l2: v4l2_compat: Use correct\n\tlibcamera_dep dependency","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 07 Mar 2020 22:52:32 -0000"}},{"id":4002,"web_url":"https://patchwork.libcamera.org/comment/4002/","msgid":"<20200307234412.GD31018@pendragon.ideasonboard.com>","date":"2020-03-07T23:44:12","subject":"Re: [libcamera-devel] [PATCH v3 6/7] v4l2: v4l2_compat: Use correct\n\tlibcamera_dep dependency","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Sat, Mar 07, 2020 at 10:52:29PM +0000, Kieran Bingham wrote:\n> On 07/03/2020 21:13, Laurent Pinchart wrote:\n> > The v4l2-compat shared library is declared as depending on\n> > libcamera_deps. This is not correct, as libcamera_deps contains the\n> > dependencies of libcamera itself. The correct dependency for users of\n> > libcamera is libcamera_dep.\n> > \n> > Fixing this allows dropping libcamera_includes from the list of includes\n> > required by v4l2-compat, and libcamera from the link_with list, as they\n> > are already contained in libcamera_dep. We however need to add an\n> > explicit dependency on libdl which was previously provided by\n> > libcamera_deps.\n> > \n> > Signed-off-by: Laurent Pinchart \n> \n> Aha excellent, and also this brings in libcamera_api as a dependency to\n> v4l2_compat which it seems wasn't before!\n> \n> From:\n> \n> https://gitlab.com/libcamera/libcamera/-/jobs/463333443\n> before this patch to:\n> https://gitlab.com/libcamera/libcamera/-/jobs/463335113\n> \n> Where it can clearly be seen that the v4l2_compat library is now built\n> much later in the sequences (and all generated files are now first which\n> is good).\n> \n> Reviewed-by: Kieran Bingham \n> \n> > ---\n> > src/v4l2/meson.build | 16 +++++++++-------\n> > 1 file changed, 9 insertions(+), 7 deletions(-)\n> > \n> > diff --git a/src/v4l2/meson.build b/src/v4l2/meson.build\n> > index 14ee3594747d..91f4170da852 100644\n> > --- a/src/v4l2/meson.build\n> > +++ b/src/v4l2/meson.build\n> > @@ -5,11 +5,6 @@ v4l2_compat_sources = files([\n> > 'v4l2_compat_manager.cpp',\n> > ])\n> > \n> > -v4l2_compat_includes = [\n> > - libcamera_includes,\n> > - libcamera_internal_includes,\n> > -]\n> > -\n> > v4l2_compat_cpp_args = [\n> > # Meson enables large file support unconditionally, which redirect file\n> > # operations to 64-bit versions. This results in some symbols being\n> > @@ -21,11 +16,18 @@ v4l2_compat_cpp_args = [\n> > '-fvisibility=hidden',\n> > ]\n> > \n> > +v4l2_compat_deps = [\n> > + cc.find_library('dl'),\n> > +]\n> > +\n> > +v4l2_compat_includes = [\n> > + libcamera_internal_includes,\n> \n> Hrm ... this could presumably now go straight into the\n> include_directories declaration below.\n> \n> Do you think it will grow and merit staying as it's own array?\n\nI'm not sure, I don't mind much either way. I'll inline both\nv4l2_compat_deps and v4l2_compat_includes.\n\n> > +]\n> > +\n> > v4l2_compat = shared_library('v4l2-compat',\n> > v4l2_compat_sources,\n> > name_prefix : '',\n> > install : true,\n> > - link_with : libcamera,\n> > include_directories : v4l2_compat_includes,\n> > - dependencies : libcamera_deps,\n> > + dependencies : [ libcamera_dep, v4l2_compat_deps ],\n> > cpp_args : v4l2_compat_cpp_args)\n> >","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 413B460424\n\tfor ;\n\tSun, 8 Mar 2020 00:44:17 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A87755F;\n\tSun, 8 Mar 2020 00:44:16 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583624656;\n\tbh=4ZvDV0v7b8Jzfkq74adWPfMkOrn0h3dTbl3UJZ4/o10=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FJPWxTxpTOGKqYnmPAIfPRJckAjS1RNrFUEHZutPIHxi4CeJJXlrnNqGMUGfCfOWx\n\tkwzM8Tz0hZr3XgD8OMlORF1LjKP0pPnkbeKuQsMnxmXkVJZD7QL7ah2O9RXjH1GXcK\n\tmmdoBCYhBTiUzljpTP6Eeysvm+sW+UyDJGdTIZTc=","Date":"Sun, 8 Mar 2020 01:44:12 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200307234412.GD31018@pendragon.ideasonboard.com>","References":"<20200307211326.26994-1-laurent.pinchart@ideasonboard.com>\n\t<20200307211326.26994-7-laurent.pinchart@ideasonboard.com>\n\t<649c9784-732a-7517-c203-b677a52934cb@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<649c9784-732a-7517-c203-b677a52934cb@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v3 6/7] v4l2: v4l2_compat: Use correct\n\tlibcamera_dep dependency","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 07 Mar 2020 23:44:17 -0000"}}]