[{"id":3988,"web_url":"https://patchwork.libcamera.org/comment/3988/","msgid":"<983d4c498c6b50a7d584858f9d83f879404fd371.camel@collabora.com>","date":"2020-03-07T19:34:49","subject":"Re: [libcamera-devel] [PATCH v2 2/2] gst: Fix GLib detection","submitter":{"id":31,"url":"https://patchwork.libcamera.org/api/people/31/","name":"Nicolas Dufresne","email":"nicolas.dufresne@collabora.com"},"content":"Le samedi 07 mars 2020 à 21:16 +0200, Laurent Pinchart a écrit :\n> Commit 17cccc68a88f (\"Add GStreamer plugin and element skeleton\") has\n> gained a last minute fix for a clang compilation error with GLib prior\n> to v2.63.0. The fix wasn't properly tested, and failed to check the GLib\n> dependency correctly. This resulted in compilation of the GStreamer\n> element to always be disabled.\n> \n> Fix this by changing the GLib package name from 'glib' to 'glib-2.0'.\n> \n> Fixes: 17cccc68a88f (\"Add GStreamer plugin and element skeleton\")\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nReviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n\n> ---\n>  src/gstreamer/meson.build | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/gstreamer/meson.build b/src/gstreamer/meson.build\n> index 8759a12205fa..e119e472cb58 100644\n> --- a/src/gstreamer/meson.build\n> +++ b/src/gstreamer/meson.build\n> @@ -13,7 +13,7 @@ libcamera_gst_cpp_args = [\n>      '-DPACKAGE=\"@0@\"'.format(meson.project_name()),\n>  ]\n>  \n> -glib_dep = dependency('glib', required : get_option('gstreamer'))\n> +glib_dep = dependency('glib-2.0', required : get_option('gstreamer'))\n>  \n>  gst_dep_version = '>=1.14.0'\n>  gstvideo_dep = dependency('gstreamer-video-1.0', version : gst_dep_version,","headers":{"Return-Path":"<nicolas.dufresne@collabora.com>","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AE0A760425\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat,  7 Mar 2020 20:34:52 +0100 (CET)","from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: nicolas) with ESMTPSA id 31C6028A0BD"],"Message-ID":"<983d4c498c6b50a7d584858f9d83f879404fd371.camel@collabora.com>","From":"Nicolas Dufresne <nicolas.dufresne@collabora.com>","Reply-To":"Nicolas Dufresne <nicolas.dufresne@collabora.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Date":"Sat, 07 Mar 2020 14:34:49 -0500","In-Reply-To":"<20200307191634.9320-3-laurent.pinchart@ideasonboard.com>","References":"<20200307191634.9320-1-laurent.pinchart@ideasonboard.com>\n\t<20200307191634.9320-3-laurent.pinchart@ideasonboard.com>","Organization":"Collabora","Content-Type":"multipart/signed; micalg=\"pgp-sha1\";\n\tprotocol=\"application/pgp-signature\"; \n\tboundary=\"=-WwW/7xEz31CrqINIpxcF\"","User-Agent":"Evolution 3.34.4 (3.34.4-1.fc31) ","MIME-Version":"1.0","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] gst: Fix GLib detection","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sat, 07 Mar 2020 19:34:52 -0000"}}]