{"id":3039,"url":"https://patchwork.libcamera.org/api/patches/3039/?format=json","web_url":"https://patchwork.libcamera.org/patch/3039/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200307191634.9320-3-laurent.pinchart@ideasonboard.com>","date":"2020-03-07T19:16:34","name":"[libcamera-devel,v2,2/2] gst: Fix GLib detection","commit_ref":"34396936f7a46f21422ef64769fd807876716304","pull_url":null,"state":"accepted","archived":false,"hash":"d9c9e9ba98e59cb19b6e146dccff21cd9468224f","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/3039/mbox/","series":[{"id":709,"url":"https://patchwork.libcamera.org/api/series/709/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=709","date":"2020-03-07T19:16:32","name":"Fix GStreamer element compilation","version":2,"mbox":"https://patchwork.libcamera.org/series/709/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/3039/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/3039/checks/","tags":{},"headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D6BA628CC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat,  7 Mar 2020 20:16:42 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ED3B69CC;\n\tSat,  7 Mar 2020 20:16:41 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583608602;\n\tbh=3p7fRZRhYG6ALaljRIcPJjhs6uzIqAmiyMDmPT0wGhM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=drIbIdSKu0O/VfF4t4B79lJTPVDc7f43DaVqPCzfXbUb1wVAB3TbGsKcSlIdlOiAM\n\tLA/RGTh1LZWVrRpQvzbi8bSpqz3ihkPEsLPEUNHrNz46KJeLyk0+jQTl1n5P3VSAz8\n\t0m30amuXsFqqQ/q5eDDddcVht5XucvhjzBgWyK2s=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Nicolas Dufresne <nicolas.dufresne@collabora.com>","Cc":"libcamera-devel@lists.libcamera.org","Date":"Sat,  7 Mar 2020 21:16:34 +0200","Message-Id":"<20200307191634.9320-3-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200307191634.9320-1-laurent.pinchart@ideasonboard.com>","References":"<20200307191634.9320-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 2/2] gst: Fix GLib detection","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sat, 07 Mar 2020 19:16:42 -0000"},"content":"Commit 17cccc68a88f (\"Add GStreamer plugin and element skeleton\") has\ngained a last minute fix for a clang compilation error with GLib prior\nto v2.63.0. The fix wasn't properly tested, and failed to check the GLib\ndependency correctly. This resulted in compilation of the GStreamer\nelement to always be disabled.\n\nFix this by changing the GLib package name from 'glib' to 'glib-2.0'.\n\nFixes: 17cccc68a88f (\"Add GStreamer plugin and element skeleton\")\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/gstreamer/meson.build | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/gstreamer/meson.build b/src/gstreamer/meson.build\nindex 8759a12205fa..e119e472cb58 100644\n--- a/src/gstreamer/meson.build\n+++ b/src/gstreamer/meson.build\n@@ -13,7 +13,7 @@ libcamera_gst_cpp_args = [\n     '-DPACKAGE=\"@0@\"'.format(meson.project_name()),\n ]\n \n-glib_dep = dependency('glib', required : get_option('gstreamer'))\n+glib_dep = dependency('glib-2.0', required : get_option('gstreamer'))\n \n gst_dep_version = '>=1.14.0'\n gstvideo_dep = dependency('gstreamer-video-1.0', version : gst_dep_version,\n","prefixes":["libcamera-devel","v2","2/2"]}