[{"id":3987,"web_url":"https://patchwork.libcamera.org/comment/3987/","msgid":"<251f11091dd9327c556aa70674900a301a1ed16e.camel@collabora.com>","date":"2020-03-07T19:34:01","subject":"Re: [libcamera-devel] [PATCH v2 1/2] gst: Turn the top-level plugin\n\tfile gstlibcamera.c into a C++ file","submitter":{"id":31,"url":"https://patchwork.libcamera.org/api/people/31/","name":"Nicolas Dufresne","email":"nicolas.dufresne@collabora.com"},"content":"Le samedi 07 mars 2020 à 21:16 +0200, Laurent Pinchart a écrit :\n> The top-level plugin file gstlibcamera.c is the only C source file in\n> the whole libcamera GStreamer element. To avoid specifying both C and\n> C++ compiler arguments in the future, turn it into a C++ file.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Nicolas Dufresne \n\n> ---\n> src/gstreamer/{gstlibcamera.c => gstlibcamera.cpp} | 0\n> src/gstreamer/meson.build | 8 ++++----\n> 2 files changed, 4 insertions(+), 4 deletions(-)\n> rename src/gstreamer/{gstlibcamera.c => gstlibcamera.cpp} (100%)\n> \n> diff --git a/src/gstreamer/gstlibcamera.c b/src/gstreamer/gstlibcamera.cpp\n> similarity index 100%\n> rename from src/gstreamer/gstlibcamera.c\n> rename to src/gstreamer/gstlibcamera.cpp\n> diff --git a/src/gstreamer/meson.build b/src/gstreamer/meson.build\n> index 1965b5041132..8759a12205fa 100644\n> --- a/src/gstreamer/meson.build\n> +++ b/src/gstreamer/meson.build\n> @@ -1,6 +1,6 @@\n> libcamera_gst_sources = [\n> 'gstlibcamera-utils.cpp',\n> - 'gstlibcamera.c',\n> + 'gstlibcamera.cpp',\n> 'gstlibcameraallocator.cpp',\n> 'gstlibcamerapad.cpp',\n> 'gstlibcamerapool.cpp',\n> @@ -8,7 +8,7 @@ libcamera_gst_sources = [\n> 'gstlibcamerasrc.cpp',\n> ]\n> \n> -libcamera_gst_c_args = [\n> +libcamera_gst_cpp_args = [\n> '-DVERSION=\"@0@\"'.format(libcamera_git_version),\n> '-DPACKAGE=\"@0@\"'.format(meson.project_name()),\n> ]\n> @@ -27,12 +27,12 @@ if glib_dep.found() and gstvideo_dep.found() and gstallocator_dep.found()\n> # complain about the ones we are not using. Silence the -Wunused-function\n> # warning in that case.\n> if cc.get_id() == 'clang' and glib_dep.version().version_compare('<2.63.0')\n> - libcamera_gst_c_args += [ '-Wno-unused-function' ]\n> + libcamera_gst_cpp_args += [ '-Wno-unused-function' ]\n> endif\n> \n> libcamera_gst = shared_library('gstlibcamera',\n> libcamera_gst_sources,\n> - c_args : libcamera_gst_c_args,\n> + cpp_args : libcamera_gst_cpp_args,\n> dependencies : [libcamera_dep, gstvideo_dep, gstallocator_dep],\n> install: true,\n> install_dir : '@0@/gstreamer-1.0'.format(get_option('libdir')),","headers":{"Return-Path":"","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7041C60425\n\tfor ;\n\tSat, 7 Mar 2020 20:34:05 +0100 (CET)","from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: nicolas) with ESMTPSA id B921328A0BD"],"Message-ID":"<251f11091dd9327c556aa70674900a301a1ed16e.camel@collabora.com>","From":"Nicolas Dufresne ","Reply-To":"Nicolas Dufresne ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Date":"Sat, 07 Mar 2020 14:34:01 -0500","In-Reply-To":"<20200307191634.9320-2-laurent.pinchart@ideasonboard.com>","References":"<20200307191634.9320-1-laurent.pinchart@ideasonboard.com>\n\t<20200307191634.9320-2-laurent.pinchart@ideasonboard.com>","Organization":"Collabora","Content-Type":"multipart/signed; micalg=\"pgp-sha1\";\n\tprotocol=\"application/pgp-signature\"; \n\tboundary=\"=-ACacfvfdOydc1bHYkwF4\"","User-Agent":"Evolution 3.34.4 (3.34.4-1.fc31) ","MIME-Version":"1.0","Subject":"Re: [libcamera-devel] [PATCH v2 1/2] gst: Turn the top-level plugin\n\tfile gstlibcamera.c into a C++ file","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 07 Mar 2020 19:34:05 -0000"}}]