[{"id":3969,"web_url":"https://patchwork.libcamera.org/comment/3969/","msgid":"","date":"2020-03-06T20:30:07","subject":"Re: [libcamera-devel] [PATCH v3 27/27] gst: Document dependencies\n\tand quick usage","submitter":{"id":31,"url":"https://patchwork.libcamera.org/api/people/31/","name":"Nicolas Dufresne","email":"nicolas.dufresne@collabora.com"},"content":"Le vendredi 06 mars 2020 à 15:26 -0500, Nicolas Dufresne a écrit :\n> From: Nicolas Dufresne \n> \n> This is a quick startup guide allowing to build and use the GStreamer element\n> from the libcamera source tree.\n> \n> Signed-off-by: Nicolas Dufresne \n> ---\n> README.rst | 19 +++++++++++++++++++\n> 1 file changed, 19 insertions(+)\n> \n> diff --git a/README.rst b/README.rst\n> index fa14113..a06e444 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -64,4 +64,23 @@ for qcam: [optional]\n> for documentation: [optional]\n> \tpython3-sphinx doxygen\n> \n> +for gstreamer: [optional]\n> +\tlibgstreamer1.0-dev libgstreamer-plugins-base1.0-dev\n> +\n> +Using GStreamer plugin\n> +~~~~~~~~~~~~~~~~~~~~~~\n> +\n> +To use GStreamer plugin from source tree, set the following environment so\n> that\n> +GStreamer can find it.\n> +\n> + export GST_PLUGIN_PATH=$(pwd)/build/src/gstreamer\n> +\n> +The debugging tool `gst-launch-1.0` can be used to construct and pipeline and\n> test\n> +it. The following pipeline will stream from the camera named \"Camera 1\" onto\n> the\n> +default video display element on your system.\n> +\n> +.. code::\n> +\n> + gst-launch-1.0 libcamerasrc name=\"Camera 1\" ! videoconvert ! autovideosink\n\nCrap, the property is camera-name= (not name) :-(. I'll let you review, maybe\nyou could just fixup this one for me (if we don't need a v4).\n\n> +\n> .. section-end-getting-started","headers":{"Return-Path":"","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9891560424\n\tfor ;\n\tFri, 6 Mar 2020 21:30:17 +0100 (CET)","from nicolas-tpx395.localdomain (unknown [IPv6:2610:98:8005::527])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 25A622970E7\n\tfor ;\n\tFri, 6 Mar 2020 20:30:17 +0000 (GMT)"],"Message-ID":"","From":"Nicolas Dufresne ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 06 Mar 2020 15:30:07 -0500","In-Reply-To":"<20200306202637.525587-28-nicolas@ndufresne.ca>","References":"<20200306202637.525587-1-nicolas@ndufresne.ca>\n\t<20200306202637.525587-28-nicolas@ndufresne.ca>","Content-Type":"text/plain; charset=\"UTF-8\"","User-Agent":"Evolution 3.34.4 (3.34.4-1.fc31) ","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v3 27/27] gst: Document dependencies\n\tand quick usage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 06 Mar 2020 20:30:17 -0000"}},{"id":3978,"web_url":"https://patchwork.libcamera.org/comment/3978/","msgid":"<20200306212152.GA4878@pendragon.ideasonboard.com>","date":"2020-03-06T21:21:52","subject":"Re: [libcamera-devel] [PATCH v3 27/27] gst: Document dependencies\n\tand quick usage","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nicolas,\n\nThank you for the patch.\n\nOn Fri, Mar 06, 2020 at 03:30:07PM -0500, Nicolas Dufresne wrote:\n> Le vendredi 06 mars 2020 à 15:26 -0500, Nicolas Dufresne a écrit :\n> > From: Nicolas Dufresne \n> > \n> > This is a quick startup guide allowing to build and use the GStreamer element\n> > from the libcamera source tree.\n> > \n> > Signed-off-by: Nicolas Dufresne \n> > ---\n> > README.rst | 19 +++++++++++++++++++\n> > 1 file changed, 19 insertions(+)\n> > \n> > diff --git a/README.rst b/README.rst\n> > index fa14113..a06e444 100644\n> > --- a/README.rst\n> > +++ b/README.rst\n> > @@ -64,4 +64,23 @@ for qcam: [optional]\n> > for documentation: [optional]\n> > \tpython3-sphinx doxygen\n> > \n> > +for gstreamer: [optional]\n> > +\tlibgstreamer1.0-dev libgstreamer-plugins-base1.0-dev\n> > +\n> > +Using GStreamer plugin\n> > +~~~~~~~~~~~~~~~~~~~~~~\n> > +\n> > +To use GStreamer plugin from source tree, set the following environment so that\n> > +GStreamer can find it.\n> > +\n> > + export GST_PLUGIN_PATH=$(pwd)/build/src/gstreamer\n> > +\n> > +The debugging tool `gst-launch-1.0` can be used to construct and pipeline and test\n> > +it. The following pipeline will stream from the camera named \"Camera 1\" onto the\n> > +default video display element on your system.\n> > +\n> > +.. code::\n> > +\n> > + gst-launch-1.0 libcamerasrc name=\"Camera 1\" ! videoconvert ! autovideosink\n> \n> Crap, the property is camera-name= (not name) :-(.\n\nWith this fixed,\n\nReviewed-by: Laurent Pinchart \n\nWe will then likely rework the documentation to move it to\nDocumentation.\n\n> I'll let you review, maybe\n> you could just fixup this one for me (if we don't need a v4).\n\nThere's another minor issues with a s/NULL/nullptr/, nothing that calls\nfor a v4. I can fix when applying, or make the fixes, collect the tags\nand give me a branch I can pull. Up to you.\n\n> > +\n> > .. section-end-getting-started","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 727E660424\n\tfor ;\n\tFri, 6 Mar 2020 22:21:56 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D79AF24B;\n\tFri, 6 Mar 2020 22:21:55 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583529716;\n\tbh=dszpaszffQgShoHrLL7t8L0BQCC3T7TQE+TOED/BSZQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dqzXzBrqGvXE+ilTeGoz7wPEto5/LO1nydt5uqyjD+rqt9pouJ3HnQVL3o7lYfJRb\n\txSy+HWqf5aZSmTOWN8LenoOlgazoTswabnGhw4RwC2KQsiAe7VvOvhkpeUzpPSAhEf\n\tCBUhhcSXjbab4RT74WWUUpS1pm3UJStJY+urBnsU=","Date":"Fri, 6 Mar 2020 23:21:52 +0200","From":"Laurent Pinchart ","To":"Nicolas Dufresne ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200306212152.GA4878@pendragon.ideasonboard.com>","References":"<20200306202637.525587-1-nicolas@ndufresne.ca>\n\t<20200306202637.525587-28-nicolas@ndufresne.ca>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v3 27/27] gst: Document dependencies\n\tand quick usage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 06 Mar 2020 21:21:56 -0000"}},{"id":3979,"web_url":"https://patchwork.libcamera.org/comment/3979/","msgid":"","date":"2020-03-06T21:35:33","subject":"Re: [libcamera-devel] [PATCH v3 27/27] gst: Document dependencies\n\tand quick usage","submitter":{"id":31,"url":"https://patchwork.libcamera.org/api/people/31/","name":"Nicolas Dufresne","email":"nicolas.dufresne@collabora.com"},"content":"Le vendredi 06 mars 2020 à 23:21 +0200, Laurent Pinchart a écrit :\n> Hi Nicolas,\n> \n> Thank you for the patch.\n> \n> On Fri, Mar 06, 2020 at 03:30:07PM -0500, Nicolas Dufresne wrote:\n> > Le vendredi 06 mars 2020 à 15:26 -0500, Nicolas Dufresne a écrit :\n> > > From: Nicolas Dufresne \n> > > \n> > > This is a quick startup guide allowing to build and use the GStreamer\n> > > element\n> > > from the libcamera source tree.\n> > > \n> > > Signed-off-by: Nicolas Dufresne \n> > > ---\n> > > README.rst | 19 +++++++++++++++++++\n> > > 1 file changed, 19 insertions(+)\n> > > \n> > > diff --git a/README.rst b/README.rst\n> > > index fa14113..a06e444 100644\n> > > --- a/README.rst\n> > > +++ b/README.rst\n> > > @@ -64,4 +64,23 @@ for qcam: [optional]\n> > > for documentation: [optional]\n> > > \tpython3-sphinx doxygen\n> > > \n> > > +for gstreamer: [optional]\n> > > +\tlibgstreamer1.0-dev libgstreamer-plugins-base1.0-dev\n> > > +\n> > > +Using GStreamer plugin\n> > > +~~~~~~~~~~~~~~~~~~~~~~\n> > > +\n> > > +To use GStreamer plugin from source tree, set the following environment\n> > > so that\n> > > +GStreamer can find it.\n> > > +\n> > > + export GST_PLUGIN_PATH=$(pwd)/build/src/gstreamer\n> > > +\n> > > +The debugging tool `gst-launch-1.0` can be used to construct and pipeline\n> > > and test\n> > > +it. The following pipeline will stream from the camera named \"Camera 1\"\n> > > onto the\n> > > +default video display element on your system.\n> > > +\n> > > +.. code::\n> > > +\n> > > + gst-launch-1.0 libcamerasrc name=\"Camera 1\" ! videoconvert !\n> > > autovideosink\n> > \n> > Crap, the property is camera-name= (not name) :-(.\n> \n> With this fixed,\n> \n> Reviewed-by: Laurent Pinchart \n> \n> We will then likely rework the documentation to move it to\n> Documentation.\n> \n> > I'll let you review, maybe\n> > you could just fixup this one for me (if we don't need a v4).\n> \n> There's another minor issues with a s/NULL/nullptr/, nothing that calls\n> for a v4. I can fix when applying, or make the fixes, collect the tags\n> and give me a branch I can pull. Up to you.\n\nI've applied the last reviewed-by, fixed this NULL/nullptr (which apparent was\nfixed later in the wrong patch, sorry) and fixed the documentation for the\ncamera-name property. You can pull from here (see gstreamer-v3 for the submitted\nset, just in case).\n\n https://gitlab.collabora.com/nicolas/libcamera.git gstreamer-v3-reviewed\n\n> \n> > > +\n> > > .. section-end-getting-started","headers":{"Return-Path":"","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5FE6760424\n\tfor ;\n\tFri, 6 Mar 2020 22:35:42 +0100 (CET)","from nicolas-tpx395.localdomain (unknown [IPv6:2610:98:8005::527])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 88CF7293E36;\n\tFri, 6 Mar 2020 21:35:41 +0000 (GMT)"],"Message-ID":"","From":"Nicolas Dufresne ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Date":"Fri, 06 Mar 2020 16:35:33 -0500","In-Reply-To":"<20200306212152.GA4878@pendragon.ideasonboard.com>","References":"<20200306202637.525587-1-nicolas@ndufresne.ca>\n\t<20200306202637.525587-28-nicolas@ndufresne.ca>\n\t\n\t<20200306212152.GA4878@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=\"UTF-8\"","User-Agent":"Evolution 3.34.4 (3.34.4-1.fc31) ","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v3 27/27] gst: Document dependencies\n\tand quick usage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 06 Mar 2020 21:35:42 -0000"}},{"id":3980,"web_url":"https://patchwork.libcamera.org/comment/3980/","msgid":"<20200306231311.GB4878@pendragon.ideasonboard.com>","date":"2020-03-06T23:13:11","subject":"Re: [libcamera-devel] [PATCH v3 27/27] gst: Document dependencies\n\tand quick usage","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nicolas,\n\nOn Fri, Mar 06, 2020 at 04:35:33PM -0500, Nicolas Dufresne wrote:\n> Le vendredi 06 mars 2020 à 23:21 +0200, Laurent Pinchart a écrit :\n> > On Fri, Mar 06, 2020 at 03:30:07PM -0500, Nicolas Dufresne wrote:\n> >> Le vendredi 06 mars 2020 à 15:26 -0500, Nicolas Dufresne a écrit :\n> >>> From: Nicolas Dufresne \n> >>> \n> >>> This is a quick startup guide allowing to build and use the GStreamer\n> >>> element\n> >>> from the libcamera source tree.\n> >>> \n> >>> Signed-off-by: Nicolas Dufresne \n> >>> ---\n> >>> README.rst | 19 +++++++++++++++++++\n> >>> 1 file changed, 19 insertions(+)\n> >>> \n> >>> diff --git a/README.rst b/README.rst\n> >>> index fa14113..a06e444 100644\n> >>> --- a/README.rst\n> >>> +++ b/README.rst\n> >>> @@ -64,4 +64,23 @@ for qcam: [optional]\n> >>> for documentation: [optional]\n> >>> \tpython3-sphinx doxygen\n> >>> \n> >>> +for gstreamer: [optional]\n> >>> +\tlibgstreamer1.0-dev libgstreamer-plugins-base1.0-dev\n> >>> +\n> >>> +Using GStreamer plugin\n> >>> +~~~~~~~~~~~~~~~~~~~~~~\n> >>> +\n> >>> +To use GStreamer plugin from source tree, set the following environment\n> >>> so that\n> >>> +GStreamer can find it.\n> >>> +\n> >>> + export GST_PLUGIN_PATH=$(pwd)/build/src/gstreamer\n> >>> +\n> >>> +The debugging tool `gst-launch-1.0` can be used to construct and pipeline\n> >>> and test\n> >>> +it. The following pipeline will stream from the camera named \"Camera 1\"\n> >>> onto the\n> >>> +default video display element on your system.\n> >>> +\n> >>> +.. code::\n> >>> +\n> >>> + gst-launch-1.0 libcamerasrc name=\"Camera 1\" ! videoconvert !\n> >>> autovideosink\n> >> \n> >> Crap, the property is camera-name= (not name) :-(.\n> > \n> > With this fixed,\n> > \n> > Reviewed-by: Laurent Pinchart \n> > \n> > We will then likely rework the documentation to move it to\n> > Documentation.\n> > \n> >> I'll let you review, maybe\n> >> you could just fixup this one for me (if we don't need a v4).\n> > \n> > There's another minor issues with a s/NULL/nullptr/, nothing that calls\n> > for a v4. I can fix when applying, or make the fixes, collect the tags\n> > and give me a branch I can pull. Up to you.\n> \n> I've applied the last reviewed-by, fixed this NULL/nullptr (which apparent was\n> fixed later in the wrong patch, sorry) and fixed the documentation for the\n> camera-name property. You can pull from here (see gstreamer-v3 for the submitted\n> set, just in case).\n> \n> https://gitlab.collabora.com/nicolas/libcamera.git gstreamer-v3-reviewed\n\nThank you.\n\nThis unfortunately fails to compile with clang :-S I've sent \"[PATCH]\ngst: Silence -Wunused-function warning for older GLib versions\" that\nshould fix the issue. Could you pleas review it ?\n\nI think it would be best to squash it with the first patch in this\nseries to avoid bisection breakages. Would you mind doing so in your\nbranch ?\n\n> >>> +\n> >>> .. section-end-getting-started","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 19D6F60427\n\tfor ;\n\tSat, 7 Mar 2020 00:13:15 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AB72B24B;\n\tSat, 7 Mar 2020 00:13:14 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583536394;\n\tbh=tfDNKNqCl+WfgiRAWmix5SObvVZx/k91EpRl9FBGOMI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qKjCQXq+c3kU0l+lJ3PT0SKLrBnnw8wCUDEbnUK/QQo+rXJWLgZUiBnXZ7m6Th1e+\n\tG/mfHw/Z6+HCtIM2ugAFtgbg22cqpBN2LQYqJRWD0Z2+Z685sNW2Qf0gQoIGPw5in0\n\tEYshegBrXYLMNQ2Wj21XzzuKJjjCx2jIwCDRdauU=","Date":"Sat, 7 Mar 2020 01:13:11 +0200","From":"Laurent Pinchart ","To":"Nicolas Dufresne ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200306231311.GB4878@pendragon.ideasonboard.com>","References":"<20200306202637.525587-1-nicolas@ndufresne.ca>\n\t<20200306202637.525587-28-nicolas@ndufresne.ca>\n\t\n\t<20200306212152.GA4878@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v3 27/27] gst: Document dependencies\n\tand quick usage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 06 Mar 2020 23:13:15 -0000"}}]