[{"id":3962,"web_url":"https://patchwork.libcamera.org/comment/3962/","msgid":"","date":"2020-03-06T16:25:01","subject":"Re: [libcamera-devel] [PATCH v2 31/32] test: controls:\n\tcontrol_value: Expand test to cover array controls","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 06/03/2020 16:00, Laurent Pinchart wrote:\n> Add tests to ControlValueTest to cover array controls of all supported\n> types.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\nOne discussion item below though:\n\n> ---\n> Changes since v1:\n> \n> - Renamed int8s to bytes\n> ---\n> test/controls/control_value.cpp | 101 ++++++++++++++++++++++++++++++++\n> 1 file changed, 101 insertions(+)\n> \n> diff --git a/test/controls/control_value.cpp b/test/controls/control_value.cpp\n> index 37f415302ff6..fd28bfe4604a 100644\n> --- a/test/controls/control_value.cpp\n> +++ b/test/controls/control_value.cpp\n> @@ -5,6 +5,7 @@\n> * control_value.cpp - ControlValue tests\n> */\n> \n> +#include \n> #include \n> \n> #include \n> @@ -48,6 +49,26 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> +\t\tstd::array bools{ true, false };\n> +\t\tvalue.set(Span(bools));\n> +\t\tif (value.isNone() || !value.isArray() ||\n> +\t\t value.type() != ControlTypeBool) {\n> +\t\t\tcerr << \"Control type mismatch after setting to bool array\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tSpan boolsResult = value.get>();\n> +\t\tif (bools.size() != boolsResult.size() ||\n> +\t\t !std::equal(bools.begin(), bools.end(), boolsResult.begin())) {\n> +\t\t\tcerr << \"Control value mismatch after setting to bool\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (value.toString() != \"[ true, false ]\") {\n> +\t\t\tcerr << \"Control string mismatch after setting to bool array\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> \t\t/*\n> \t\t * Integer8 type.\n> \t\t */\n> @@ -68,6 +89,26 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> +\t\tstd::array bytes{ 3, 14, 15, 9 };\n> +\t\tvalue.set(Span(bytes));\n> +\t\tif (value.isNone() || !value.isArray() ||\n> +\t\t value.type() != ControlTypeByte) {\n> +\t\t\tcerr << \"Control type mismatch after setting to uint8_t array\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tSpan int8sResult = value.get>();\n> +\t\tif (bytes.size() != int8sResult.size() ||\n> +\t\t !std::equal(bytes.begin(), bytes.end(), int8sResult.begin())) {\n> +\t\t\tcerr << \"Control value mismatch after setting to uint8_t array\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (value.toString() != \"[ 3, 14, 15, 9 ]\") {\n> +\t\t\tcerr << \"Control string mismatch after setting to uint8_t array\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> \t\t/*\n> \t\t * Integer32 type.\n> \t\t */\n> @@ -88,6 +129,26 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> +\t\tstd::array int32s{ 3, 14, 15, 9 };\n> +\t\tvalue.set(Span(int32s));\n> +\t\tif (value.isNone() || !value.isArray() ||\n> +\t\t value.type() != ControlTypeInteger32) {\n> +\t\t\tcerr << \"Control type mismatch after setting to int32_t array\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tSpan int32sResult = value.get>();\n> +\t\tif (int32s.size() != int32sResult.size() ||\n> +\t\t !std::equal(int32s.begin(), int32s.end(), int32sResult.begin())) {\n> +\t\t\tcerr << \"Control value mismatch after setting to int32_t array\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (value.toString() != \"[ 3, 14, 15, 9 ]\") {\n> +\t\t\tcerr << \"Control string mismatch after setting to int32_t array\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> \t\t/*\n> \t\t * Integer64 type.\n> \t\t */\n> @@ -108,6 +169,26 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> +\t\tstd::array int64s{ 3, 14, 15, 9 };\n> +\t\tvalue.set(Span(int64s));\n> +\t\tif (value.isNone() || !value.isArray() ||\n> +\t\t value.type() != ControlTypeInteger64) {\n> +\t\t\tcerr << \"Control type mismatch after setting to int64_t array\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tSpan int64sResult = value.get>();\n> +\t\tif (int64s.size() != int64sResult.size() ||\n> +\t\t !std::equal(int64s.begin(), int64s.end(), int64sResult.begin())) {\n> +\t\t\tcerr << \"Control value mismatch after setting to int64_t array\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (value.toString() != \"[ 3, 14, 15, 9 ]\") {\n> +\t\t\tcerr << \"Control string mismatch after setting to int64_t array\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> \t\t/*\n> \t\t * Float type.\n> \t\t */\n> @@ -128,6 +209,26 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> +\t\tstd::array floats{ 3.141593, 2.718282, 299792458.0 };\n\nStoring three floats...\n\n> +\t\tvalue.set(Span(floats));\n> +\t\tif (value.isNone() || !value.isArray() ||\n> +\t\t value.type() != ControlTypeFloat) {\n> +\t\t\tcerr << \"Control type mismatch after setting to float array\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tSpan floatsResult = value.get>();\n> +\t\tif (floats.size() != floatsResult.size() ||\n> +\t\t !std::equal(floats.begin(), floats.end(), floatsResult.begin())) {\n> +\t\t\tcerr << \"Control value mismatch after setting to float array\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (value.toString() != \"[ 3.141593, 2.718282, 299792448.000000 ]\") {\n\nSo we stored three floats including: 299792458.0 ...\nBut validated that against : 299792448.000000\n\nI presume that this will be due to floating point precision, but the\nfact we store one value and check 'another' is a bit ugly, and either\nwarrants a comment to make it explicit (and not 'hidden') or just use a\nvalue which will not lose any precision ?\n\n\nBut with that resolved how you wish, I think this is the last tag?\n\nReviewed-by: Kieran Bingham \n\n> +\t\t\tcerr << \"Control string mismatch after setting to float array\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> \t\treturn TestPass;\n> \t}\n> };\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CFC6D60424\n\tfor ;\n\tFri, 6 Mar 2020 17:25:05 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 334EF24B;\n\tFri, 6 Mar 2020 17:25:05 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583511905;\n\tbh=+tdj6wl2K726APc7EXYs0tRfOmqRKAmGXTQW4aOdNRw=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=vxeCk459eLwjsCc7MSGRblpsr4MARu5TYKxJhsprcVHSUD4bm5fi+Y5DXASWb0IfD\n\tmAYs2GF2DAoX0UJjsHJPxbQpIzW/a5K6ifRJSQgu0DadsAgNirhFx+otZUvolt41TB\n\tsGrCW+yMNF4TgbWjW7KkeVRby/UO8J0shMxlZx34=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>\n\t<20200306160002.30549-32-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Fri, 6 Mar 2020 16:25:01 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200306160002.30549-32-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v2 31/32] test: controls:\n\tcontrol_value: Expand test to cover array controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 06 Mar 2020 16:25:06 -0000"}},{"id":3963,"web_url":"https://patchwork.libcamera.org/comment/3963/","msgid":"<20200306163327.GR4878@pendragon.ideasonboard.com>","date":"2020-03-06T16:33:27","subject":"Re: [libcamera-devel] [PATCH v2 31/32] test: controls:\n\tcontrol_value: Expand test to cover array controls","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Fri, Mar 06, 2020 at 04:25:01PM +0000, Kieran Bingham wrote:\n> On 06/03/2020 16:00, Laurent Pinchart wrote:\n> > Add tests to ControlValueTest to cover array controls of all supported\n> > types.\n> > \n> > Signed-off-by: Laurent Pinchart \n> \n> Reviewed-by: Kieran Bingham \n> \n> One discussion item below though:\n> \n> > ---\n> > Changes since v1:\n> > \n> > - Renamed int8s to bytes\n> > ---\n> > test/controls/control_value.cpp | 101 ++++++++++++++++++++++++++++++++\n> > 1 file changed, 101 insertions(+)\n> > \n> > diff --git a/test/controls/control_value.cpp b/test/controls/control_value.cpp\n> > index 37f415302ff6..fd28bfe4604a 100644\n> > --- a/test/controls/control_value.cpp\n> > +++ b/test/controls/control_value.cpp\n> > @@ -5,6 +5,7 @@\n> > * control_value.cpp - ControlValue tests\n> > */\n> > \n> > +#include \n> > #include \n> > \n> > #include \n> > @@ -48,6 +49,26 @@ protected:\n> > \t\t\treturn TestFail;\n> > \t\t}\n> > \n> > +\t\tstd::array bools{ true, false };\n> > +\t\tvalue.set(Span(bools));\n> > +\t\tif (value.isNone() || !value.isArray() ||\n> > +\t\t value.type() != ControlTypeBool) {\n> > +\t\t\tcerr << \"Control type mismatch after setting to bool array\" << endl;\n> > +\t\t\treturn TestFail;\n> > +\t\t}\n> > +\n> > +\t\tSpan boolsResult = value.get>();\n> > +\t\tif (bools.size() != boolsResult.size() ||\n> > +\t\t !std::equal(bools.begin(), bools.end(), boolsResult.begin())) {\n> > +\t\t\tcerr << \"Control value mismatch after setting to bool\" << endl;\n> > +\t\t\treturn TestFail;\n> > +\t\t}\n> > +\n> > +\t\tif (value.toString() != \"[ true, false ]\") {\n> > +\t\t\tcerr << \"Control string mismatch after setting to bool array\" << endl;\n> > +\t\t\treturn TestFail;\n> > +\t\t}\n> > +\n> > \t\t/*\n> > \t\t * Integer8 type.\n> > \t\t */\n> > @@ -68,6 +89,26 @@ protected:\n> > \t\t\treturn TestFail;\n> > \t\t}\n> > \n> > +\t\tstd::array bytes{ 3, 14, 15, 9 };\n> > +\t\tvalue.set(Span(bytes));\n> > +\t\tif (value.isNone() || !value.isArray() ||\n> > +\t\t value.type() != ControlTypeByte) {\n> > +\t\t\tcerr << \"Control type mismatch after setting to uint8_t array\" << endl;\n> > +\t\t\treturn TestFail;\n> > +\t\t}\n> > +\n> > +\t\tSpan int8sResult = value.get>();\n> > +\t\tif (bytes.size() != int8sResult.size() ||\n> > +\t\t !std::equal(bytes.begin(), bytes.end(), int8sResult.begin())) {\n> > +\t\t\tcerr << \"Control value mismatch after setting to uint8_t array\" << endl;\n> > +\t\t\treturn TestFail;\n> > +\t\t}\n> > +\n> > +\t\tif (value.toString() != \"[ 3, 14, 15, 9 ]\") {\n> > +\t\t\tcerr << \"Control string mismatch after setting to uint8_t array\" << endl;\n> > +\t\t\treturn TestFail;\n> > +\t\t}\n> > +\n> > \t\t/*\n> > \t\t * Integer32 type.\n> > \t\t */\n> > @@ -88,6 +129,26 @@ protected:\n> > \t\t\treturn TestFail;\n> > \t\t}\n> > \n> > +\t\tstd::array int32s{ 3, 14, 15, 9 };\n> > +\t\tvalue.set(Span(int32s));\n> > +\t\tif (value.isNone() || !value.isArray() ||\n> > +\t\t value.type() != ControlTypeInteger32) {\n> > +\t\t\tcerr << \"Control type mismatch after setting to int32_t array\" << endl;\n> > +\t\t\treturn TestFail;\n> > +\t\t}\n> > +\n> > +\t\tSpan int32sResult = value.get>();\n> > +\t\tif (int32s.size() != int32sResult.size() ||\n> > +\t\t !std::equal(int32s.begin(), int32s.end(), int32sResult.begin())) {\n> > +\t\t\tcerr << \"Control value mismatch after setting to int32_t array\" << endl;\n> > +\t\t\treturn TestFail;\n> > +\t\t}\n> > +\n> > +\t\tif (value.toString() != \"[ 3, 14, 15, 9 ]\") {\n> > +\t\t\tcerr << \"Control string mismatch after setting to int32_t array\" << endl;\n> > +\t\t\treturn TestFail;\n> > +\t\t}\n> > +\n> > \t\t/*\n> > \t\t * Integer64 type.\n> > \t\t */\n> > @@ -108,6 +169,26 @@ protected:\n> > \t\t\treturn TestFail;\n> > \t\t}\n> > \n> > +\t\tstd::array int64s{ 3, 14, 15, 9 };\n> > +\t\tvalue.set(Span(int64s));\n> > +\t\tif (value.isNone() || !value.isArray() ||\n> > +\t\t value.type() != ControlTypeInteger64) {\n> > +\t\t\tcerr << \"Control type mismatch after setting to int64_t array\" << endl;\n> > +\t\t\treturn TestFail;\n> > +\t\t}\n> > +\n> > +\t\tSpan int64sResult = value.get>();\n> > +\t\tif (int64s.size() != int64sResult.size() ||\n> > +\t\t !std::equal(int64s.begin(), int64s.end(), int64sResult.begin())) {\n> > +\t\t\tcerr << \"Control value mismatch after setting to int64_t array\" << endl;\n> > +\t\t\treturn TestFail;\n> > +\t\t}\n> > +\n> > +\t\tif (value.toString() != \"[ 3, 14, 15, 9 ]\") {\n> > +\t\t\tcerr << \"Control string mismatch after setting to int64_t array\" << endl;\n> > +\t\t\treturn TestFail;\n> > +\t\t}\n> > +\n> > \t\t/*\n> > \t\t * Float type.\n> > \t\t */\n> > @@ -128,6 +209,26 @@ protected:\n> > \t\t\treturn TestFail;\n> > \t\t}\n> > \n> > +\t\tstd::array floats{ 3.141593, 2.718282, 299792458.0 };\n> \n> Storing three floats...\n> \n> > +\t\tvalue.set(Span(floats));\n> > +\t\tif (value.isNone() || !value.isArray() ||\n> > +\t\t value.type() != ControlTypeFloat) {\n> > +\t\t\tcerr << \"Control type mismatch after setting to float array\" << endl;\n> > +\t\t\treturn TestFail;\n> > +\t\t}\n> > +\n> > +\t\tSpan floatsResult = value.get>();\n> > +\t\tif (floats.size() != floatsResult.size() ||\n> > +\t\t !std::equal(floats.begin(), floats.end(), floatsResult.begin())) {\n> > +\t\t\tcerr << \"Control value mismatch after setting to float array\" << endl;\n> > +\t\t\treturn TestFail;\n> > +\t\t}\n> > +\n> > +\t\tif (value.toString() != \"[ 3.141593, 2.718282, 299792448.000000 ]\") {\n> \n> So we stored three floats including: 299792458.0 ...\n> But validated that against : 299792448.000000\n> \n> I presume that this will be due to floating point precision, but the\n> fact we store one value and check 'another' is a bit ugly, and either\n> warrants a comment to make it explicit (and not 'hidden') or just use a\n> value which will not lose any precision ?\n\nI'll add a comment.\n\n> But with that resolved how you wish, I think this is the last tag?\n> \n> Reviewed-by: Kieran Bingham \n> \n> > +\t\t\tcerr << \"Control string mismatch after setting to float array\" << endl;\n> > +\t\t\treturn TestFail;\n> > +\t\t}\n> > +\n> > \t\treturn TestPass;\n> > \t}\n> > };","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E3FD860424\n\tfor ;\n\tFri, 6 Mar 2020 17:33:30 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 607EA24B;\n\tFri, 6 Mar 2020 17:33:30 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583512410;\n\tbh=2eGuwtCye9qbBp2qvdRc4oKtLXRE/b+WM8DVcLEGdko=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HJqoKB2bTkTMecsfOQLtfk2JxcQyOXObZLfkkBX+fN2s5bTOJd/HpZmtfXCzgDoMI\n\tI4aZu39NuIKCgOnrYM8OU0CuIrqvRKXM9k9VQa3bs5YOFL6LEK8F1jlATqP1Kp3yX1\n\tnNM1Vg+Z2lzDVf3Gt/mpXiYZxJ7f2Mga0vj4rFco=","Date":"Fri, 6 Mar 2020 18:33:27 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200306163327.GR4878@pendragon.ideasonboard.com>","References":"<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>\n\t<20200306160002.30549-32-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 31/32] test: controls:\n\tcontrol_value: Expand test to cover array controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 06 Mar 2020 16:33:31 -0000"}}]