{"id":2995,"url":"https://patchwork.libcamera.org/api/patches/2995/?format=json","web_url":"https://patchwork.libcamera.org/patch/2995/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200306160002.30549-24-laurent.pinchart@ideasonboard.com>","date":"2020-03-06T15:59:53","name":"[libcamera-devel,v2,23/32] libcamera: byte_stream_buffer: Fix documentation of read() and write()","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"3caaac17f6004bfc7715a73c10d176b6286afb9d","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2995/mbox/","series":[{"id":703,"url":"https://patchwork.libcamera.org/api/series/703/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=703","date":"2020-03-06T15:59:30","name":"libcamera: Add support for array controls","version":2,"mbox":"https://patchwork.libcamera.org/series/703/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2995/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2995/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B520E628B7\n\tfor ;\n\tFri, 6 Mar 2020 17:00:24 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 449CE24B;\n\tFri, 6 Mar 2020 17:00:24 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583510424;\n\tbh=ZTP+9rVrH5qUMHcVTdc9d7h/GTi8MPowVEmbja9/4vI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=u7KWdTijXIMY0t8XHiHjNSj7j69MQqOJhxeoo2HCqfma4Ru5q2bKpY8ZbIDCf7N9q\n\tqNgbqx+79BQyRDc4matxj8Jxy4sRVapndJyBDPOkY0291/o0y0eRIARNsIpB9i0qA0\n\tvA4NzfNRHXRo/M3jiTq1C1+FMrwJldgEiBY2J19I=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 6 Mar 2020 17:59:53 +0200","Message-Id":"<20200306160002.30549-24-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>","References":"<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 23/32] libcamera: byte_stream_buffer:\n\tFix documentation of read() and write()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 06 Mar 2020 16:00:25 -0000"},"content":"From: Jacopo Mondi \n\nThe documentation of the read() and write() functions refer to non\nexistent 'size' and 'data' parameters in their brief. Fix them.\n\nSigned-off-by: Jacopo Mondi \nSigned-off-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\n src/libcamera/byte_stream_buffer.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp\nindex 23d624dd0a06..cd1d8a36d464 100644\n--- a/src/libcamera/byte_stream_buffer.cpp\n+++ b/src/libcamera/byte_stream_buffer.cpp\n@@ -225,7 +225,7 @@ int ByteStreamBuffer::skip(size_t size)\n \n /**\n * \\fn template int ByteStreamBuffer::read(T *t)\n- * \\brief Read \\a size \\a data from the managed memory buffer\n+ * \\brief Read data from the managed memory buffer into \\a t\n * \\param[out] t Pointer to the memory containing the read data\n * \\return 0 on success, a negative error code otherwise\n * \\retval -EACCES attempting to read from a write buffer\n@@ -234,7 +234,7 @@ int ByteStreamBuffer::skip(size_t size)\n \n /**\n * \\fn template int ByteStreamBuffer::write(const T *t)\n- * \\brief Write \\a data of \\a size to the managed memory buffer\n+ * \\brief Write \\a t to the managed memory buffer\n * \\param[in] t The data to write to memory\n * \\return 0 on success, a negative error code otherwise\n * \\retval -EACCES attempting to write to a read buffer\n","prefixes":["libcamera-devel","v2","23/32"]}