{"id":2984,"url":"https://patchwork.libcamera.org/api/patches/2984/?format=json","web_url":"https://patchwork.libcamera.org/patch/2984/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200306160002.30549-14-laurent.pinchart@ideasonboard.com>","date":"2020-03-06T15:59:43","name":"[libcamera-devel,v2,13/32] libcamera: controls: Move ControlValue constructor to controls.h","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"1eac15c20b1e30da0f915aa0c505537e9d1815f3","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2984/mbox/","series":[{"id":703,"url":"https://patchwork.libcamera.org/api/series/703/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=703","date":"2020-03-06T15:59:30","name":"libcamera: Add support for array controls","version":2,"mbox":"https://patchwork.libcamera.org/series/703/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2984/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2984/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF146627C3\n\tfor ;\n\tFri, 6 Mar 2020 17:00:20 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 77573312\n\tfor ;\n\tFri, 6 Mar 2020 17:00:20 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583510420;\n\tbh=DsTpPs4eXqU2lxxJeXEvAe1oDTBrGAdfoK9opzfPu6k=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=tfrbjH3tOa07d19gfu+mTXesZ2DDw14MMNH5mqc3NwTSJLvmzcoJXj7raCD8RM9xa\n\tDh0bqKQ6yHAQFbIE5i2s+6lADSxZvkrDszIK9AbyoAfnKwe4FqS5vZ4C/wzgXfyjwa\n\t5ZX8UpWB0i1+8cXGa6jzjwUPIMKchVUQ7xSSGDaU=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 6 Mar 2020 17:59:43 +0200","Message-Id":"<20200306160002.30549-14-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>","References":"<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 13/32] libcamera: controls: Move\n\tControlValue constructor to controls.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 06 Mar 2020 16:00:21 -0000"},"content":"To avoid defining all specializations of the ControlValue constructor\nmanually, move the definition of those functions to controls.h and turn\nthem into a single template function. The default constructor is still\nkept in controls.cpp.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\n include/libcamera/controls.h | 10 +++++++---\n src/libcamera/controls.cpp | 27 +++------------------------\n 2 files changed, 10 insertions(+), 27 deletions(-)","diff":"diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex 39e240438861..dfe69916cd64 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -55,9 +55,13 @@ class ControlValue\n {\n public:\n \tControlValue();\n-\tControlValue(bool value);\n-\tControlValue(int32_t value);\n-\tControlValue(int64_t value);\n+\n+\ttemplate\n+\tControlValue(T value)\n+\t\t: type_(details::control_type>::value)\n+\t{\n+\t\t*reinterpret_cast(&bool_) = value;\n+\t}\n \n \tControlType type() const { return type_; }\n \tbool isNone() const { return type_ == ControlTypeNone; }\ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex f3d79785e6a8..5cc8ce2199d0 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -74,31 +74,10 @@ ControlValue::ControlValue()\n }\n \n /**\n- * \\brief Construct a Boolean ControlValue\n- * \\param[in] value Boolean value to store\n+ * \\fn template T ControlValue::ControlValue(T value)\n+ * \\brief Construct a ControlValue of type T\n+ * \\param[in] value Initial value\n */\n-ControlValue::ControlValue(bool value)\n-\t: type_(ControlTypeBool), bool_(value)\n-{\n-}\n-\n-/**\n- * \\brief Construct an integer ControlValue\n- * \\param[in] value Integer value to store\n- */\n-ControlValue::ControlValue(int32_t value)\n-\t: type_(ControlTypeInteger32), integer32_(value)\n-{\n-}\n-\n-/**\n- * \\brief Construct a 64 bit integer ControlValue\n- * \\param[in] value Integer value to store\n- */\n-ControlValue::ControlValue(int64_t value)\n-\t: type_(ControlTypeInteger64), integer64_(value)\n-{\n-}\n \n /**\n * \\fn ControlValue::type()\n","prefixes":["libcamera-devel","v2","13/32"]}