{"id":2981,"url":"https://patchwork.libcamera.org/api/patches/2981/?format=json","web_url":"https://patchwork.libcamera.org/patch/2981/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200306160002.30549-10-laurent.pinchart@ideasonboard.com>","date":"2020-03-06T15:59:39","name":"[libcamera-devel,v2,09/32] libcamera: controls: Decouple control and value type in ControlList::set()","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"d56685bff3cff57f6730cde32825477c05f0ba37","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2981/mbox/","series":[{"id":703,"url":"https://patchwork.libcamera.org/api/series/703/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=703","date":"2020-03-06T15:59:30","name":"libcamera: Add support for array controls","version":2,"mbox":"https://patchwork.libcamera.org/series/703/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2981/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2981/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F06C60424\n\tfor ;\n\tFri, 6 Mar 2020 17:00:18 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AFB0624B\n\tfor ;\n\tFri, 6 Mar 2020 17:00:17 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583510418;\n\tbh=FTYoyyw6XbuflBPuc7JX9YO3bSbZWDYwK1KMbQv0tCc=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=YAWw448UfU14MhttH6RyIe3YsPy5EjuU4hpc0FEl0i8nw3xRTo0Jueu7znNcH1k3r\n\tnhSkEMEJDk1XXER3GAq4fKC2a/AtjRWWn1edphKIoFnnzHfuapZeZNwNzsmIn5BDW8\n\t57dWWqA876Okk0QOQQ0IK/Sg8lh3KGsQcGLWbaU4=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 6 Mar 2020 17:59:39 +0200","Message-Id":"<20200306160002.30549-10-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>","References":"<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 09/32] libcamera: controls: Decouple\n\tcontrol and value type in ControlList::set()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 06 Mar 2020 16:00:18 -0000"},"content":"The ControlList::set() method takes a reference to a Control, and\nrequires the value to be a reference to T. This prevents the set()\nmethod from being used with value types that are convertible to T, and\nin particular with std::array or std::vector value types when the\nControl type is a Span<> to support array controls.\n\nFix this by decoupling the control type and value type in the template\nparameters. The compiler will still catch invalid conversions, including\ncases where the constructor of type T from the value type is explicit.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\n include/libcamera/controls.h | 4 ++--\n src/libcamera/controls.cpp | 2 +-\n 2 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex 9f8a9031bd74..9d93064c11b2 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -223,8 +223,8 @@ public:\n \t\treturn val->get();\n \t}\n \n-\ttemplate\n-\tvoid set(const Control &ctrl, const T &value)\n+\ttemplate\n+\tvoid set(const Control &ctrl, const V &value)\n \t{\n \t\tControlValue *val = find(ctrl.id());\n \t\tif (!val)\ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex f632d60adc8b..a136ebd2653b 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -735,7 +735,7 @@ bool ControlList::contains(unsigned int id) const\n */\n \n /**\n- * \\fn template void ControlList::set(const Control &ctrl, const T &value)\n+ * \\fn template void ControlList::set(const Control &ctrl, const V &value)\n * \\brief Set the control \\a ctrl value to \\a value\n * \\param[in] ctrl The control\n * \\param[in] value The control value\n","prefixes":["libcamera-devel","v2","09/32"]}