{"id":2980,"url":"https://patchwork.libcamera.org/api/patches/2980/?format=json","web_url":"https://patchwork.libcamera.org/patch/2980/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200306160002.30549-9-laurent.pinchart@ideasonboard.com>","date":"2020-03-06T15:59:38","name":"[libcamera-devel,v2,08/32] libcamera: controls: Don't convert 32-bit and 64-bit implicitly","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"7a7248d98534609474f470367ce7e0436d26f2b9","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2980/mbox/","series":[{"id":703,"url":"https://patchwork.libcamera.org/api/series/703/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=703","date":"2020-03-06T15:59:30","name":"libcamera: Add support for array controls","version":2,"mbox":"https://patchwork.libcamera.org/series/703/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2980/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2980/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8564460424\n\tfor ;\n\tFri, 6 Mar 2020 17:00:17 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A972D1265\n\tfor ;\n\tFri, 6 Mar 2020 17:00:16 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583510417;\n\tbh=pPpRtPzwTtWPqbAc8jW+/g6UiGXbaLBzXNluwdBV0KA=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=n2QPOjJ/6XDaQT4dPXmgQEGP4Fvn6hf5S/gEkgMRkI/mvoRikuh7fH/S+7nHKfuqk\n\tz4t29aoPOnNHKVs3ASqFTswpxgvOjM1JSIDUR+HRrCV8NXM43vmPeHzI+LkjyciBBV\n\tMOXFA9mSOEn6GYrVfU82r5zylIdS99PPjElRIYaA=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 6 Mar 2020 17:59:38 +0200","Message-Id":"<20200306160002.30549-9-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>","References":"<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 08/32] libcamera: controls: Don't\n\tconvert 32-bit and 64-bit implicitly","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 06 Mar 2020 16:00:17 -0000"},"content":"The ControlValue::get() method verifies that the T type corresponds\nto the ControlValue type. It however accepts int32_t as a return type\nfor 64-bit integer controls, and int64_t as a return type for 32-bit\ninteger controls. There's no reason to do so anymore, make the type\ncheck stricter.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Jacopo Mondi \nReviewed-by: Kieran Bingham \n---\n src/libcamera/controls.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex 613e6d768c0f..f632d60adc8b 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -187,7 +187,7 @@ const bool &ControlValue::get() const\n template<>\n const int32_t &ControlValue::get() const\n {\n-\tASSERT(type_ == ControlTypeInteger32 || type_ == ControlTypeInteger64);\n+\tASSERT(type_ == ControlTypeInteger32);\n \n \treturn integer32_;\n }\n@@ -195,7 +195,7 @@ const int32_t &ControlValue::get() const\n template<>\n const int64_t &ControlValue::get() const\n {\n-\tASSERT(type_ == ControlTypeInteger32 || type_ == ControlTypeInteger64);\n+\tASSERT(type_ == ControlTypeInteger64);\n \n \treturn integer64_;\n }\n","prefixes":["libcamera-devel","v2","08/32"]}