{"id":2978,"url":"https://patchwork.libcamera.org/api/patches/2978/?format=json","web_url":"https://patchwork.libcamera.org/patch/2978/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200306160002.30549-7-laurent.pinchart@ideasonboard.com>","date":"2020-03-06T15:59:36","name":"[libcamera-devel,v2,06/32] libcamera: ipa: Test control structure size with static_assert","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"13ab1b80df343f9a2b5d0c69a98c4402eb490bfc","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2978/mbox/","series":[{"id":703,"url":"https://patchwork.libcamera.org/api/series/703/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=703","date":"2020-03-06T15:59:30","name":"libcamera: Add support for array controls","version":2,"mbox":"https://patchwork.libcamera.org/series/703/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2978/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2978/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3DA80628A3\n\tfor ;\n\tFri, 6 Mar 2020 17:00:15 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 69B0E24B\n\tfor ;\n\tFri, 6 Mar 2020 17:00:14 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583510415;\n\tbh=6z9O1P228TqINXmjb5t/D9+EjZTQnJiyk7M5/TTfogk=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=ZiQrlJomtDyAY2T5Jkgc/FoTVi3aPJxrrCCdvcy2b/3O1/Kh5cd+adZV1TINy+Ax4\n\thXQreUMlgvOdNoYDQcbShREoMhgrNYL6I9HtUdwaywxQCpfZezgbvx2Bkn0D9NzBEu\n\tkRm2Po4h22kuD5l4xW+YdTR4cOJb6/YWNCabP404=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 6 Mar 2020 17:59:36 +0200","Message-Id":"<20200306160002.30549-7-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>","References":"<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 06/32] libcamera: ipa: Test control\n\tstructure size with static_assert","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 06 Mar 2020 16:00:16 -0000"},"content":"The control-related structures ipa_controls_header,\nipa_control_value_entry and ipa_control_range_entry define the IPA\nprotocol and are thus part of the ABI. To avoid breaking it\ninadvertently, use static_assert() to check the size of the structures.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\nChanges since v1:\n\n- Improve wording of static_assert() message\n---\n src/libcamera/ipa_controls.cpp | 9 +++++++++\n 1 file changed, 9 insertions(+)","diff":"diff --git a/src/libcamera/ipa_controls.cpp b/src/libcamera/ipa_controls.cpp\nindex dd3ff9a0d467..fc5ccd4210b2 100644\n--- a/src/libcamera/ipa_controls.cpp\n+++ b/src/libcamera/ipa_controls.cpp\n@@ -153,6 +153,9 @@\n * Reserved for future extensions\n */\n \n+static_assert(sizeof(ipa_controls_header) == 32,\n+\t \"Invalid ABI size change for struct ipa_control_header\");\n+\n /**\n * \\struct ipa_control_value_entry\n * \\brief Description of a serialized ControlValue entry\n@@ -167,6 +170,9 @@\n * value data (shall be a multiple of 8 bytes).\n */\n \n+static_assert(sizeof(ipa_control_value_entry) == 16,\n+\t \"Invalid ABI size change for struct ipa_control_value_entry\");\n+\n /**\n * \\struct ipa_control_range_entry\n * \\brief Description of a serialized ControlRange entry\n@@ -180,3 +186,6 @@\n * \\var ipa_control_range_entry::padding\n * Padding bytes (shall be set to 0)\n */\n+\n+static_assert(sizeof(ipa_control_range_entry) == 16,\n+\t \"Invalid ABI size change for struct ipa_control_range_entry\");\n","prefixes":["libcamera-devel","v2","06/32"]}