{"id":2977,"url":"https://patchwork.libcamera.org/api/patches/2977/?format=json","web_url":"https://patchwork.libcamera.org/patch/2977/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200306160002.30549-6-laurent.pinchart@ideasonboard.com>","date":"2020-03-06T15:59:35","name":"[libcamera-devel,v2,05/32] libcamera: ipa: Make <ipa/ipa_controls.h> self-contained","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"3e696a2449c4e5256a42bf763960b24dd8d9d045","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2977/mbox/","series":[{"id":703,"url":"https://patchwork.libcamera.org/api/series/703/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=703","date":"2020-03-06T15:59:30","name":"libcamera: Add support for array controls","version":2,"mbox":"https://patchwork.libcamera.org/series/703/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2977/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2977/checks/","tags":{},"headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5763C6285C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  6 Mar 2020 17:00:14 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 795C324B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  6 Mar 2020 17:00:13 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583510414;\n\tbh=cGJtiCPY/NxjiYSDGQN7Hj7nZeMJhi0ZJ8DWpEHJ7FQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=fHjVJOzkGqvnkxkZ1yy2xX+LBTfCTF1EjjVDOtVwDoa1n+GjL8NFjQHlUuW5DMP65\n\t9i7nSJlpVWkh0S8l9kPNoQxRkBsLwbeZuueJSO73pbduTs4jFXLWyS6HUv2l0OQpgu\n\tyvwYdlM7kWTHXGz/NFTy8ydbfjtxIIyi/SSGj+VY=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Fri,  6 Mar 2020 17:59:35 +0200","Message-Id":"<20200306160002.30549-6-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>","References":"<20200306160002.30549-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 05/32] libcamera: ipa: Make\n\t<ipa/ipa_controls.h> self-contained","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 06 Mar 2020 16:00:14 -0000"},"content":"The <ipa/ipa_controls.h> header makes use of uint*_t types, but doesn't\ninclude stdint.h. Fix it, and include ipa_controls.h in ipa_controls.cpp\nto test compilation of the header on its own.\n\nWhile at it, fix the comment as the top of ipa_controls.cpp to refer to\nthe correct file name.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/ipa/ipa_controls.h     | 2 ++\n src/libcamera/ipa_controls.cpp | 4 +++-\n 2 files changed, 5 insertions(+), 1 deletion(-)","diff":"diff --git a/include/ipa/ipa_controls.h b/include/ipa/ipa_controls.h\nindex 426d99689de2..6371e34575f2 100644\n--- a/include/ipa/ipa_controls.h\n+++ b/include/ipa/ipa_controls.h\n@@ -7,6 +7,8 @@\n #ifndef __LIBCAMERA_IPA_CONTROLS_H__\n #define __LIBCAMERA_IPA_CONTROLS_H__\n \n+#include <stdint.h>\n+\n #ifdef __cplusplus\n extern \"C\" {\n #endif\ndiff --git a/src/libcamera/ipa_controls.cpp b/src/libcamera/ipa_controls.cpp\nindex 6ea71bc6dc46..dd3ff9a0d467 100644\n--- a/src/libcamera/ipa_controls.cpp\n+++ b/src/libcamera/ipa_controls.cpp\n@@ -2,9 +2,11 @@\n /*\n  * Copyright (C) 2019, Google Inc.\n  *\n- * ipa_controls.h - IPA control handling\n+ * ipa_controls.cpp - IPA control handling\n  */\n \n+#include <ipa/ipa_controls.h>\n+\n /**\n  * \\file ipa_controls.h\n  * \\brief Type definitions for serialized controls\n","prefixes":["libcamera-devel","v2","05/32"]}