[{"id":466,"web_url":"https://patchwork.libcamera.org/comment/466/","msgid":"<20190121210041.GJ4439@pendragon.ideasonboard.com>","date":"2019-01-21T21:00:41","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: media_device: expose\n\tmedia graph model name","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Mon, Jan 21, 2019 at 04:30:04PM +0100, Niklas Söderlund wrote:\n> Pipeline handlers such as the upcoming ucvideo handler needs the model\n\ns/needs/need/\n\n> name to properly name the Camera object it creates. Store the model name\n\ns/object it creates/objects they create/\n\n> when querying the media device info and handle it in a similar fashion\n> as the driver name which is already retrieved.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/include/media_device.h | 2 ++\n> src/libcamera/media_device.cpp | 7 +++++++\n> 2 files changed, 9 insertions(+)\n> \n> diff --git a/src/libcamera/include/media_device.h b/src/libcamera/include/media_device.h\n> index a8dec0d3347bd5fc..d96b8ec718427011 100644\n> --- a/src/libcamera/include/media_device.h\n> +++ b/src/libcamera/include/media_device.h\n> @@ -36,6 +36,7 @@ public:\n> \n> \tconst std::string driver() const { return driver_; }\n> \tconst std::string devnode() const { return devnode_; }\n> +\tconst std::string model() const { return model_; }\n> \n> \tconst std::vector &entities() const { return entities_; }\n> \tMediaEntity *getEntityByName(const std::string &name) const;\n> @@ -50,6 +51,7 @@ public:\n> private:\n> \tstd::string driver_;\n> \tstd::string devnode_;\n> +\tstd::string model_;\n> \tint fd_;\n> \tbool valid_;\n> \tbool acquired_;\n> diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\n> index a346296bc38e8f3d..b315e4f383b3bbb1 100644\n> --- a/src/libcamera/media_device.cpp\n> +++ b/src/libcamera/media_device.cpp\n> @@ -162,6 +162,7 @@ int MediaDevice::open()\n> \t}\n> \n> \tdriver_ = info.driver;\n> +\tmodel_ = info.model;\n> \n> \treturn 0;\n> }\n> @@ -285,6 +286,12 @@ int MediaDevice::populate()\n> * \\return The MediaDevice devnode path\n> */\n> \n> +/**\n> + * \\fn MediaDevice::model()\n> + * \\brief Retrieve the media device model name\n> + * \\return The MediaDevice model name\n> + */\n> +\n> /**\n> * \\fn MediaDevice::entities()\n> * \\brief Retrieve the list of entities in the media graph","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D94660B1D\n\tfor ;\n\tMon, 21 Jan 2019 22:00:42 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 09BF1598;\n\tMon, 21 Jan 2019 22:00:41 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548104442;\n\tbh=Fah/RwOaC3ks4xQIg3Ugh72AqZb6soV6eDTza/Okar4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RlSNFFY+BCJMmZOiGXFab+9/zkvWrhU2IkGwwDQvDX3fEvI74Ix0liQyHDk2LfxFE\n\tSzo/1MhvDu20ZsszZqWlVBekQm5abu8FkXuXQ9jMMqvu+Wz989nMsjU+lduGnVBhW6\n\td6yQv3Rpz8cek3ybrcUubX76uXtg4mGiGS6/6pCg=","Date":"Mon, 21 Jan 2019 23:00:41 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190121210041.GJ4439@pendragon.ideasonboard.com>","References":"<20190121153005.19110-1-niklas.soderlund@ragnatech.se>\n\t<20190121153005.19110-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190121153005.19110-2-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: media_device: expose\n\tmedia graph model name","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 21 Jan 2019 21:00:42 -0000"}}]