[{"id":451,"web_url":"https://patchwork.libcamera.org/comment/451/","msgid":"<2e67f356-3f69-be3a-8acc-690eb46d49d7@ideasonboard.com>","date":"2019-01-21T15:33:54","subject":"Re: [libcamera-devel] [PATCH] libcamera: media_device: fix typo in\n\tdocumentation for MediaDevice::devnode()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 21/01/2019 15:12, Niklas Söderlund wrote:\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/media_device.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\n> index 0ee55060aa9b5d23..a346296bc38e8f3d 100644\n> --- a/src/libcamera/media_device.cpp\n> +++ b/src/libcamera/media_device.cpp\n> @@ -281,7 +281,7 @@ int MediaDevice::populate()\n> \n> /**\n> * \\fn MediaDevice::devnode()\n> - * \\brief Retrieve the media device device node path\n> + * \\brief Retrieve the media device devnode path\n\nI would have just deleted one of the duplicates, and put\n \"Retrieve the media device node path\"\n\ndevice devnode feels a bit repetitive, because the 'dev' is short for\ndevice ;)\n\n--\nRegards\n\nKieran\n\n\n\n> * \\return The MediaDevice devnode path\n> */\n> \n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EE3BB60C78\n\tfor ;\n\tMon, 21 Jan 2019 16:33:57 +0100 (CET)","from [192.168.0.21]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7D70253E;\n\tMon, 21 Jan 2019 16:33:57 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548084837;\n\tbh=soolZuWxJG+6qY5GYaP60yq4U8aaby9S/pxXzZT5JAU=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=k5jGRtXekT7Edi7/FLi4UiE49k0vnagwZOdaLSEWwqrxVtAoUxxT7UTEibZPSlTUR\n\t4L3cU/x/VaXqj9fxpAH36PV9zAyk5vHkLYm0M+efqsSggukrOzmD/5neiTyC3ZuiHY\n\tsQlMCPzNkOWUKzFke3WZj1CJm9gcLtFKufH9/kBU=","Reply-To":"kieran.bingham@ideasonboard.com","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20190121151229.16744-1-niklas.soderlund@ragnatech.se>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<2e67f356-3f69-be3a-8acc-690eb46d49d7@ideasonboard.com>","Date":"Mon, 21 Jan 2019 15:33:54 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.2.1","MIME-Version":"1.0","In-Reply-To":"<20190121151229.16744-1-niklas.soderlund@ragnatech.se>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: media_device: fix typo in\n\tdocumentation for MediaDevice::devnode()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 21 Jan 2019 15:33:58 -0000"}},{"id":452,"web_url":"https://patchwork.libcamera.org/comment/452/","msgid":"<20190121153805.GF6484@bigcity.dyn.berto.se>","date":"2019-01-21T15:38:05","subject":"Re: [libcamera-devel] [PATCH] libcamera: media_device: fix typo in\n\tdocumentation for MediaDevice::devnode()","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nOn 2019-01-21 15:33:54 +0000, Kieran Bingham wrote:\n> Hi Niklas,\n> \n> On 21/01/2019 15:12, Niklas Söderlund wrote:\n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > src/libcamera/media_device.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\n> > index 0ee55060aa9b5d23..a346296bc38e8f3d 100644\n> > --- a/src/libcamera/media_device.cpp\n> > +++ b/src/libcamera/media_device.cpp\n> > @@ -281,7 +281,7 @@ int MediaDevice::populate()\n> > \n> > /**\n> > * \\fn MediaDevice::devnode()\n> > - * \\brief Retrieve the media device device node path\n> > + * \\brief Retrieve the media device devnode path\n> \n> I would have just deleted one of the duplicates, and put\n> \"Retrieve the media device node path\"\n> \n> device devnode feels a bit repetitive, because the 'dev' is short for\n> device ;)\n\nThat's what I did at first. Then I read the \\return description which \nuses devnode. I'm fine either way, let me know what you think.\n\n> \n> --\n> Regards\n> \n> Kieran\n> \n> \n> \n> > * \\return The MediaDevice devnode path\n> > */\n> > \n> > \n> \n> -- \n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 58E4B60C78\n\tfor ;\n\tMon, 21 Jan 2019 16:38:07 +0100 (CET)","by mail-lj1-x243.google.com with SMTP id k15-v6so17883738ljc.8\n\tfor ;\n\tMon, 21 Jan 2019 07:38:07 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tm21sm2345331lfl.97.2019.01.21.07.38.05\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 21 Jan 2019 07:38:05 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=hs+2QnRbcYzCTv4q9jwH6SGvCkIo5XYy5qHQFY0NeN4=;\n\tb=NmzP+xg8iWcDPL0Ko/xwxovzxvPzGL8op2IdSx9hIg/iaLCRjScNpXZqx9MnJMlxHX\n\tbcaMiMLGhJaYREauY+GHjojj/DIyAGWXmVZlfsez6qJslRnNUoxXyUPsSU603qY3p0Si\n\tam9GyY/f8qzOuEbxaTbtTn+b0xXfZKclodntNy1OmP/5LMTyWitkul0xvYnXVujD1dMY\n\t/Z1Uhq0er7pC55a2Aw6LMUACtleZokAFOAnPXUNmvH848VXUyDJyZOnZ1EY3FQoGxOfn\n\tnIZzgt34hJr8GjJtzmwtfBKGh/LwM3GxI/qHeIIoouoUcg8ABrVolL0gCA7lMv34z6ar\n\tWTJA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=hs+2QnRbcYzCTv4q9jwH6SGvCkIo5XYy5qHQFY0NeN4=;\n\tb=HzuOE3oifeFusqGOMzR7ycjkkjQ7I8m2ckUpv/sKsYDzBxvNfPhInWW3ArPWmGwKRJ\n\tQJ7NRvdyWS2s1+L51zBeI4ecN7OGbthslkai1FlDpz/K01b2KaPUVpgLAkxQ5x81Gg32\n\tk3xsmze15ECKwghyJsi/jjgkCwd2dRdvhP4vxMrMQollyLFyIqVPrTcKhN20cVT+Ae20\n\tr76uc/wuqO60gbys7qJkNkpUEMe56qg8yrfd/0PbEqqoA2SW2pw3V/RAvklgvw5jHyja\n\tV2fekkuMeoK2u/exvW7i1Zgpa09xCjBMsN4phdTqkxetAl/FrJMw35WiuNs7B4MvS1hn\n\tacHw==","X-Gm-Message-State":"AJcUukdImXOwigSICxoV3z4s9f6BK8eHM7rlt2aaYmSKXdG3R7k29CZe\n\t1nlzVLAaGePL+NRDQ63AjrJO9Q==","X-Google-Smtp-Source":"ALg8bN71mE17t2Gsc06VyW7jSWBHLUSrA6O7DMLNdAxhsjupdC1hBv/s1VHnsNrU+gceiuv5Ntm6gg==","X-Received":"by 2002:a2e:29d7:: with SMTP id\n\tp84-v6mr18093626ljp.12.1548085086102; \n\tMon, 21 Jan 2019 07:38:06 -0800 (PST)","Date":"Mon, 21 Jan 2019 16:38:05 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190121153805.GF6484@bigcity.dyn.berto.se>","References":"<20190121151229.16744-1-niklas.soderlund@ragnatech.se>\n\t<2e67f356-3f69-be3a-8acc-690eb46d49d7@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<2e67f356-3f69-be3a-8acc-690eb46d49d7@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: media_device: fix typo in\n\tdocumentation for MediaDevice::devnode()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 21 Jan 2019 15:38:07 -0000"}},{"id":454,"web_url":"https://patchwork.libcamera.org/comment/454/","msgid":"<51622848-7bed-daf3-f2da-2b71e600ebb1@ideasonboard.com>","date":"2019-01-21T15:57:37","subject":"Re: [libcamera-devel] [PATCH] libcamera: media_device: fix typo in\n\tdocumentation for MediaDevice::devnode()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 21/01/2019 15:38, Niklas Söderlund wrote:\n> Hi Kieran,\n> \n> On 2019-01-21 15:33:54 +0000, Kieran Bingham wrote:\n>> Hi Niklas,\n>>\n>> On 21/01/2019 15:12, Niklas Söderlund wrote:\n>>> Signed-off-by: Niklas Söderlund \n>>> ---\n>>> src/libcamera/media_device.cpp | 2 +-\n>>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>>\n>>> diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\n>>> index 0ee55060aa9b5d23..a346296bc38e8f3d 100644\n>>> --- a/src/libcamera/media_device.cpp\n>>> +++ b/src/libcamera/media_device.cpp\n>>> @@ -281,7 +281,7 @@ int MediaDevice::populate()\n>>> \n>>> /**\n>>> * \\fn MediaDevice::devnode()\n>>> - * \\brief Retrieve the media device device node path\n>>> + * \\brief Retrieve the media device devnode path\n>>\n>> I would have just deleted one of the duplicates, and put\n>> \"Retrieve the media device node path\"\n>>\n>> device devnode feels a bit repetitive, because the 'dev' is short for\n>> device ;)\n> \n> That's what I did at first. Then I read the \\return description which \n> uses devnode. I'm fine either way, let me know what you think.\n\ngit blame points to Laurent on this line - so I'll defer to him if you\nwant a final say.\n\nMy feel would be that below is defining \"MediaDevice\" and \"devnode\" as\nthe two entities are named in the code. Here in the brief, I would use\nmore 'conversational' explanations.\n\n>>\n>>\n>>> * \\return The MediaDevice devnode path\n>>> */\n>>> \n>>>\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3952560C80\n\tfor ;\n\tMon, 21 Jan 2019 16:57:41 +0100 (CET)","from [192.168.0.21]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5D7DD53E;\n\tMon, 21 Jan 2019 16:57:40 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548086260;\n\tbh=y/x/yzSqQu7lKUNhiE0/pkQF5WJjv1FpaTnyIlesEA8=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=ciOFJ/ChPL8a6DlEE1CuU2Ivq/c0GDyukL9zPRI916jz7z/MfWJ5qPO/bvlitdVRT\n\tgVny/13L4+UsMqT9+jDjrAo7miT7bv1phHiFqJp+coqETVeXN7lT/oGoI2gk2B0WR1\n\tUjfxKSWAKc5vyLr9FZ7wg5wBmyyWJEAVNT4sKJCE=","Reply-To":"kieran.bingham@ideasonboard.com","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tLaurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20190121151229.16744-1-niklas.soderlund@ragnatech.se>\n\t<2e67f356-3f69-be3a-8acc-690eb46d49d7@ideasonboard.com>\n\t<20190121153805.GF6484@bigcity.dyn.berto.se>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<51622848-7bed-daf3-f2da-2b71e600ebb1@ideasonboard.com>","Date":"Mon, 21 Jan 2019 15:57:37 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.2.1","MIME-Version":"1.0","In-Reply-To":"<20190121153805.GF6484@bigcity.dyn.berto.se>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: media_device: fix typo in\n\tdocumentation for MediaDevice::devnode()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 21 Jan 2019 15:57:41 -0000"}},{"id":456,"web_url":"https://patchwork.libcamera.org/comment/456/","msgid":"<20190121165755.GH12780@pendragon.ideasonboard.com>","date":"2019-01-21T16:57:55","subject":"Re: [libcamera-devel] [PATCH] libcamera: media_device: fix typo in\n\tdocumentation for MediaDevice::devnode()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hello,\n\nOn Mon, Jan 21, 2019 at 03:57:37PM +0000, Kieran Bingham wrote:\n> On 21/01/2019 15:38, Niklas Söderlund wrote:\n> > On 2019-01-21 15:33:54 +0000, Kieran Bingham wrote:\n> >> On 21/01/2019 15:12, Niklas Söderlund wrote:\n> >>> Signed-off-by: Niklas Söderlund \n> >>> ---\n> >>> src/libcamera/media_device.cpp | 2 +-\n> >>> 1 file changed, 1 insertion(+), 1 deletion(-)\n> >>>\n> >>> diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\n> >>> index 0ee55060aa9b5d23..a346296bc38e8f3d 100644\n> >>> --- a/src/libcamera/media_device.cpp\n> >>> +++ b/src/libcamera/media_device.cpp\n> >>> @@ -281,7 +281,7 @@ int MediaDevice::populate()\n> >>> \n> >>> /**\n> >>> * \\fn MediaDevice::devnode()\n> >>> - * \\brief Retrieve the media device device node path\n> >>> + * \\brief Retrieve the media device devnode path\n> >>\n> >> I would have just deleted one of the duplicates, and put\n> >> \"Retrieve the media device node path\"\n> >>\n> >> device devnode feels a bit repetitive, because the 'dev' is short for\n> >> device ;)\n> > \n> > That's what I did at first. Then I read the \\return description which \n> > uses devnode. I'm fine either way, let me know what you think.\n> \n> git blame points to Laurent on this line - so I'll defer to him if you\n> want a final say.\n> \n> My feel would be that below is defining \"MediaDevice\" and \"devnode\" as\n> the two entities are named in the code. Here in the brief, I would use\n> more 'conversational' explanations.\n\nI have a slight preference for spelling terms fully, both in code and\ndocumentation, unless abbreviations are necessary. This means \"device\nnode\", \"deviceNode\", \"setDeviceNode\", ...\n\nIf the team prefers the abbreviated version, that should be \"devnode\"\nand \"setDevnode\" used consistently through the code and comments. The\nmost important point is consistency.\n\n> >>> * \\return The MediaDevice devnode path\n> >>> */","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B09C60C80\n\tfor ;\n\tMon, 21 Jan 2019 17:57:56 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9C92853E;\n\tMon, 21 Jan 2019 17:57:55 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548089875;\n\tbh=18dUb6rcbWHIQkAuaHEPSf8l7JA1qB0PneRIPqHIW5g=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HJFcid8bbCQxnGYEqky2ryR56qkZI4NGGS8vAxgbmZK7Ko9ag8I5qKsqa10sL/8Xc\n\tQaNVtQ5Qq4fxHNKxBeO8Zo2kj/o2CS1ujTpDVZC6zmMCFMFos28S4JuazZODzIx5od\n\tGt+hE4VIg2tjKTjTPP+D78sDRwz555Px3OCL4OEs=","Date":"Mon, 21 Jan 2019 18:57:55 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"Niklas =?utf-8?q?S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<20190121165755.GH12780@pendragon.ideasonboard.com>","References":"<20190121151229.16744-1-niklas.soderlund@ragnatech.se>\n\t<2e67f356-3f69-be3a-8acc-690eb46d49d7@ideasonboard.com>\n\t<20190121153805.GF6484@bigcity.dyn.berto.se>\n\t<51622848-7bed-daf3-f2da-2b71e600ebb1@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<51622848-7bed-daf3-f2da-2b71e600ebb1@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: media_device: fix typo in\n\tdocumentation for MediaDevice::devnode()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 21 Jan 2019 16:57:56 -0000"}}]