[{"id":3932,"web_url":"https://patchwork.libcamera.org/comment/3932/","msgid":"<20200304232737.GC28814@pendragon.ideasonboard.com>","date":"2020-03-04T23:27:37","subject":"Re: [libcamera-devel] [PATCH v3 3/7] libcamera: V4L2BufferCache:\n\tMark Entry::operator==() as const","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Thu, Mar 05, 2020 at 12:22:42AM +0100, Niklas Söderlund wrote:\n> The comparison operator does not change any state, mark it as const.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/include/v4l2_videodevice.h | 2 +-\n> src/libcamera/v4l2_videodevice.cpp | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/include/v4l2_videodevice.h b/src/libcamera/include/v4l2_videodevice.h\n> index fcf072641420dacf..359b366454e4e782 100644\n> --- a/src/libcamera/include/v4l2_videodevice.h\n> +++ b/src/libcamera/include/v4l2_videodevice.h\n> @@ -122,7 +122,7 @@ private:\n> \t\tEntry();\n> \t\tEntry(bool free, const FrameBuffer &buffer);\n> \n> -\t\tbool operator==(const FrameBuffer &buffer);\n> +\t\tbool operator==(const FrameBuffer &buffer) const;\n> \n> \t\tbool free;\n> \n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 99470ce11421c77c..d88cb0bd0771e545 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -256,7 +256,7 @@ V4L2BufferCache::Entry::Entry(bool free, const FrameBuffer &buffer)\n> \t\tplanes_.emplace_back(plane);\n> }\n> \n> -bool V4L2BufferCache::Entry::operator==(const FrameBuffer &buffer)\n> +bool V4L2BufferCache::Entry::operator==(const FrameBuffer &buffer) const\n> {\n> \tconst std::vector &planes = buffer.planes();\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B035262734\n\tfor ;\n\tThu, 5 Mar 2020 00:27:41 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C158133E;\n\tThu, 5 Mar 2020 00:27:40 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583364461;\n\tbh=5BrzoMjUgQS+eAeJ29nMmE9zlXQ5iRn0s+bG4LDM5+k=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=TREUeDUCzxsuF/ffiE9p+TZPBtpY8s+co4dOMU+qDXUjl8aFRl58Qu1GiyEx/07zy\n\twXOq1RwKJimPGYeY6FS0dzqVKDkd0LwYDqR7koDwwwwf6AsBX6QGUmSuNOf46DW4il\n\th1czxyZXKezoQKtFiVNZmDNpI5365V7jeV3cVh5w=","Date":"Thu, 5 Mar 2020 01:27:37 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200304232737.GC28814@pendragon.ideasonboard.com>","References":"<20200304232246.325384-1-niklas.soderlund@ragnatech.se>\n\t<20200304232246.325384-4-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200304232246.325384-4-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v3 3/7] libcamera: V4L2BufferCache:\n\tMark Entry::operator==() as const","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 04 Mar 2020 23:27:41 -0000"}}]