{"id":2959,"url":"https://patchwork.libcamera.org/api/patches/2959/?format=json","web_url":"https://patchwork.libcamera.org/patch/2959/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200304232246.325384-4-niklas.soderlund@ragnatech.se>","date":"2020-03-04T23:22:42","name":"[libcamera-devel,v3,3/7] libcamera: V4L2BufferCache: Mark Entry::operator==() as const","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"1bf6a545438a53a933d920e7d44826fdd6419032","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2959/mbox/","series":[{"id":701,"url":"https://patchwork.libcamera.org/api/series/701/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=701","date":"2020-03-04T23:22:39","name":"libcamera: V4L2BufferCache: Improve cache","version":3,"mbox":"https://patchwork.libcamera.org/series/701/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2959/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2959/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0EE586289D\n\tfor ;\n\tThu, 5 Mar 2020 00:23:46 +0100 (CET)","from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 31fcb537-5e6f-11ea-9f85-005056917a89;\n\tThu, 05 Mar 2020 00:23:46 +0100 (CET)"],"X-Halon-ID":"31fcb537-5e6f-11ea-9f85-005056917a89","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 5 Mar 2020 00:22:42 +0100","Message-Id":"<20200304232246.325384-4-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200304232246.325384-1-niklas.soderlund@ragnatech.se>","References":"<20200304232246.325384-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 3/7] libcamera: V4L2BufferCache: Mark\n\tEntry::operator==() as const","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 04 Mar 2020 23:23:47 -0000"},"content":"The comparison operator does not change any state, mark it as const.\n\nSigned-off-by: Niklas Söderlund \n---\n src/libcamera/include/v4l2_videodevice.h | 2 +-\n src/libcamera/v4l2_videodevice.cpp | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/include/v4l2_videodevice.h b/src/libcamera/include/v4l2_videodevice.h\nindex fcf072641420dacf..359b366454e4e782 100644\n--- a/src/libcamera/include/v4l2_videodevice.h\n+++ b/src/libcamera/include/v4l2_videodevice.h\n@@ -122,7 +122,7 @@ private:\n \t\tEntry();\n \t\tEntry(bool free, const FrameBuffer &buffer);\n \n-\t\tbool operator==(const FrameBuffer &buffer);\n+\t\tbool operator==(const FrameBuffer &buffer) const;\n \n \t\tbool free;\n \ndiff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex 99470ce11421c77c..d88cb0bd0771e545 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -256,7 +256,7 @@ V4L2BufferCache::Entry::Entry(bool free, const FrameBuffer &buffer)\n \t\tplanes_.emplace_back(plane);\n }\n \n-bool V4L2BufferCache::Entry::operator==(const FrameBuffer &buffer)\n+bool V4L2BufferCache::Entry::operator==(const FrameBuffer &buffer) const\n {\n \tconst std::vector &planes = buffer.planes();\n \n","prefixes":["libcamera-devel","v3","3/7"]}