[{"id":3893,"web_url":"https://patchwork.libcamera.org/comment/3893/","msgid":"","date":"2020-03-02T15:35:23","subject":"Re: [libcamera-devel] [PATCH] libcamera: control_serializer: Use\n\texplicit ControlTypeNone case","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 01/03/2020 16:02, Laurent Pinchart wrote:\n> Replace the default case with an explicit ControlTypeNone case in\n> ControlSerializer::load() to catch ommissions when adding new control\n> types.\n> \ns/ommissions/omissions/\n\nThis sounds good. Does it cause any issue with no default case found?\n\nIn fact looking again, Of course this now means that the compiler will\nwarn us here if an option is not handled by the case statement.\n\nExcellent.\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/control_serializer.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/control_serializer.cpp b/src/libcamera/control_serializer.cpp\n> index 5537c5466025..e78fca88cfea 100644\n> --- a/src/libcamera/control_serializer.cpp\n> +++ b/src/libcamera/control_serializer.cpp\n> @@ -361,7 +361,7 @@ ControlValue ControlSerializer::load(ControlType type,\n> \t\treturn ControlValue(value);\n> \t}\n> \n> -\tdefault:\n> +\tcase ControlTypeNone:\n> \t\treturn ControlValue();\n> \t}\n> }\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 86E7562710\n\tfor ;\n\tMon, 2 Mar 2020 16:35:27 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C50D49D0;\n\tMon, 2 Mar 2020 16:35:26 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583163327;\n\tbh=muys9V3bVE9i8TIud7nv+4+8/7O0pJNYYR2hfZGh9Ho=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=idSq3sdt4vyQkC8mcCIi9BFzLvZp4lryvlVDpaHSamsmHm2/RV2Wpq4HiEeuA1sOn\n\tZg6Bw+g2FfHndY7wRX0oODI1+QaValZmL9Hd5dMZ878uOBSaQwG7Sdh0K9l/H58S6Q\n\tZL5ZnTc59j4ecmUDA9ZU4A67daKKa4annu9mGik8=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200301160254.4548-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 2 Mar 2020 15:35:23 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200301160254.4548-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: control_serializer: Use\n\texplicit ControlTypeNone case","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 02 Mar 2020 15:35:27 -0000"}},{"id":3896,"web_url":"https://patchwork.libcamera.org/comment/3896/","msgid":"<20200302164115.GT11960@pendragon.ideasonboard.com>","date":"2020-03-02T16:41:15","subject":"Re: [libcamera-devel] [PATCH] libcamera: control_serializer: Use\n\texplicit ControlTypeNone case","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Mon, Mar 02, 2020 at 03:35:23PM +0000, Kieran Bingham wrote:\n> On 01/03/2020 16:02, Laurent Pinchart wrote:\n> > Replace the default case with an explicit ControlTypeNone case in\n> > ControlSerializer::load() to catch ommissions when adding new control\n> > types.\n>\n> s/ommissions/omissions/\n> \n> This sounds good. Does it cause any issue with no default case found?\n> \n> In fact looking again, Of course this now means that the compiler will\n> warn us here if an option is not handled by the case statement.\n\nBut some gcc version still reports that the function has an exit path\nwith a return statement :-( I'll have to add both.\n\n> Excellent.\n> \n> Reviewed-by: Kieran Bingham \n> \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/libcamera/control_serializer.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/control_serializer.cpp b/src/libcamera/control_serializer.cpp\n> > index 5537c5466025..e78fca88cfea 100644\n> > --- a/src/libcamera/control_serializer.cpp\n> > +++ b/src/libcamera/control_serializer.cpp\n> > @@ -361,7 +361,7 @@ ControlValue ControlSerializer::load(ControlType type,\n> > \t\treturn ControlValue(value);\n> > \t}\n> > \n> > -\tdefault:\n> > +\tcase ControlTypeNone:\n> > \t\treturn ControlValue();\n> > \t}\n> > }","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 927ED62710\n\tfor ;\n\tMon, 2 Mar 2020 17:41:40 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 208109D0;\n\tMon, 2 Mar 2020 17:41:40 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583167300;\n\tbh=LM5Sg7fYGHSU5TQ+tUfN/cSK7ytRBXYEoGR5p4T7IQM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=JrehhN2us1UPT02rz5no5YvuocrtxMsY2V64/8KgaXvq2DB4ZSipUkscgIl5xIw7B\n\tcY4Iwn1MIS+MBQLQ6k17agS+/TefkLet6ycY8JS5S/1Rt8NkVS+FLcjIiIQghPErlu\n\tu7gnp15DlWXp5GupcVusmJFmUlI7YUL/pMA2cjcg=","Date":"Mon, 2 Mar 2020 18:41:15 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200302164115.GT11960@pendragon.ideasonboard.com>","References":"<20200301160254.4548-1-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: control_serializer: Use\n\texplicit ControlTypeNone case","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 02 Mar 2020 16:41:40 -0000"}},{"id":3903,"web_url":"https://patchwork.libcamera.org/comment/3903/","msgid":"<612d7570-e92e-f0b3-2bdd-498eaf12b6f9@ideasonboard.com>","date":"2020-03-02T22:36:36","subject":"Re: [libcamera-devel] [PATCH] libcamera: control_serializer: Use\n\texplicit ControlTypeNone case","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 02/03/2020 16:41, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> On Mon, Mar 02, 2020 at 03:35:23PM +0000, Kieran Bingham wrote:\n>> On 01/03/2020 16:02, Laurent Pinchart wrote:\n>>> Replace the default case with an explicit ControlTypeNone case in\n>>> ControlSerializer::load() to catch ommissions when adding new control\n>>> types.\n>>\n>> s/ommissions/omissions/\n>>\n>> This sounds good. Does it cause any issue with no default case found?\n>>\n>> In fact looking again, Of course this now means that the compiler will\n>> warn us here if an option is not handled by the case statement.\n> \n> But some gcc version still reports that the function has an exit path\n> with a return statement :-( I'll have to add both.\n\nDoes adding both remove the benefit of having the compiler warn us when\nwe add new enum types without adding them to the case statement?\n\nIf not then that's fine.\n\n> \n>> Excellent.\n>>\n>> Reviewed-by: Kieran Bingham \n>>\n>>> Signed-off-by: Laurent Pinchart \n>>> ---\n>>> src/libcamera/control_serializer.cpp | 2 +-\n>>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>>\n>>> diff --git a/src/libcamera/control_serializer.cpp b/src/libcamera/control_serializer.cpp\n>>> index 5537c5466025..e78fca88cfea 100644\n>>> --- a/src/libcamera/control_serializer.cpp\n>>> +++ b/src/libcamera/control_serializer.cpp\n>>> @@ -361,7 +361,7 @@ ControlValue ControlSerializer::load(ControlType type,\n>>> \t\treturn ControlValue(value);\n>>> \t}\n>>> \n>>> -\tdefault:\n>>> +\tcase ControlTypeNone:\n>>> \t\treturn ControlValue();\n>>> \t}\n>>> }\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B6433627B6\n\tfor ;\n\tMon, 2 Mar 2020 23:36:39 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2F7EC9D0;\n\tMon, 2 Mar 2020 23:36:39 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583188599;\n\tbh=8bI50mQNvEWGT0dnwGnFpPDc+ceLzKP5G7vA7QFF0kY=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=NezZw4BseurEJI7UuPT+Y7njxMybYfPYyUO08lmAZfbJsTRM2iQKjGUG3owk3vuql\n\tNWMRGYS1FqcZ+d9cX2GNj6t5fHBaTKmt6DtqamnvkqCaFNfJMEA50bPDFRkadiA2Cq\n\t7Suo0/VUX5ebfiiKmW1oKq6KuZtoi+RPBhaO74e4=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20200301160254.4548-1-laurent.pinchart@ideasonboard.com>\n\t\n\t<20200302164115.GT11960@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<612d7570-e92e-f0b3-2bdd-498eaf12b6f9@ideasonboard.com>","Date":"Mon, 2 Mar 2020 22:36:36 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200302164115.GT11960@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: control_serializer: Use\n\texplicit ControlTypeNone case","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 02 Mar 2020 22:36:39 -0000"}},{"id":3920,"web_url":"https://patchwork.libcamera.org/comment/3920/","msgid":"<20200303084207.GA12468@pendragon.ideasonboard.com>","date":"2020-03-03T08:42:07","subject":"Re: [libcamera-devel] [PATCH] libcamera: control_serializer: Use\n\texplicit ControlTypeNone case","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Mon, Mar 02, 2020 at 10:36:36PM +0000, Kieran Bingham wrote:\n> On 02/03/2020 16:41, Laurent Pinchart wrote:\n> > On Mon, Mar 02, 2020 at 03:35:23PM +0000, Kieran Bingham wrote:\n> >> On 01/03/2020 16:02, Laurent Pinchart wrote:\n> >>> Replace the default case with an explicit ControlTypeNone case in\n> >>> ControlSerializer::load() to catch ommissions when adding new control\n> >>> types.\n> >>\n> >> s/ommissions/omissions/\n> >>\n> >> This sounds good. Does it cause any issue with no default case found?\n> >>\n> >> In fact looking again, Of course this now means that the compiler will\n> >> warn us here if an option is not handled by the case statement.\n> > \n> > But some gcc version still reports that the function has an exit path\n> > with a return statement :-( I'll have to add both.\n> \n> Does adding both remove the benefit of having the compiler warn us when\n> we add new enum types without adding them to the case statement?\n> \n> If not then that's fine.\n\nThe benefit stays :-) I've just tested it.\n\n> >> Excellent.\n> >>\n> >> Reviewed-by: Kieran Bingham \n> >>\n> >>> Signed-off-by: Laurent Pinchart \n> >>> ---\n> >>> src/libcamera/control_serializer.cpp | 2 +-\n> >>> 1 file changed, 1 insertion(+), 1 deletion(-)\n> >>>\n> >>> diff --git a/src/libcamera/control_serializer.cpp b/src/libcamera/control_serializer.cpp\n> >>> index 5537c5466025..e78fca88cfea 100644\n> >>> --- a/src/libcamera/control_serializer.cpp\n> >>> +++ b/src/libcamera/control_serializer.cpp\n> >>> @@ -361,7 +361,7 @@ ControlValue ControlSerializer::load(ControlType type,\n> >>> \t\treturn ControlValue(value);\n> >>> \t}\n> >>> \n> >>> -\tdefault:\n> >>> +\tcase ControlTypeNone:\n> >>> \t\treturn ControlValue();\n> >>> \t}\n> >>> }","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D4BD60426\n\tfor ;\n\tTue, 3 Mar 2020 09:42:34 +0100 (CET)","from pendragon.ideasonboard.com (85-76-78-31-nat.elisa-mobile.fi\n\t[85.76.78.31])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4613D2D2;\n\tTue, 3 Mar 2020 09:42:33 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583224953;\n\tbh=prGG7V5x286L3Kol3Xe3r+RW8Jr0lPEfqA+frfRiGXc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=T63nYSgoOwoEJrfGhacVc6b7G0fK194GzgOgfg1e5i7JLnzqXnIs81sJjitvvh04a\n\t5ab6/sgixiwRUmvzxSakBGmq/UtOS+DFP/4c210/EEh7SQZmSJvD2eqxdH4ZplBgV7\n\tOHGmpDbUhwzx9sPFsyFylnAvaotEdyGGCYb+ru1I=","Date":"Tue, 3 Mar 2020 10:42:07 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200303084207.GA12468@pendragon.ideasonboard.com>","References":"<20200301160254.4548-1-laurent.pinchart@ideasonboard.com>\n\t\n\t<20200302164115.GT11960@pendragon.ideasonboard.com>\n\t<612d7570-e92e-f0b3-2bdd-498eaf12b6f9@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<612d7570-e92e-f0b3-2bdd-498eaf12b6f9@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: control_serializer: Use\n\texplicit ControlTypeNone case","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 03 Mar 2020 08:42:34 -0000"}}]