[{"id":3947,"web_url":"https://patchwork.libcamera.org/comment/3947/","msgid":"<5bd5fd0e-27e5-3d29-fd06-b26c703b5f39@ideasonboard.com>","date":"2020-03-05T17:32:40","subject":"Re: [libcamera-devel] [PATCH 28/31] cam: Add option to list camera\n\tproperties","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 29/02/2020 16:42, Laurent Pinchart wrote:\n> From: Jacopo Mondi \n> \n> Add the '-p'|'--list-properties' option to the cam application to list\n> the properties of a camera.\n> \n> Signed-off-by: Laurent Pinchart \n> Signed-off-by: Jacopo Mondi \n> Reviewed-by: Niklas Söderlund \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/cam/main.cpp | 28 ++++++++++++++++++++++++++++\n> src/cam/main.h | 1 +\n> 2 files changed, 29 insertions(+)\n> \n> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> index a38cca959aca..ea6f7914839c 100644\n> --- a/src/cam/main.cpp\n> +++ b/src/cam/main.cpp\n> @@ -11,6 +11,7 @@\n> #include \n> \n> #include \n> +#include \n> \n> #include \"capture.h\"\n> #include \"event_loop.h\"\n> @@ -36,6 +37,7 @@ public:\n> private:\n> \tint parseOptions(int argc, char *argv[]);\n> \tint prepareConfig();\n> +\tint listProperties();\n> \tint infoConfiguration();\n> \tint run();\n> \n> @@ -180,6 +182,8 @@ int CamApp::parseOptions(int argc, char *argv[])\n> \tparser.addOption(OptInfo, OptionNone,\n> \t\t\t \"Display information about stream(s)\", \"info\");\n> \tparser.addOption(OptList, OptionNone, \"List all cameras\", \"list\");\n> +\tparser.addOption(OptProps, OptionNone, \"List cameras properties\",\n> +\t\t\t \"list-properties\");\n> \n> \toptions_ = parser.parse(argc, argv);\n> \tif (!options_.valid())\n> @@ -268,6 +272,24 @@ int CamApp::prepareConfig()\n> \treturn 0;\n> }\n> \n> +int CamApp::listProperties()\n> +{\n> +\tif (!camera_) {\n> +\t\tstd::cout << \"Cannot list properties without a camera\"\n> +\t\t\t << std::endl;\n> +\t\treturn -EINVAL;\n> +\t}\n\nHrm ...\n\nI feel like this should be handled higher up in cam, and if a camera is\nnot selected, then the first one gets used.\n\nAnd if one is *not available* then cam shouldn't be able to do anything?\n\n\n\n> +\n> +\tfor (const auto &prop : camera_->properties()) {\n> +\t\tconst ControlId *id = properties::properties.at(prop.first);\n> +\t\tconst ControlValue &value = prop.second;\n> +\n> +\t\tstd::cout << \"Property: \" << id->name() << \" = \" << value.toString();\n> +\t}\n> +\n> +\treturn 0;\n> +}\n> +\n> int CamApp::infoConfiguration()\n> {\n> \tif (!config_) {\n> @@ -312,6 +334,12 @@ int CamApp::run()\n> \t\t}\n> \t}\n> \n> +\tif (options_.isSet(OptProps)) {\n> +\t\tret = listProperties();\n> +\t\tif (ret)\n> +\t\t\treturn ret;\n> +\t}\n> +\n> \tif (options_.isSet(OptInfo)) {\n> \t\tret = infoConfiguration();\n> \t\tif (ret)\n> diff --git a/src/cam/main.h b/src/cam/main.h\n> index 0997476bb335..afcad4353b7d 100644\n> --- a/src/cam/main.h\n> +++ b/src/cam/main.h\n> @@ -14,6 +14,7 @@ enum {\n> \tOptHelp = 'h',\n> \tOptInfo = 'I',\n> \tOptList = 'l',\n> +\tOptProps = 'p',\n> \tOptStream = 's',\n> };\n> \n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 19D4C60427\n\tfor ;\n\tThu, 5 Mar 2020 18:32:43 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 836CA312;\n\tThu, 5 Mar 2020 18:32:42 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583429562;\n\tbh=WmEt82I6CQqMk3utF0OJciEld2j/8lAvmdeWefTBrOE=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=ZqVFzvsN4df0kRBeks8tcehLae+qP/hdEFXftHkMCfklPyhTXoyNEVHfU5bK0hIWk\n\tfCPDki+8/v+0BA9aX26/mdhyTpMQJfSDatp6lk/VP/xWZ0x2D0u1qV4qc67P9kqTig\n\to/4VjuaoEUAwFI60kscw+z3N3eaZrehWmjrBixHg=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200229164254.23604-1-laurent.pinchart@ideasonboard.com>\n\t<20200229164254.23604-29-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<5bd5fd0e-27e5-3d29-fd06-b26c703b5f39@ideasonboard.com>","Date":"Thu, 5 Mar 2020 17:32:40 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200229164254.23604-29-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 28/31] cam: Add option to list camera\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 05 Mar 2020 17:32:43 -0000"}},{"id":3957,"web_url":"https://patchwork.libcamera.org/comment/3957/","msgid":"<20200306150706.GN4878@pendragon.ideasonboard.com>","date":"2020-03-06T15:07:06","subject":"Re: [libcamera-devel] [PATCH 28/31] cam: Add option to list camera\n\tproperties","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Thu, Mar 05, 2020 at 05:32:40PM +0000, Kieran Bingham wrote:\n> On 29/02/2020 16:42, Laurent Pinchart wrote:\n> > From: Jacopo Mondi \n> > \n> > Add the '-p'|'--list-properties' option to the cam application to list\n> > the properties of a camera.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > Signed-off-by: Jacopo Mondi \n> > Reviewed-by: Niklas Söderlund \n> \n> Reviewed-by: Kieran Bingham \n> \n> > ---\n> > src/cam/main.cpp | 28 ++++++++++++++++++++++++++++\n> > src/cam/main.h | 1 +\n> > 2 files changed, 29 insertions(+)\n> > \n> > diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> > index a38cca959aca..ea6f7914839c 100644\n> > --- a/src/cam/main.cpp\n> > +++ b/src/cam/main.cpp\n> > @@ -11,6 +11,7 @@\n> > #include \n> > \n> > #include \n> > +#include \n> > \n> > #include \"capture.h\"\n> > #include \"event_loop.h\"\n> > @@ -36,6 +37,7 @@ public:\n> > private:\n> > \tint parseOptions(int argc, char *argv[]);\n> > \tint prepareConfig();\n> > +\tint listProperties();\n> > \tint infoConfiguration();\n> > \tint run();\n> > \n> > @@ -180,6 +182,8 @@ int CamApp::parseOptions(int argc, char *argv[])\n> > \tparser.addOption(OptInfo, OptionNone,\n> > \t\t\t \"Display information about stream(s)\", \"info\");\n> > \tparser.addOption(OptList, OptionNone, \"List all cameras\", \"list\");\n> > +\tparser.addOption(OptProps, OptionNone, \"List cameras properties\",\n> > +\t\t\t \"list-properties\");\n> > \n> > \toptions_ = parser.parse(argc, argv);\n> > \tif (!options_.valid())\n> > @@ -268,6 +272,24 @@ int CamApp::prepareConfig()\n> > \treturn 0;\n> > }\n> > \n> > +int CamApp::listProperties()\n> > +{\n> > +\tif (!camera_) {\n> > +\t\tstd::cout << \"Cannot list properties without a camera\"\n> > +\t\t\t << std::endl;\n> > +\t\treturn -EINVAL;\n> > +\t}\n> \n> Hrm ...\n> \n> I feel like this should be handled higher up in cam, and if a camera is\n> not selected, then the first one gets used.\n> \n> And if one is *not available* then cam shouldn't be able to do anything?\n\nThere's at least one option that doesn't need to specify a camera,\nthat's -l. I agree we should rework the code, the infoConfiguration()\nfunction is implemented with similar logic. I thus propose doing so on\ntop of this patch.\n\n> > +\n> > +\tfor (const auto &prop : camera_->properties()) {\n> > +\t\tconst ControlId *id = properties::properties.at(prop.first);\n> > +\t\tconst ControlValue &value = prop.second;\n> > +\n> > +\t\tstd::cout << \"Property: \" << id->name() << \" = \" << value.toString();\n> > +\t}\n> > +\n> > +\treturn 0;\n> > +}\n> > +\n> > int CamApp::infoConfiguration()\n> > {\n> > \tif (!config_) {\n> > @@ -312,6 +334,12 @@ int CamApp::run()\n> > \t\t}\n> > \t}\n> > \n> > +\tif (options_.isSet(OptProps)) {\n> > +\t\tret = listProperties();\n> > +\t\tif (ret)\n> > +\t\t\treturn ret;\n> > +\t}\n> > +\n> > \tif (options_.isSet(OptInfo)) {\n> > \t\tret = infoConfiguration();\n> > \t\tif (ret)\n> > diff --git a/src/cam/main.h b/src/cam/main.h\n> > index 0997476bb335..afcad4353b7d 100644\n> > --- a/src/cam/main.h\n> > +++ b/src/cam/main.h\n> > @@ -14,6 +14,7 @@ enum {\n> > \tOptHelp = 'h',\n> > \tOptInfo = 'I',\n> > \tOptList = 'l',\n> > +\tOptProps = 'p',\n> > \tOptStream = 's',\n> > };\n> >","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 738DB60424\n\tfor ;\n\tFri, 6 Mar 2020 16:07:09 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DF17F24B;\n\tFri, 6 Mar 2020 16:07:08 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583507229;\n\tbh=ZzLOiiv2kuEnZFAcxCUP4L1AfSqmzJEFWsFPRmUpzG4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ePlJqwHR9oV5ZCT9W725FFdTWr6hBq6zY5nmghbcPBX0a4ZR4SKMrMO1y0j4SnfWD\n\tYs8jdwOLSz2+qxh8sy/ko89tA75P1bEavZuDjAnJST3Ux4jnnTvnH9/rT3h8S4vnmy\n\tBF8NyRCUpL4zFzJdy2T6HZq5W4MShZmHqoar1urg=","Date":"Fri, 6 Mar 2020 17:07:06 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200306150706.GN4878@pendragon.ideasonboard.com>","References":"<20200229164254.23604-1-laurent.pinchart@ideasonboard.com>\n\t<20200229164254.23604-29-laurent.pinchart@ideasonboard.com>\n\t<5bd5fd0e-27e5-3d29-fd06-b26c703b5f39@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<5bd5fd0e-27e5-3d29-fd06-b26c703b5f39@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 28/31] cam: Add option to list camera\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 06 Mar 2020 15:07:09 -0000"}}]