[{"id":3941,"web_url":"https://patchwork.libcamera.org/comment/3941/","msgid":"","date":"2020-03-05T15:38:26","subject":"Re: [libcamera-devel] [PATCH 23/31] libcamera: byte_stream_buffer:\n\tAdd Span<> support","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 29/02/2020 16:42, Laurent Pinchart wrote:\n> From: Jacopo Mondi \n> \n> Add support to read and write a Span<> from and to the ByteStreamBuffer\n\ns/from and to/to and from/\n\n(Yes, I know that matches the 'order' of read and write, but we would\nnot really say \"from and to\" in English)\n\n> class.\n> \n> Signed-off-by: Jacopo Mondi \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n\n\n> ---\n> src/libcamera/byte_stream_buffer.cpp | 18 ++++++++++++++++++\n> src/libcamera/include/byte_stream_buffer.h | 17 +++++++++++++++++\n> 2 files changed, 35 insertions(+)\n> \n> diff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp\n> index cd1d8a36d464..40380bf0434a 100644\n> --- a/src/libcamera/byte_stream_buffer.cpp\n> +++ b/src/libcamera/byte_stream_buffer.cpp\n> @@ -232,6 +232,15 @@ int ByteStreamBuffer::skip(size_t size)\n> * \\retval -ENOSPC no more space is available in the managed memory buffer\n> */\n> \n> +/**\n> + * \\fn template int ByteStreamBuffer::read(const Span &data)\n> + * \\brief Read data from the managed memory buffer into span \\a data\n\ns/span/Span/ ?\n\n> + * \\param[out] data Span representing the destination memory\n> + * \\return 0 on success, a negative error code otherwise\n> + * \\retval -EACCES attempting to read from a write buffer\n> + * \\retval -ENOSPC no more space is available in the managed memory buffer\n> + */\n> +\n> /**\n> * \\fn template int ByteStreamBuffer::write(const T *t)\n> * \\brief Write \\a t to the managed memory buffer\n> @@ -241,6 +250,15 @@ int ByteStreamBuffer::skip(size_t size)\n> * \\retval -ENOSPC no more space is available in the managed memory buffer\n> */\n> \n> +/**\n> + * \\fn template int ByteStreamBuffer::write(const Span &data)\n> + * \\brief Write \\a data to the managed memory buffer\n> + * \\param[in] data The data to write to memory\n> + * \\return 0 on success, a negative error code otherwise\n> + * \\retval -EACCES attempting to write to a read buffer\n> + * \\retval -ENOSPC no more space is available in the managed memory buffer\n> + */\n> +\n> int ByteStreamBuffer::read(uint8_t *data, size_t size)\n> {\n> \tif (!read_)\n> diff --git a/src/libcamera/include/byte_stream_buffer.h b/src/libcamera/include/byte_stream_buffer.h\n> index b5274c62b85e..17cb0146061e 100644\n> --- a/src/libcamera/include/byte_stream_buffer.h\n> +++ b/src/libcamera/include/byte_stream_buffer.h\n> @@ -10,6 +10,8 @@\n> #include \n> #include \n> \n> +#include \n> +\n> namespace libcamera {\n> \n> class ByteStreamBuffer\n> @@ -33,12 +35,27 @@ public:\n> \t{\n> \t\treturn read(reinterpret_cast(t), sizeof(*t));\n> \t}\n> +\n> +\ttemplate\n> +\tint read(const Span &data)\n> +\t{\n> +\t\treturn read(reinterpret_cast(data.data()),\n> +\t\t\t data.size_bytes());\n> +\t}\n> +\n> \ttemplate\n> \tint write(const T *t)\n> \t{\n> \t\treturn write(reinterpret_cast(t), sizeof(*t));\n> \t}\n> \n> +\ttemplate\n> +\tint write(const Span &data)\n> +\t{\n> +\t\treturn write(reinterpret_cast(data.data()),\n> +\t\t\t data.size_bytes());\n> +\t}\n> +\n> private:\n> \tByteStreamBuffer(const ByteStreamBuffer &other) = delete;\n> \tByteStreamBuffer &operator=(const ByteStreamBuffer &other) = delete;\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 19A2660427\n\tfor ;\n\tThu, 5 Mar 2020 16:38:30 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 57DEC312;\n\tThu, 5 Mar 2020 16:38:29 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583422709;\n\tbh=SiOUikm0mScrNZLqBWcA6krSK16S1S6KDPCRwXw8ehc=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=lQtN2k4h75La6AjwHMtQ28cna4/NHU7gYhhPq6Fku8HgMwF7HJGG4rvPCLDlo/RYn\n\tcDFrxGKq9LwcmzCO1O1g1p3IWkZhxyTBZ6KQFIZUu5N0aswGlUhDrJow+X0IqCKq8m\n\tmXFjG1x3zqdCzlUKPWaUq1cBlBFKvehqZpph8yE0=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200229164254.23604-1-laurent.pinchart@ideasonboard.com>\n\t<20200229164254.23604-24-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 5 Mar 2020 15:38:26 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200229164254.23604-24-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 23/31] libcamera: byte_stream_buffer:\n\tAdd Span<> support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 05 Mar 2020 15:38:30 -0000"}},{"id":3953,"web_url":"https://patchwork.libcamera.org/comment/3953/","msgid":"<20200306145032.GJ4878@pendragon.ideasonboard.com>","date":"2020-03-06T14:50:32","subject":"Re: [libcamera-devel] [PATCH 23/31] libcamera: byte_stream_buffer:\n\tAdd Span<> support","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Thu, Mar 05, 2020 at 03:38:26PM +0000, Kieran Bingham wrote:\n> On 29/02/2020 16:42, Laurent Pinchart wrote:\n> > From: Jacopo Mondi \n> > \n> > Add support to read and write a Span<> from and to the ByteStreamBuffer\n> \n> s/from and to/to and from/\n> \n> (Yes, I know that matches the 'order' of read and write, but we would\n> not really say \"from and to\" in English)\n\nI've worked around the issue with \"write and read ... to and from\" :-)\n\n> > class.\n> > \n> > Signed-off-by: Jacopo Mondi \n> > Signed-off-by: Laurent Pinchart \n> \n> Reviewed-by: Kieran Bingham \n> \n> > ---\n> > src/libcamera/byte_stream_buffer.cpp | 18 ++++++++++++++++++\n> > src/libcamera/include/byte_stream_buffer.h | 17 +++++++++++++++++\n> > 2 files changed, 35 insertions(+)\n> > \n> > diff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp\n> > index cd1d8a36d464..40380bf0434a 100644\n> > --- a/src/libcamera/byte_stream_buffer.cpp\n> > +++ b/src/libcamera/byte_stream_buffer.cpp\n> > @@ -232,6 +232,15 @@ int ByteStreamBuffer::skip(size_t size)\n> > * \\retval -ENOSPC no more space is available in the managed memory buffer\n> > */\n> > \n> > +/**\n> > + * \\fn template int ByteStreamBuffer::read(const Span &data)\n> > + * \\brief Read data from the managed memory buffer into span \\a data\n> \n> s/span/Span/ ?\n\nFixed.\n\n> > + * \\param[out] data Span representing the destination memory\n> > + * \\return 0 on success, a negative error code otherwise\n> > + * \\retval -EACCES attempting to read from a write buffer\n> > + * \\retval -ENOSPC no more space is available in the managed memory buffer\n> > + */\n> > +\n> > /**\n> > * \\fn template int ByteStreamBuffer::write(const T *t)\n> > * \\brief Write \\a t to the managed memory buffer\n> > @@ -241,6 +250,15 @@ int ByteStreamBuffer::skip(size_t size)\n> > * \\retval -ENOSPC no more space is available in the managed memory buffer\n> > */\n> > \n> > +/**\n> > + * \\fn template int ByteStreamBuffer::write(const Span &data)\n> > + * \\brief Write \\a data to the managed memory buffer\n> > + * \\param[in] data The data to write to memory\n> > + * \\return 0 on success, a negative error code otherwise\n> > + * \\retval -EACCES attempting to write to a read buffer\n> > + * \\retval -ENOSPC no more space is available in the managed memory buffer\n> > + */\n> > +\n> > int ByteStreamBuffer::read(uint8_t *data, size_t size)\n> > {\n> > \tif (!read_)\n> > diff --git a/src/libcamera/include/byte_stream_buffer.h b/src/libcamera/include/byte_stream_buffer.h\n> > index b5274c62b85e..17cb0146061e 100644\n> > --- a/src/libcamera/include/byte_stream_buffer.h\n> > +++ b/src/libcamera/include/byte_stream_buffer.h\n> > @@ -10,6 +10,8 @@\n> > #include \n> > #include \n> > \n> > +#include \n> > +\n> > namespace libcamera {\n> > \n> > class ByteStreamBuffer\n> > @@ -33,12 +35,27 @@ public:\n> > \t{\n> > \t\treturn read(reinterpret_cast(t), sizeof(*t));\n> > \t}\n> > +\n> > +\ttemplate\n> > +\tint read(const Span &data)\n> > +\t{\n> > +\t\treturn read(reinterpret_cast(data.data()),\n> > +\t\t\t data.size_bytes());\n> > +\t}\n> > +\n> > \ttemplate\n> > \tint write(const T *t)\n> > \t{\n> > \t\treturn write(reinterpret_cast(t), sizeof(*t));\n> > \t}\n> > \n> > +\ttemplate\n> > +\tint write(const Span &data)\n> > +\t{\n> > +\t\treturn write(reinterpret_cast(data.data()),\n> > +\t\t\t data.size_bytes());\n> > +\t}\n> > +\n> > private:\n> > \tByteStreamBuffer(const ByteStreamBuffer &other) = delete;\n> > \tByteStreamBuffer &operator=(const ByteStreamBuffer &other) = delete;\n> >","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 34E6960424\n\tfor ;\n\tFri, 6 Mar 2020 15:50:37 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7BEDD24B;\n\tFri, 6 Mar 2020 15:50:36 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583506236;\n\tbh=Uw3ZnwmcdcsDs3sW/21ZHUYNfSkBjkEHRkCw8pl/9V0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mMuiVnlv2cBQFQginmEbKWrnzsI7lC6f+zsaBjt5UITPQuxxq9rhcUZk0gvZTQQ+1\n\tXgOqfz36FKQeWgU1Aoat6Wm8JUecrvjSC7MnXspB3u5J9fDsuXfPSWfXn8HassleUa\n\tMT0ycDvW2SHfByjBS/m1HPmnfhqRcz/AJqze57ys=","Date":"Fri, 6 Mar 2020 16:50:32 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200306145032.GJ4878@pendragon.ideasonboard.com>","References":"<20200229164254.23604-1-laurent.pinchart@ideasonboard.com>\n\t<20200229164254.23604-24-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 23/31] libcamera: byte_stream_buffer:\n\tAdd Span<> support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 06 Mar 2020 14:50:37 -0000"}}]