[{"id":3918,"web_url":"https://patchwork.libcamera.org/comment/3918/","msgid":"<7e4081b4-939c-dbb2-0bd4-501190ff6e80@ideasonboard.com>","date":"2020-03-03T00:42:39","subject":"Re: [libcamera-devel] [PATCH 20/31] libcamera: controls: Add\n\tsupport for int8_t controls","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 29/02/2020 16:42, Laurent Pinchart wrote:\n> From: Jacopo Mondi \n> \n> Add support for 8 bit integers to the control framework and to the\n> control serializer.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Kieran Bingham \n\n\n> ---\n> include/libcamera/controls.h | 6 ++++++\n> src/libcamera/control_serializer.cpp | 12 ++++++++++++\n> src/libcamera/controls.cpp | 14 +++++++++++---\n> 3 files changed, 29 insertions(+), 3 deletions(-)\n> \n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index 97a662e3f4a6..9b3aaae55c78 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -22,6 +22,7 @@ class ControlValidator;\n> enum ControlType {\n> \tControlTypeNone,\n> \tControlTypeBool,\n> +\tControlTypeInteger8,\n> \tControlTypeInteger32,\n> \tControlTypeInteger64,\n> \tControlTypeFloat,\n> @@ -43,6 +44,11 @@ struct control_type {\n> \tstatic constexpr ControlType value = ControlTypeBool;\n> };\n> \n> +template<>\n> +struct control_type {\n> +\tstatic constexpr ControlType value = ControlTypeInteger8;\n> +};\n> +\n> template<>\n> struct control_type {\n> \tstatic constexpr ControlType value = ControlTypeInteger32;\n> diff --git a/src/libcamera/control_serializer.cpp b/src/libcamera/control_serializer.cpp\n> index 5feaaa965cc5..5537c5466025 100644\n> --- a/src/libcamera/control_serializer.cpp\n> +++ b/src/libcamera/control_serializer.cpp\n> @@ -153,6 +153,12 @@ void ControlSerializer::store(const ControlValue &value,\n> \t\tbreak;\n> \t}\n> \n> +\tcase ControlTypeInteger8: {\n> +\t\tint8_t data = value.get();\n> +\t\tbuffer.write(&data);\n> +\t\tbreak;\n> +\t}\n> +\n> \tcase ControlTypeInteger32: {\n> \t\tint32_t data = value.get();\n> \t\tbuffer.write(&data);\n> @@ -331,6 +337,12 @@ ControlValue ControlSerializer::load(ControlType type,\n> \t\treturn ControlValue(value);\n> \t}\n> \n> +\tcase ControlTypeInteger8: {\n> +\t\tint8_t value;\n> +\t\tb.read(&value);\n> +\t\treturn ControlValue(value);\n> +\t}\n> +\n> \tcase ControlTypeInteger32: {\n> \t\tint32_t value;\n> \t\tb.read(&value);\n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index 46469dd8b98b..9970d75ea684 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -53,6 +53,7 @@ namespace {\n> static constexpr size_t ControlValueSize[] = {\n> \t[ControlTypeNone]\t\t= 0,\n> \t[ControlTypeBool]\t\t= sizeof(bool),\n> +\t[ControlTypeInteger8]\t\t= sizeof(int8_t),\n> \t[ControlTypeInteger32]\t\t= sizeof(int32_t),\n> \t[ControlTypeInteger64]\t\t= sizeof(int64_t),\n> \t[ControlTypeFloat]\t\t= sizeof(float),\n> @@ -67,6 +68,8 @@ static constexpr size_t ControlValueSize[] = {\n> * Invalid type, for empty values\n> * \\var ControlTypeBool\n> * The control stores a boolean value\n> + * \\var ControlTypeInteger8\n> + * The control stores an 8-bit integer value\n> * \\var ControlTypeInteger32\n> * The control stores a 32-bit integer value\n> * \\var ControlTypeInteger64\n> @@ -202,6 +205,11 @@ std::string ControlValue::toString() const\n> \t\t\tstr += *value ? \"True\" : \"False\";\n> \t\t\tbreak;\n> \t\t}\n> +\t\tcase ControlTypeInteger8: {\n> +\t\t\tconst int8_t *value = reinterpret_cast(data);\n> +\t\t\tstr += std::to_string(*value);\n> +\t\t\tbreak;\n> +\t\t}\n> \t\tcase ControlTypeInteger32: {\n> \t\t\tconst int32_t *value = reinterpret_cast(data);\n> \t\t\tstr += std::to_string(*value);\n> @@ -386,9 +394,9 @@ void ControlValue::set(ControlType type, bool isArray, const void *data,\n> * instead of Control.\n> *\n> * Controls of any type can be defined through template specialisation, but\n> - * libcamera only supports the bool, int32_t, int64_t and float types natively\n> - * (this includes types that are equivalent to the supported types, such as int\n> - * and long int).\n> + * libcamera only supports the bool, int8_t, int32_t, int64_t and float types\n> + * natively (this includes types that are equivalent to the supported types,\n> + * such as int and long int).\n> *\n> * Controls IDs shall be unique. While nothing prevents multiple instances of\n> * the Control class to be created with the same ID for the same object, doing\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 06F036279B\n\tfor ;\n\tTue, 3 Mar 2020 01:42:42 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9E3519D0;\n\tTue, 3 Mar 2020 01:42:41 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583196161;\n\tbh=JXkQvYDbq1fwFcTGJjf0f6Ptf66+qaIhmmjJVOBTtvU=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=d2y32R9cBDU2q1sx932RwU5QIEBLZcD3zGO3we/M90uG+g7vLSVuUJ4K4GgQ8bY+K\n\tuxmpw2diwDH9/1PE0JWTjvdIbP8XNsdxBwTjTjpdNIjPVPqkYYuKgllFiOnO93CE0B\n\tVI8Tg2H9F6hQaiO13OVqVAMxk8ymsqqQdR/VSF6Q=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200229164254.23604-1-laurent.pinchart@ideasonboard.com>\n\t<20200229164254.23604-21-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<7e4081b4-939c-dbb2-0bd4-501190ff6e80@ideasonboard.com>","Date":"Tue, 3 Mar 2020 00:42:39 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200229164254.23604-21-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 20/31] libcamera: controls: Add\n\tsupport for int8_t controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 03 Mar 2020 00:42:42 -0000"}}]