[{"id":3938,"web_url":"https://patchwork.libcamera.org/comment/3938/","msgid":"<3beb7482-c371-5579-af6f-e0abfff0f7bf@ideasonboard.com>","date":"2020-03-05T14:53:05","subject":"Re: [libcamera-devel] [PATCH 18/31] libcamera: controls: Add a\n\t'size' yaml property","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi\n\nOn 29/02/2020 16:42, Laurent Pinchart wrote:\n> From: Jacopo Mondi \n> \n> Add a 'size' property to the control yaml description, to convey the\n> size constraints of array constrols. The semantics of the property\n\n/constrols/controls/\n\n> contents is currently unspecified, but its presence triggers the\n> generation of an array control (Control>).\n> \n> Example:\n> \n> - BayerGains:\n> type: float\n> description: Gains to apply to the four Bayer colour components for white balance\n> size: [4]\n> \n> Signed-off-by: Jacopo Mondi \n> Signed-off-by: Laurent Pinchart \n\nWill we define dynamic sizes ? Or min/max options?\n\nPresuming that this is 'just' for fixed size compound controls so far,\nand there will be more to come on this later:\n\nAt some point we may want/need a schema and validator for this.\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/gen-controls.py | 14 ++++++++++++--\n> 1 file changed, 12 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/gen-controls.py b/src/libcamera/gen-controls.py\n> index 6f020a327827..ff8bda6b16c1 100755\n> --- a/src/libcamera/gen-controls.py\n> +++ b/src/libcamera/gen-controls.py\n> @@ -42,9 +42,14 @@ ${description}\n> name, ctrl = ctrl.popitem()\n> id_name = snake_case(name).upper()\n> \n> + if ctrl.get('size'):\n> + ctrl_type = 'Span' % ctrl['type']\n> + else:\n> + ctrl_type = ctrl['type']\n> +\n> info = {\n> 'name': name,\n> - 'type': ctrl['type'],\n> + 'type': ctrl_type,\n> 'description': format_description(ctrl['description']),\n> 'id_name': id_name,\n> }\n> @@ -92,9 +97,14 @@ def generate_h(controls):\n> \n> ids.append('\\t' + id_name + ' = ' + str(id_value) + ',')\n> \n> + if ctrl.get('size'):\n> + ctrl_type = 'Span' % ctrl['type']\n> + else:\n> + ctrl_type = ctrl['type']\n> +\n> info = {\n> 'name': name,\n> - 'type': ctrl['type'],\n> + 'type': ctrl_type,\n> }\n> \n> enum = ctrl.get('enum')\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E42860427\n\tfor ;\n\tThu, 5 Mar 2020 15:53:09 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 593DF312;\n\tThu, 5 Mar 2020 15:53:08 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583419988;\n\tbh=36K5qPkJm311gD1QXxby8l2Dx1os1GT/cUYB+1t46sE=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=q07gSUyqldEU6U/KhBelN0v2jepaJiqksDEwUReqHnlFGLFUs16srjHhKsgd9JP/+\n\tFyyLLTKvBMQf0Y/WsOxgjYX84TkCllw1tk0FzHUkWMGr0+qiNPNahfGCoyXnjvJ5Mb\n\tWB8PMq2UG59XW594k8MzMRMsrpMfyLcf+y11KtPM=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200229164254.23604-1-laurent.pinchart@ideasonboard.com>\n\t<20200229164254.23604-19-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<3beb7482-c371-5579-af6f-e0abfff0f7bf@ideasonboard.com>","Date":"Thu, 5 Mar 2020 14:53:05 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200229164254.23604-19-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 18/31] libcamera: controls: Add a\n\t'size' yaml property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 05 Mar 2020 14:53:09 -0000"}},{"id":3951,"web_url":"https://patchwork.libcamera.org/comment/3951/","msgid":"<20200306144349.GH4878@pendragon.ideasonboard.com>","date":"2020-03-06T14:43:49","subject":"Re: [libcamera-devel] [PATCH 18/31] libcamera: controls: Add a\n\t'size' yaml property","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Thu, Mar 05, 2020 at 02:53:05PM +0000, Kieran Bingham wrote:\n> On 29/02/2020 16:42, Laurent Pinchart wrote:\n> > From: Jacopo Mondi \n> > \n> > Add a 'size' property to the control yaml description, to convey the\n> > size constraints of array constrols. The semantics of the property\n> \n> /constrols/controls/\n> \n> > contents is currently unspecified, but its presence triggers the\n> > generation of an array control (Control>).\n> > \n> > Example:\n> > \n> > - BayerGains:\n> > type: float\n> > description: Gains to apply to the four Bayer colour components for white balance\n> > size: [4]\n> > \n> > Signed-off-by: Jacopo Mondi \n> > Signed-off-by: Laurent Pinchart \n> \n> Will we define dynamic sizes ? Or min/max options?\n\nBoth I believe :-) I can see use cases for [n], [3x3], [4x2xn] or [nxm].\n\n> Presuming that this is 'just' for fixed size compound controls so far,\n> and there will be more to come on this later:\n\nThe array control support implementation supports dynamic sizes. We'll\nhave to figure out how to express that properly in yaml, and what to do\nwith the information, but I don't expect it to affect the ControlValue\nor ControlList classes. The information may be added to the Control\nclass to add dynamic validation (or just query) at some point.\n\n> At some point we may want/need a schema and validator for this.\n\nYes :-)\n\n> Reviewed-by: Kieran Bingham \n> \n> > ---\n> > src/libcamera/gen-controls.py | 14 ++++++++++++--\n> > 1 file changed, 12 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/src/libcamera/gen-controls.py b/src/libcamera/gen-controls.py\n> > index 6f020a327827..ff8bda6b16c1 100755\n> > --- a/src/libcamera/gen-controls.py\n> > +++ b/src/libcamera/gen-controls.py\n> > @@ -42,9 +42,14 @@ ${description}\n> > name, ctrl = ctrl.popitem()\n> > id_name = snake_case(name).upper()\n> > \n> > + if ctrl.get('size'):\n> > + ctrl_type = 'Span' % ctrl['type']\n> > + else:\n> > + ctrl_type = ctrl['type']\n> > +\n> > info = {\n> > 'name': name,\n> > - 'type': ctrl['type'],\n> > + 'type': ctrl_type,\n> > 'description': format_description(ctrl['description']),\n> > 'id_name': id_name,\n> > }\n> > @@ -92,9 +97,14 @@ def generate_h(controls):\n> > \n> > ids.append('\\t' + id_name + ' = ' + str(id_value) + ',')\n> > \n> > + if ctrl.get('size'):\n> > + ctrl_type = 'Span' % ctrl['type']\n> > + else:\n> > + ctrl_type = ctrl['type']\n> > +\n> > info = {\n> > 'name': name,\n> > - 'type': ctrl['type'],\n> > + 'type': ctrl_type,\n> > }\n> > \n> > enum = ctrl.get('enum')","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B633460424\n\tfor ;\n\tFri, 6 Mar 2020 15:43:52 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2DE7B24B;\n\tFri, 6 Mar 2020 15:43:52 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583505832;\n\tbh=3koYNXs6RU+rWp0UVtl9jR/0i61IPJ7ebXCrbjREQu4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hXcdlU9Y6T/Lk8NnkxA8bh1+/cC5KUlSz2V4zqocSWTWPYsX01/82p4632/WWgUJQ\n\tAc6ojGSGNCzEQnrFDoqDQYKFAr9NCrt8Paeqqw4LfHQxMe2WvEdlOJZLA3TV0COCxd\n\tb6BEPYGSOz9xMAsRKovay7tMM9uK6ZAu03Y6R28g=","Date":"Fri, 6 Mar 2020 16:43:49 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200306144349.GH4878@pendragon.ideasonboard.com>","References":"<20200229164254.23604-1-laurent.pinchart@ideasonboard.com>\n\t<20200229164254.23604-19-laurent.pinchart@ideasonboard.com>\n\t<3beb7482-c371-5579-af6f-e0abfff0f7bf@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<3beb7482-c371-5579-af6f-e0abfff0f7bf@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 18/31] libcamera: controls: Add a\n\t'size' yaml property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 06 Mar 2020 14:43:52 -0000"}}]