[{"id":3916,"web_url":"https://patchwork.libcamera.org/comment/3916/","msgid":"<328752e9-8a80-1867-ca21-54a9042c0cc7@ideasonboard.com>","date":"2020-03-03T00:30:28","subject":"Re: [libcamera-devel] [PATCH 17/31] libcamera: controls: Allow\n\tpassing an std::initializer list to set()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 29/02/2020 16:42, Laurent Pinchart wrote:\n> For array controls, the ControlList::set() function takes a value as a\n> type convertible to Span. This allows passing an std::array or an\n> std::vector in addition to an explicit Span, but doesn't accept an\n> std::initializer list as Span has no constructor that takes an\n> initializer list. Callers are thus forced to create temporary objects\n> explicitly, which isn't nice.\n> \n> Fix the issue by providing a ControlList::set() function that takes an\n> std::initializer_list, and convert it to a Span internally.\n> \n> Signed-off-by: Laurent Pinchart \n\nAha, nice - so this is how we then get to 'create' controls like\nControl{1,2,3,4} or such ?\n\nReviewed-by: Kieran Bingham \n\n> ---\n> include/libcamera/controls.h | 10 ++++++++++\n> src/libcamera/controls.cpp | 6 ++++++\n> 2 files changed, 16 insertions(+)\n> \n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index d70a6bc4b83a..f99c90e934c1 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -335,6 +335,16 @@ public:\n> \t\tval->set(value);\n> \t}\n> \n> +\ttemplate\n> +\tvoid set(const Control &ctrl, const std::initializer_list &value)\n> +\t{\n> +\t\tControlValue *val = find(ctrl.id());\n> +\t\tif (!val)\n> +\t\t\treturn;\n> +\n> +\t\tval->set(Span>{ value.begin(), value.size() });\n> +\t}\n> +\n> \tconst ControlValue &get(unsigned int id) const;\n> \tvoid set(unsigned int id, const ControlValue &value);\n> \n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index f4089c8ffb4e..829eea6f4240 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -806,6 +806,12 @@ bool ControlList::contains(unsigned int id) const\n> * object that the list refers to.\n> */\n> \n> +/**\n> + * \\fn template \\\n> + * void ControlList::set(const Control &ctrl, const std::initializer_list &value)\n> + * \\copydoc ControlList::set(const Control &ctrl, const V &value)\n> + */\n> +\n> /**\n> * \\brief Get the value of control \\a id\n> * \\param[in] id The control numerical ID\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A54C26279B\n\tfor ;\n\tTue, 3 Mar 2020 01:30:36 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 258579D0;\n\tTue, 3 Mar 2020 01:30:36 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583195436;\n\tbh=yJhAPNhLPsLdrj8lmucQWAgC3Gx75vIWuDBErWOm8J8=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=exP419ng+irev5ctopTQbWN5w8wu3JR8cTmGx8Un94/HncO9CjaSuJkRJTNjMmGge\n\tysCWCGQBgQhbMBZQsrzUWXSyhoa6jkP+nd4hRjglhah0LptHrIlMbJt8r5UPN0b+dF\n\thXSUDdCYf4LAIlPOaubQDJR6uPcsMjQdhRQSQ4G8=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200229164254.23604-1-laurent.pinchart@ideasonboard.com>\n\t<20200229164254.23604-18-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<328752e9-8a80-1867-ca21-54a9042c0cc7@ideasonboard.com>","Date":"Tue, 3 Mar 2020 00:30:28 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200229164254.23604-18-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 17/31] libcamera: controls: Allow\n\tpassing an std::initializer list to set()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 03 Mar 2020 00:30:36 -0000"}},{"id":3927,"web_url":"https://patchwork.libcamera.org/comment/3927/","msgid":"<20200303180714.GG11333@pendragon.ideasonboard.com>","date":"2020-03-03T18:07:14","subject":"Re: [libcamera-devel] [PATCH 17/31] libcamera: controls: Allow\n\tpassing an std::initializer list to set()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Tue, Mar 03, 2020 at 12:30:28AM +0000, Kieran Bingham wrote:\n> On 29/02/2020 16:42, Laurent Pinchart wrote:\n> > For array controls, the ControlList::set() function takes a value as a\n> > type convertible to Span. This allows passing an std::array or an\n> > std::vector in addition to an explicit Span, but doesn't accept an\n> > std::initializer list as Span has no constructor that takes an\n> > initializer list. Callers are thus forced to create temporary objects\n> > explicitly, which isn't nice.\n> > \n> > Fix the issue by providing a ControlList::set() function that takes an\n> > std::initializer_list, and convert it to a Span internally.\n> > \n> > Signed-off-by: Laurent Pinchart \n> \n> Aha, nice - so this is how we then get to 'create' controls like\n> Control{1,2,3,4} or such ?\n\nThis is how we can do\n\n\tControlList &list = ...;\n\n\tlist.set(controls::BayerGains, { 1.0, 1.1, 1.2, 1.0 });\n\n> Reviewed-by: Kieran Bingham \n> \n> > ---\n> > include/libcamera/controls.h | 10 ++++++++++\n> > src/libcamera/controls.cpp | 6 ++++++\n> > 2 files changed, 16 insertions(+)\n> > \n> > diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> > index d70a6bc4b83a..f99c90e934c1 100644\n> > --- a/include/libcamera/controls.h\n> > +++ b/include/libcamera/controls.h\n> > @@ -335,6 +335,16 @@ public:\n> > \t\tval->set(value);\n> > \t}\n> > \n> > +\ttemplate\n> > +\tvoid set(const Control &ctrl, const std::initializer_list &value)\n> > +\t{\n> > +\t\tControlValue *val = find(ctrl.id());\n> > +\t\tif (!val)\n> > +\t\t\treturn;\n> > +\n> > +\t\tval->set(Span>{ value.begin(), value.size() });\n> > +\t}\n> > +\n> > \tconst ControlValue &get(unsigned int id) const;\n> > \tvoid set(unsigned int id, const ControlValue &value);\n> > \n> > diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> > index f4089c8ffb4e..829eea6f4240 100644\n> > --- a/src/libcamera/controls.cpp\n> > +++ b/src/libcamera/controls.cpp\n> > @@ -806,6 +806,12 @@ bool ControlList::contains(unsigned int id) const\n> > * object that the list refers to.\n> > */\n> > \n> > +/**\n> > + * \\fn template \\\n> > + * void ControlList::set(const Control &ctrl, const std::initializer_list &value)\n> > + * \\copydoc ControlList::set(const Control &ctrl, const V &value)\n> > + */\n> > +\n> > /**\n> > * \\brief Get the value of control \\a id\n> > * \\param[in] id The control numerical ID","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 35439627AD\n\tfor ;\n\tTue, 3 Mar 2020 19:07:36 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9C8B02AF;\n\tTue, 3 Mar 2020 19:07:35 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583258855;\n\tbh=pfYpCruHd2I0gMnVoqwVJ5+neZHSnDQ3ChEl4tlOjwA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WNIPWZ+BjekTqw9x6UZBp3UH0Y4HgNBFW/mu0ZCFlYD8Gvyn7wdOs4w+oR9168jDZ\n\tjJVeEdFBfuag2t0mOHm8n8E6g+4YVpqsx2TN2uGgUUrU/+FuAiB93FujXf6usGYdoA\n\t61SeZHSjSdPPYI7jghlA8F7k6YfwQhLSlYRIpspQ=","Date":"Tue, 3 Mar 2020 20:07:14 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200303180714.GG11333@pendragon.ideasonboard.com>","References":"<20200229164254.23604-1-laurent.pinchart@ideasonboard.com>\n\t<20200229164254.23604-18-laurent.pinchart@ideasonboard.com>\n\t<328752e9-8a80-1867-ca21-54a9042c0cc7@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<328752e9-8a80-1867-ca21-54a9042c0cc7@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 17/31] libcamera: controls: Allow\n\tpassing an std::initializer list to set()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 03 Mar 2020 18:07:36 -0000"}}]