[{"id":3914,"web_url":"https://patchwork.libcamera.org/comment/3914/","msgid":"<6a3d3e6e-e5a5-118e-5471-79a1ee5dc6bf@ideasonboard.com>","date":"2020-03-02T23:44:28","subject":"Re: [libcamera-devel] [PATCH 15/31] libcamera: controls: Expose raw\n\tdata in ControlValue","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 29/02/2020 16:42, Laurent Pinchart wrote:\n> Add a data() function to the ControlValue class to expose the raw data\n> stored by the class as a Span. This will be useful to\n> simplify the serialization of ControlValue instances.\n> \n> The size computation for the raw data is moved from the\n> ControlSerializer, which is updated accordingly to use the data()\n> function in order to access the size. Simplification of the\n> ControlSerializer will happen in a subsequent change.\n> \n\nNice, I think I see where this is going...\n\n\nReviewed-by: Kieran Bingham \n\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> include/libcamera/controls.h | 3 +++\n> src/libcamera/control_serializer.cpp | 13 +------------\n> src/libcamera/controls.cpp | 23 +++++++++++++++++++++++\n> 3 files changed, 27 insertions(+), 12 deletions(-)\n> \n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index 6f0ebf4f3ca5..4538be06af93 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -12,6 +12,8 @@\n> #include \n> #include \n> \n> +#include \n> +\n> namespace libcamera {\n> \n> class ControlValidator;\n> @@ -65,6 +67,7 @@ public:\n> \n> \tControlType type() const { return type_; }\n> \tbool isNone() const { return type_ == ControlTypeNone; }\n> +\tSpan data() const;\n> \n> \tstd::string toString() const;\n> \n> diff --git a/src/libcamera/control_serializer.cpp b/src/libcamera/control_serializer.cpp\n> index 803ac16c2456..2b66ab978f81 100644\n> --- a/src/libcamera/control_serializer.cpp\n> +++ b/src/libcamera/control_serializer.cpp\n> @@ -27,17 +27,6 @@ namespace libcamera {\n> \n> LOG_DEFINE_CATEGORY(Serializer)\n> \n> -namespace {\n> -\n> -static constexpr size_t ControlValueSize[] = {\n> -\t[ControlTypeNone]\t= 1,\n> -\t[ControlTypeBool]\t= sizeof(bool),\n> -\t[ControlTypeInteger32]\t= sizeof(int32_t),\n> -\t[ControlTypeInteger64]\t= sizeof(int64_t),\n> -};\n> -\n> -} /* namespace */\n> -\n> /**\n> * \\class ControlSerializer\n> * \\brief Serializer and deserializer for control-related classes\n> @@ -106,7 +95,7 @@ void ControlSerializer::reset()\n> \n> size_t ControlSerializer::binarySize(const ControlValue &value)\n> {\n> -\treturn ControlValueSize[value.type()];\n> +\treturn value.data().size_bytes();\n> }\n> \n> size_t ControlSerializer::binarySize(const ControlRange &range)\n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index 76230a052de1..b2331ab7540d 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -47,6 +47,17 @@ namespace libcamera {\n> \n> LOG_DEFINE_CATEGORY(Controls)\n> \n> +namespace {\n> +\n> +static constexpr size_t ControlValueSize[] = {\n> +\t[ControlTypeNone]\t\t= 1,\n> +\t[ControlTypeBool]\t\t= sizeof(bool),\n> +\t[ControlTypeInteger32]\t\t= sizeof(int32_t),\n> +\t[ControlTypeInteger64]\t\t= sizeof(int64_t),\n> +};\n> +\n> +} /* namespace */\n> +\n> /**\n> * \\enum ControlType\n> * \\brief Define the data type of a Control\n> @@ -91,6 +102,18 @@ ControlValue::ControlValue()\n> * \\return True if the value type is ControlTypeNone, false otherwise\n> */\n> \n> +/**\n> + * \\brief Retrieve the raw of a control value\n\nRetrieve the raw '{data, bytes}' of a control value?\n\n> + * \\return The raw data of the control value as a span of uint8_t\n> + */\n> +Span ControlValue::data() const\n> +{\n> +\treturn {\n> +\t\treinterpret_cast(&bool_),\n> +\t\tControlValueSize[type_]\n> +\t};\n\nEeep, that starts looking like some sort of lambda/function/scope syntax\ndue to the { }; positions ...\n\n\n> +}\n> +\n> /**\n> * \\brief Assemble and return a string describing the value\n> * \\return A string describing the ControlValue\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8692E6279B\n\tfor ;\n\tTue, 3 Mar 2020 00:44:33 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F0EBB9D0;\n\tTue, 3 Mar 2020 00:44:32 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583192673;\n\tbh=viEh6FTnZuMaOCYsBtWkmQYPwebJzAAaM3czCrYcbfo=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=iMwtxOXFHznaPypwC/YhF536Lr0Mzk5mFuxnFfgvgB9P3iWCZN7ypS803AECZ4Lc6\n\thI0MSnzJIt4yGRol7vvWm8nA4XFrIjKIKlGawERH6/xDHApHxlAtZL7ai45GcLa34E\n\tWWTqyzcAYyoMU9OMIy4x/OkevVlBEBDeh+8nHJOM=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200229164254.23604-1-laurent.pinchart@ideasonboard.com>\n\t<20200229164254.23604-16-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<6a3d3e6e-e5a5-118e-5471-79a1ee5dc6bf@ideasonboard.com>","Date":"Mon, 2 Mar 2020 23:44:28 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200229164254.23604-16-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 15/31] libcamera: controls: Expose raw\n\tdata in ControlValue","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 02 Mar 2020 23:44:33 -0000"}}]