[{"id":3904,"web_url":"https://patchwork.libcamera.org/comment/3904/","msgid":"<74e5c12a-c47a-c0ac-bff4-18847c7641a3@ideasonboard.com>","date":"2020-03-02T22:49:01","subject":"Re: [libcamera-devel] [PATCH 06/31] libcamera: ipa: Test control\n\tstructure size with static_assert","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 29/02/2020 16:42, Laurent Pinchart wrote:\n> The control-related structures ipa_controls_header,\n> ipa_control_value_entry and ipa_control_range_entry define the IPA\n> protocol and are thus part of the ABI. To avoid breaking it\n> inadvertently, use static_assert() to check the size of the structures.\n> \n> Signed-off-by: Laurent Pinchart \n\nSome suggestions but otherwise...\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/ipa_controls.cpp | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> diff --git a/src/libcamera/ipa_controls.cpp b/src/libcamera/ipa_controls.cpp\n> index dd3ff9a0d467..25f38bab3dd9 100644\n> --- a/src/libcamera/ipa_controls.cpp\n> +++ b/src/libcamera/ipa_controls.cpp\n> @@ -153,6 +153,9 @@\n> * Reserved for future extensions\n> */\n> \n> +static_assert(sizeof(ipa_controls_header) == 32,\n> +\t \"Invalid size for struct ipa_control_header\");\n> +\n\nI think this could be better worded to be more helpful in the event that\nit is changed:\n\n\"Invalid ABI size change for struct ....\"\n\n> /**\n> * \\struct ipa_control_value_entry\n> * \\brief Description of a serialized ControlValue entry\n> @@ -167,6 +170,9 @@\n> * value data (shall be a multiple of 8 bytes).\n> */\n> \n> +static_assert(sizeof(ipa_control_value_entry) == 16,\n> +\t \"Invalid size for struct ipa_control_value_entry\");\n> +\n> /**\n> * \\struct ipa_control_range_entry\n> * \\brief Description of a serialized ControlRange entry\n> @@ -180,3 +186,6 @@\n> * \\var ipa_control_range_entry::padding\n> * Padding bytes (shall be set to 0)\n> */\n> +\n> +static_assert(sizeof(ipa_control_range_entry) == 16,\n> +\t \"Invalid size for struct ipa_control_range_entry\");\n> \n\n\nIf we're going to do lots of validating of structure sizes with a\nrepeatable message, perhaps it warrants a macro:\n\nASSERT_ABI_SIZE(struct ipa_controls_header, 32);\nASSERT_ABI_SIZE(struct ipa_control_value_entry, 16);\nASSERT_ABI_SIZE(struct ipa_control_range_entry, 16);","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9DBDD627B6\n\tfor ;\n\tMon, 2 Mar 2020 23:49:04 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 01E5F9D0;\n\tMon, 2 Mar 2020 23:49:03 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583189344;\n\tbh=dQbZRvBygpv5P4Ktw9hW41tuD/hLl4/VgbR8xBEVP6k=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=bMA74PAcWGowWutTm501uXO6CJwprklMrUa8r9FTpYZFUtz4moTZNMWKabs4s/Joj\n\tofGXbO1htedrZwzsJT8bp1yBIxm+1BWPILUaBONIFMekhsLgusVFTw+I2xAcDepNKc\n\tY7PY7oLi/qBgSRvBjLiZntK2ZzJ/RDvXtWJZDg4o=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200229164254.23604-1-laurent.pinchart@ideasonboard.com>\n\t<20200229164254.23604-7-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<74e5c12a-c47a-c0ac-bff4-18847c7641a3@ideasonboard.com>","Date":"Mon, 2 Mar 2020 22:49:01 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200229164254.23604-7-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 06/31] libcamera: ipa: Test control\n\tstructure size with static_assert","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 02 Mar 2020 22:49:04 -0000"}},{"id":3923,"web_url":"https://patchwork.libcamera.org/comment/3923/","msgid":"<20200303174853.GC11333@pendragon.ideasonboard.com>","date":"2020-03-03T17:48:53","subject":"Re: [libcamera-devel] [PATCH 06/31] libcamera: ipa: Test control\n\tstructure size with static_assert","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Mon, Mar 02, 2020 at 10:49:01PM +0000, Kieran Bingham wrote:\n> On 29/02/2020 16:42, Laurent Pinchart wrote:\n> > The control-related structures ipa_controls_header,\n> > ipa_control_value_entry and ipa_control_range_entry define the IPA\n> > protocol and are thus part of the ABI. To avoid breaking it\n> > inadvertently, use static_assert() to check the size of the structures.\n> > \n> > Signed-off-by: Laurent Pinchart \n> \n> Some suggestions but otherwise...\n> \n> Reviewed-by: Kieran Bingham \n> \n> > ---\n> > src/libcamera/ipa_controls.cpp | 9 +++++++++\n> > 1 file changed, 9 insertions(+)\n> > \n> > diff --git a/src/libcamera/ipa_controls.cpp b/src/libcamera/ipa_controls.cpp\n> > index dd3ff9a0d467..25f38bab3dd9 100644\n> > --- a/src/libcamera/ipa_controls.cpp\n> > +++ b/src/libcamera/ipa_controls.cpp\n> > @@ -153,6 +153,9 @@\n> > * Reserved for future extensions\n> > */\n> > \n> > +static_assert(sizeof(ipa_controls_header) == 32,\n> > +\t \"Invalid size for struct ipa_control_header\");\n> > +\n> \n> I think this could be better worded to be more helpful in the event that\n> it is changed:\n> \n> \"Invalid ABI size change for struct ....\"\n> \n> > /**\n> > * \\struct ipa_control_value_entry\n> > * \\brief Description of a serialized ControlValue entry\n> > @@ -167,6 +170,9 @@\n> > * value data (shall be a multiple of 8 bytes).\n> > */\n> > \n> > +static_assert(sizeof(ipa_control_value_entry) == 16,\n> > +\t \"Invalid size for struct ipa_control_value_entry\");\n> > +\n> > /**\n> > * \\struct ipa_control_range_entry\n> > * \\brief Description of a serialized ControlRange entry\n> > @@ -180,3 +186,6 @@\n> > * \\var ipa_control_range_entry::padding\n> > * Padding bytes (shall be set to 0)\n> > */\n> > +\n> > +static_assert(sizeof(ipa_control_range_entry) == 16,\n> > +\t \"Invalid size for struct ipa_control_range_entry\");\n> > \n> \n> \n> If we're going to do lots of validating of structure sizes with a\n> repeatable message, perhaps it warrants a macro:\n> \n> ASSERT_ABI_SIZE(struct ipa_controls_header, 32);\n> ASSERT_ABI_SIZE(struct ipa_control_value_entry, 16);\n> ASSERT_ABI_SIZE(struct ipa_control_range_entry, 16);\n\nIt's a good idea, but we will also likely need to statically assert that\nthe offset of indidivual fields doesn't change, so I think more thoughts\nare required on how to create such macros.","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 60F11627AD\n\tfor ;\n\tTue, 3 Mar 2020 18:49:15 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CB69F2AF;\n\tTue, 3 Mar 2020 18:49:14 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583257755;\n\tbh=S9DmMP0nUn1n9Mz+iENVpA0Ah6t2tdVHyG1Mxe/U0gA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=uG7zZr6gfsbjrZguIjNMyxBtTdp0U7Lj15KDBW7Z1nu+8ioxUn/uEBhTJlys+pnyL\n\tvH08xHEK2zpEmrXf/YDQi1TV/cC1O312Zf18Fr40MI1/5LoTnBH6ht/R2+vnf0NHvl\n\tA0/d6JRyRGP+1FPfQbKqqGXYdwYm472LtzwEPdlA=","Date":"Tue, 3 Mar 2020 19:48:53 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200303174853.GC11333@pendragon.ideasonboard.com>","References":"<20200229164254.23604-1-laurent.pinchart@ideasonboard.com>\n\t<20200229164254.23604-7-laurent.pinchart@ideasonboard.com>\n\t<74e5c12a-c47a-c0ac-bff4-18847c7641a3@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<74e5c12a-c47a-c0ac-bff4-18847c7641a3@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 06/31] libcamera: ipa: Test control\n\tstructure size with static_assert","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 03 Mar 2020 17:49:15 -0000"}},{"id":3936,"web_url":"https://patchwork.libcamera.org/comment/3936/","msgid":"","date":"2020-03-05T09:50:57","subject":"Re: [libcamera-devel] [PATCH 06/31] libcamera: ipa: Test control\n\tstructure size with static_assert","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 03/03/2020 17:48, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> On Mon, Mar 02, 2020 at 10:49:01PM +0000, Kieran Bingham wrote:\n>> On 29/02/2020 16:42, Laurent Pinchart wrote:\n>>> The control-related structures ipa_controls_header,\n>>> ipa_control_value_entry and ipa_control_range_entry define the IPA\n>>> protocol and are thus part of the ABI. To avoid breaking it\n>>> inadvertently, use static_assert() to check the size of the structures.\n>>>\n>>> Signed-off-by: Laurent Pinchart \n>>\n>> Some suggestions but otherwise...\n>>\n>> Reviewed-by: Kieran Bingham \n>>\n>>> ---\n>>> src/libcamera/ipa_controls.cpp | 9 +++++++++\n>>> 1 file changed, 9 insertions(+)\n>>>\n>>> diff --git a/src/libcamera/ipa_controls.cpp b/src/libcamera/ipa_controls.cpp\n>>> index dd3ff9a0d467..25f38bab3dd9 100644\n>>> --- a/src/libcamera/ipa_controls.cpp\n>>> +++ b/src/libcamera/ipa_controls.cpp\n>>> @@ -153,6 +153,9 @@\n>>> * Reserved for future extensions\n>>> */\n>>> \n>>> +static_assert(sizeof(ipa_controls_header) == 32,\n>>> +\t \"Invalid size for struct ipa_control_header\");\n>>> +\n>>\n>> I think this could be better worded to be more helpful in the event that\n>> it is changed:\n>>\n>> \"Invalid ABI size change for struct ....\"\n>>\n>>> /**\n>>> * \\struct ipa_control_value_entry\n>>> * \\brief Description of a serialized ControlValue entry\n>>> @@ -167,6 +170,9 @@\n>>> * value data (shall be a multiple of 8 bytes).\n>>> */\n>>> \n>>> +static_assert(sizeof(ipa_control_value_entry) == 16,\n>>> +\t \"Invalid size for struct ipa_control_value_entry\");\n>>> +\n>>> /**\n>>> * \\struct ipa_control_range_entry\n>>> * \\brief Description of a serialized ControlRange entry\n>>> @@ -180,3 +186,6 @@\n>>> * \\var ipa_control_range_entry::padding\n>>> * Padding bytes (shall be set to 0)\n>>> */\n>>> +\n>>> +static_assert(sizeof(ipa_control_range_entry) == 16,\n>>> +\t \"Invalid size for struct ipa_control_range_entry\");\n>>>\n>>\n>>\n>> If we're going to do lots of validating of structure sizes with a\n>> repeatable message, perhaps it warrants a macro:\n>>\n>> ASSERT_ABI_SIZE(struct ipa_controls_header, 32);\n>> ASSERT_ABI_SIZE(struct ipa_control_value_entry, 16);\n>> ASSERT_ABI_SIZE(struct ipa_control_range_entry, 16);\n> \n> It's a good idea, but we will also likely need to statically assert that\n> the offset of indidivual fields doesn't change, so I think more thoughts\n> are required on how to create such macros.\n\nWell that will then become:\n\nASSERT_ABI_OFFSET(s, m, o)\n\nI still think macroising will simplify things.","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D128660424\n\tfor ;\n\tThu, 5 Mar 2020 10:51:01 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2B3A933E;\n\tThu, 5 Mar 2020 10:51:01 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583401861;\n\tbh=+P0nDMXMUl7tfoufjN2rAJFqz/wcpVcEtj7xvpIgLPc=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=svRNELVWpZy8T+KB+JIwxBwr2ved5v34LlFNp+SYLVG0CatJ2NODIgZzGY3eOTL/9\n\tTbCB4tsH/2/HtmDKvAxCKx7OuFWV/xjZo9L5iUDyYipWmSdsNMGgknRwhhmOHOg7Pa\n\tEqua3CDFqgXr2auj/IWlaeEJZdmh8YB69jRKHebU=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20200229164254.23604-1-laurent.pinchart@ideasonboard.com>\n\t<20200229164254.23604-7-laurent.pinchart@ideasonboard.com>\n\t<74e5c12a-c47a-c0ac-bff4-18847c7641a3@ideasonboard.com>\n\t<20200303174853.GC11333@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 5 Mar 2020 09:50:57 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200303174853.GC11333@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 06/31] libcamera: ipa: Test control\n\tstructure size with static_assert","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 05 Mar 2020 09:51:02 -0000"}},{"id":3937,"web_url":"https://patchwork.libcamera.org/comment/3937/","msgid":"<20200305103756.GB4722@pendragon.ideasonboard.com>","date":"2020-03-05T10:37:56","subject":"Re: [libcamera-devel] [PATCH 06/31] libcamera: ipa: Test control\n\tstructure size with static_assert","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Thu, Mar 05, 2020 at 09:50:57AM +0000, Kieran Bingham wrote:\n> On 03/03/2020 17:48, Laurent Pinchart wrote:\n> > On Mon, Mar 02, 2020 at 10:49:01PM +0000, Kieran Bingham wrote:\n> >> On 29/02/2020 16:42, Laurent Pinchart wrote:\n> >>> The control-related structures ipa_controls_header,\n> >>> ipa_control_value_entry and ipa_control_range_entry define the IPA\n> >>> protocol and are thus part of the ABI. To avoid breaking it\n> >>> inadvertently, use static_assert() to check the size of the structures.\n> >>>\n> >>> Signed-off-by: Laurent Pinchart \n> >>\n> >> Some suggestions but otherwise...\n> >>\n> >> Reviewed-by: Kieran Bingham \n> >>\n> >>> ---\n> >>> src/libcamera/ipa_controls.cpp | 9 +++++++++\n> >>> 1 file changed, 9 insertions(+)\n> >>>\n> >>> diff --git a/src/libcamera/ipa_controls.cpp b/src/libcamera/ipa_controls.cpp\n> >>> index dd3ff9a0d467..25f38bab3dd9 100644\n> >>> --- a/src/libcamera/ipa_controls.cpp\n> >>> +++ b/src/libcamera/ipa_controls.cpp\n> >>> @@ -153,6 +153,9 @@\n> >>> * Reserved for future extensions\n> >>> */\n> >>> \n> >>> +static_assert(sizeof(ipa_controls_header) == 32,\n> >>> +\t \"Invalid size for struct ipa_control_header\");\n> >>> +\n> >>\n> >> I think this could be better worded to be more helpful in the event that\n> >> it is changed:\n> >>\n> >> \"Invalid ABI size change for struct ....\"\n> >>\n> >>> /**\n> >>> * \\struct ipa_control_value_entry\n> >>> * \\brief Description of a serialized ControlValue entry\n> >>> @@ -167,6 +170,9 @@\n> >>> * value data (shall be a multiple of 8 bytes).\n> >>> */\n> >>> \n> >>> +static_assert(sizeof(ipa_control_value_entry) == 16,\n> >>> +\t \"Invalid size for struct ipa_control_value_entry\");\n> >>> +\n> >>> /**\n> >>> * \\struct ipa_control_range_entry\n> >>> * \\brief Description of a serialized ControlRange entry\n> >>> @@ -180,3 +186,6 @@\n> >>> * \\var ipa_control_range_entry::padding\n> >>> * Padding bytes (shall be set to 0)\n> >>> */\n> >>> +\n> >>> +static_assert(sizeof(ipa_control_range_entry) == 16,\n> >>> +\t \"Invalid size for struct ipa_control_range_entry\");\n> >>>\n> >>\n> >>\n> >> If we're going to do lots of validating of structure sizes with a\n> >> repeatable message, perhaps it warrants a macro:\n> >>\n> >> ASSERT_ABI_SIZE(struct ipa_controls_header, 32);\n> >> ASSERT_ABI_SIZE(struct ipa_control_value_entry, 16);\n> >> ASSERT_ABI_SIZE(struct ipa_control_range_entry, 16);\n> > \n> > It's a good idea, but we will also likely need to statically assert that\n> > the offset of indidivual fields doesn't change, so I think more thoughts\n> > are required on how to create such macros.\n> \n> Well that will then become:\n> \n> ASSERT_ABI_OFFSET(s, m, o)\n> \n> I still think macroising will simplify things.\n\nI have no objection. As part of this patch, or on top of it ?","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB16A60424\n\tfor ;\n\tThu, 5 Mar 2020 11:37:58 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 580F333E;\n\tThu, 5 Mar 2020 11:37:58 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583404678;\n\tbh=u1eUd8VgG8vmpmspTmJ+ApjC78lsH+3zgzZIbQdazQs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FU6jjwPN0F3zplY84pg4OHmpIgV3nnBTMOnakkR0vGAjqzKHwC0iRouYcvFkEe551\n\tHYLl+RmFTF8dyVC8k6s+HxXpa1/Pm7vnX/wwXc7KS6PmyeWcvUWR0vXgDj2Q0nQ0jc\n\thS/GeyBNWiVZbLzxwz7CXJp1QqbiHj2NrMnAsATc=","Date":"Thu, 5 Mar 2020 12:37:56 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200305103756.GB4722@pendragon.ideasonboard.com>","References":"<20200229164254.23604-1-laurent.pinchart@ideasonboard.com>\n\t<20200229164254.23604-7-laurent.pinchart@ideasonboard.com>\n\t<74e5c12a-c47a-c0ac-bff4-18847c7641a3@ideasonboard.com>\n\t<20200303174853.GC11333@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 06/31] libcamera: ipa: Test control\n\tstructure size with static_assert","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 05 Mar 2020 10:37:59 -0000"}},{"id":3944,"web_url":"https://patchwork.libcamera.org/comment/3944/","msgid":"<64e63a21-2e5e-6e89-9ca6-4f37d02b51e5@ideasonboard.com>","date":"2020-03-05T17:09:52","subject":"Re: [libcamera-devel] [PATCH 06/31] libcamera: ipa: Test control\n\tstructure size with static_assert","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 05/03/2020 10:37, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> On Thu, Mar 05, 2020 at 09:50:57AM +0000, Kieran Bingham wrote:\n>> On 03/03/2020 17:48, Laurent Pinchart wrote:\n>>> On Mon, Mar 02, 2020 at 10:49:01PM +0000, Kieran Bingham wrote:\n>>>> On 29/02/2020 16:42, Laurent Pinchart wrote:\n>>>>> The control-related structures ipa_controls_header,\n>>>>> ipa_control_value_entry and ipa_control_range_entry define the IPA\n>>>>> protocol and are thus part of the ABI. To avoid breaking it\n>>>>> inadvertently, use static_assert() to check the size of the structures.\n>>>>>\n>>>>> Signed-off-by: Laurent Pinchart \n>>>>\n>>>> Some suggestions but otherwise...\n>>>>\n>>>> Reviewed-by: Kieran Bingham \n>>>>\n>>>>> ---\n>>>>> src/libcamera/ipa_controls.cpp | 9 +++++++++\n>>>>> 1 file changed, 9 insertions(+)\n>>>>>\n>>>>> diff --git a/src/libcamera/ipa_controls.cpp b/src/libcamera/ipa_controls.cpp\n>>>>> index dd3ff9a0d467..25f38bab3dd9 100644\n>>>>> --- a/src/libcamera/ipa_controls.cpp\n>>>>> +++ b/src/libcamera/ipa_controls.cpp\n>>>>> @@ -153,6 +153,9 @@\n>>>>> * Reserved for future extensions\n>>>>> */\n>>>>> \n>>>>> +static_assert(sizeof(ipa_controls_header) == 32,\n>>>>> +\t \"Invalid size for struct ipa_control_header\");\n>>>>> +\n>>>>\n>>>> I think this could be better worded to be more helpful in the event that\n>>>> it is changed:\n>>>>\n>>>> \"Invalid ABI size change for struct ....\"\n>>>>\n>>>>> /**\n>>>>> * \\struct ipa_control_value_entry\n>>>>> * \\brief Description of a serialized ControlValue entry\n>>>>> @@ -167,6 +170,9 @@\n>>>>> * value data (shall be a multiple of 8 bytes).\n>>>>> */\n>>>>> \n>>>>> +static_assert(sizeof(ipa_control_value_entry) == 16,\n>>>>> +\t \"Invalid size for struct ipa_control_value_entry\");\n>>>>> +\n>>>>> /**\n>>>>> * \\struct ipa_control_range_entry\n>>>>> * \\brief Description of a serialized ControlRange entry\n>>>>> @@ -180,3 +186,6 @@\n>>>>> * \\var ipa_control_range_entry::padding\n>>>>> * Padding bytes (shall be set to 0)\n>>>>> */\n>>>>> +\n>>>>> +static_assert(sizeof(ipa_control_range_entry) == 16,\n>>>>> +\t \"Invalid size for struct ipa_control_range_entry\");\n>>>>>\n>>>>\n>>>>\n>>>> If we're going to do lots of validating of structure sizes with a\n>>>> repeatable message, perhaps it warrants a macro:\n>>>>\n>>>> ASSERT_ABI_SIZE(struct ipa_controls_header, 32);\n>>>> ASSERT_ABI_SIZE(struct ipa_control_value_entry, 16);\n>>>> ASSERT_ABI_SIZE(struct ipa_control_range_entry, 16);\n>>>\n>>> It's a good idea, but we will also likely need to statically assert that\n>>> the offset of indidivual fields doesn't change, so I think more thoughts\n>>> are required on how to create such macros.\n>>\n>> Well that will then become:\n>>\n>> ASSERT_ABI_OFFSET(s, m, o)\n>>\n>> I still think macroising will simplify things.\n> \n> I have no objection. As part of this patch, or on top of it ?\n\nDepends on whether this series gets respun or not. I don't think there's\nmuch major coming out of the review, but there are a few small things.\n\nIt can change on top if you prefer, and indeed the _OFFSET could be on\ntop anyway, unless you want to trap all the current offsets now.\n\nI wonder if there's a way to automate this too ... (which can certainly\nbe later).","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7515960427\n\tfor ;\n\tThu, 5 Mar 2020 18:09:58 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E091D312;\n\tThu, 5 Mar 2020 18:09:57 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1583428198;\n\tbh=7Dl+h3ZTCjPWD0X2HlSGqEC57N0S2srHRSVRr9Cb1DM=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=VI+TN2YsG8qaYOE1Vn9TJY8tvX9TZ19MLRfcsWuZ3533D2TAABo2XFy9IbuJVNWPF\n\tO4xdqOZ/r5wGH4fEz9gz+W327Hb3im9VyXRlHBbu8RazGcmk9eZpoBVsGRePKjT6Ow\n\tXlDpmt3S7mkxZO4PVIbZ+W3eTDABcYcQgcbxIlhI=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20200229164254.23604-1-laurent.pinchart@ideasonboard.com>\n\t<20200229164254.23604-7-laurent.pinchart@ideasonboard.com>\n\t<74e5c12a-c47a-c0ac-bff4-18847c7641a3@ideasonboard.com>\n\t<20200303174853.GC11333@pendragon.ideasonboard.com>\n\t\n\t<20200305103756.GB4722@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<64e63a21-2e5e-6e89-9ca6-4f37d02b51e5@ideasonboard.com>","Date":"Thu, 5 Mar 2020 17:09:52 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.1","MIME-Version":"1.0","In-Reply-To":"<20200305103756.GB4722@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 06/31] libcamera: ipa: Test control\n\tstructure size with static_assert","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 05 Mar 2020 17:09:58 -0000"}}]