[{"id":3878,"web_url":"https://patchwork.libcamera.org/comment/3878/","msgid":"<20200229151243.GY18738@pendragon.ideasonboard.com>","date":"2020-02-29T15:12:43","subject":"Re: [libcamera-devel] [PATCH v2 27/27] gst: Reduce GStreamer\n\trequirement to 1.14","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nicolas,\n\nThank you for the patch.\n\nOn Thu, Feb 27, 2020 at 03:04:07PM -0500, Nicolas Dufresne wrote:\n> This has been tested to build and run on 1.14, except for the device monitor.\n> Mostly, all device monitors that are non-monitoring have been broken for a long\n> time.\n\nDoes that mean we'll need v1.16 when we'll implement hotplug support, or\nthat it will work fine on v1.14 ?\n\n> Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nYou may even want to squash this in patch 01/27.\n\n> ---\n>  src/gstreamer/meson.build | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/gstreamer/meson.build b/src/gstreamer/meson.build\n> index 90773af..269b8b6 100644\n> --- a/src/gstreamer/meson.build\n> +++ b/src/gstreamer/meson.build\n> @@ -13,7 +13,7 @@ libcamera_gst_c_args = [\n>      '-DPACKAGE=\"@0@\"'.format(meson.project_name()),\n>  ]\n>  \n> -gst_req = '>=1.16.1'\n> +gst_req = '>=1.14.0'\n>  gstvideo_dep = dependency('gstreamer-video-1.0', version : gst_req,\n>                            required : get_option('gstreamer'))\n>  gstallocator_dep = dependency('gstreamer-allocators-1.0', version : gst_req,","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3833262689\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 29 Feb 2020 16:13:07 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BF48233E;\n\tSat, 29 Feb 2020 16:13:06 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1582989186;\n\tbh=R8hsbiyS4LiKlEcCcTMUGLqkwv5lANs3050HtYDJTbU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pjRoE3QggiKO/RC9yZTqVXzHZxgzSnAaStv8cxuQbbsQiG3KVvL4znaCs7VlXk/Yv\n\tT5BX+cYkJvaBgLB346o1MwZfGK6OxZz6QVmiL0LWur8nHC1TNf0G1cjpDxaqZcGv9b\n\tmDVDcxBJSPObiwYpzdvC19LG8GR0M8VQO/fu8G7k=","Date":"Sat, 29 Feb 2020 17:12:43 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Nicolas Dufresne <nicolas.dufresne@collabora.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200229151243.GY18738@pendragon.ideasonboard.com>","References":"<20200227200407.490616-1-nicolas.dufresne@collabora.com>\n\t<20200227200407.490616-28-nicolas.dufresne@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200227200407.490616-28-nicolas.dufresne@collabora.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 27/27] gst: Reduce GStreamer\n\trequirement to 1.14","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sat, 29 Feb 2020 15:13:07 -0000"}},{"id":3886,"web_url":"https://patchwork.libcamera.org/comment/3886/","msgid":"<400c19dae93abdc63ad106842f2fd071dece6a02.camel@collabora.com>","date":"2020-02-29T15:38:45","subject":"Re: [libcamera-devel] [PATCH v2 27/27] gst: Reduce GStreamer\n\trequirement to 1.14","submitter":{"id":31,"url":"https://patchwork.libcamera.org/api/people/31/","name":"Nicolas Dufresne","email":"nicolas.dufresne@collabora.com"},"content":"Le samedi 29 février 2020 à 17:12 +0200, Laurent Pinchart a écrit :\n> Hi Nicolas,\n> \n> Thank you for the patch.\n> \n> On Thu, Feb 27, 2020 at 03:04:07PM -0500, Nicolas Dufresne wrote:\n> > This has been tested to build and run on 1.14, except for the device monitor.\n> > Mostly, all device monitors that are non-monitoring have been broken for a long\n> > time.\n> \n> Does that mean we'll need v1.16 when we'll implement hotplug support, or\n> that it will work fine on v1.14 ?\n\nThe situation for device probes is complicated. A dev messed in 1.15\nand backported that. Of course this was not covered by the CI. The\nregressions started in 1.14, and are broken differently in 1.16 (the\nfix for the regression broke other stuff). In theory it all worked in\n1.12. So I have no idea what will happen, but I'm tempted to ignore\nthis, it's GStreamer problem.\n\n> \n> > Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n> \n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> \n> You may even want to squash this in patch 01/27.\n\nOk.\n\n> \n> > ---\n> >  src/gstreamer/meson.build | 2 +-\n> >  1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/gstreamer/meson.build b/src/gstreamer/meson.build\n> > index 90773af..269b8b6 100644\n> > --- a/src/gstreamer/meson.build\n> > +++ b/src/gstreamer/meson.build\n> > @@ -13,7 +13,7 @@ libcamera_gst_c_args = [\n> >      '-DPACKAGE=\"@0@\"'.format(meson.project_name()),\n> >  ]\n> >  \n> > -gst_req = '>=1.16.1'\n> > +gst_req = '>=1.14.0'\n> >  gstvideo_dep = dependency('gstreamer-video-1.0', version : gst_req,\n> >                            required : get_option('gstreamer'))\n> >  gstallocator_dep = dependency('gstreamer-allocators-1.0', version : gst_req,","headers":{"Return-Path":"<nicolas.dufresne@collabora.com>","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 888D362689\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 29 Feb 2020 16:38:48 +0100 (CET)","from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: nicolas) with ESMTPSA id E956929328A"],"Message-ID":"<400c19dae93abdc63ad106842f2fd071dece6a02.camel@collabora.com>","From":"Nicolas Dufresne <nicolas.dufresne@collabora.com>","Reply-To":"Nicolas Dufresne <nicolas.dufresne@collabora.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Date":"Sat, 29 Feb 2020 10:38:45 -0500","In-Reply-To":"<20200229151243.GY18738@pendragon.ideasonboard.com>","References":"<20200227200407.490616-1-nicolas.dufresne@collabora.com>\n\t<20200227200407.490616-28-nicolas.dufresne@collabora.com>\n\t<20200229151243.GY18738@pendragon.ideasonboard.com>","Organization":"Collabora","Content-Type":"multipart/signed; micalg=\"pgp-sha1\";\n\tprotocol=\"application/pgp-signature\"; \n\tboundary=\"=-dv19EQhxOqZIx2hosFls\"","User-Agent":"Evolution 3.34.4 (3.34.4-1.fc31) ","MIME-Version":"1.0","Subject":"Re: [libcamera-devel] [PATCH v2 27/27] gst: Reduce GStreamer\n\trequirement to 1.14","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sat, 29 Feb 2020 15:38:48 -0000"}}]