{"id":2907,"url":"https://patchwork.libcamera.org/api/patches/2907/?format=json","web_url":"https://patchwork.libcamera.org/patch/2907/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200227200407.490616-26-nicolas.dufresne@collabora.com>","date":"2020-02-27T20:04:05","name":"[libcamera-devel,v2,25/27] gst: utils: Factor-out the task resume helper","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"555f368dfc68843bcc78f795e1321491ef2b5379","submitter":{"id":31,"url":"https://patchwork.libcamera.org/api/people/31/?format=json","name":"Nicolas Dufresne","email":"nicolas.dufresne@collabora.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2907/mbox/","series":[{"id":693,"url":"https://patchwork.libcamera.org/api/series/693/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=693","date":"2020-02-27T20:03:40","name":"GStreamer Element for libcamera","version":2,"mbox":"https://patchwork.libcamera.org/series/693/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2907/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2907/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EA5F962746\n\tfor ;\n\tThu, 27 Feb 2020 21:04:29 +0100 (CET)","from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: nicolas) with ESMTPSA id 59CB229654B"],"From":"Nicolas Dufresne ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jakub Adam ","Date":"Thu, 27 Feb 2020 15:04:05 -0500","Message-Id":"<20200227200407.490616-26-nicolas.dufresne@collabora.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200227200407.490616-1-nicolas.dufresne@collabora.com>","References":"<20200227200407.490616-1-nicolas.dufresne@collabora.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 25/27] gst: utils: Factor-out the task\n\tresume helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 27 Feb 2020 20:04:31 -0000"},"content":"From: Jakub Adam \n\nTask resume will be added in the core GStreamer API in the future and\nwe will need to call this in another location in the following patches.\n\nSigned-off-by: Jakub Adam \n---\n src/gstreamer/gstlibcamera-utils.cpp | 11 +++++++++++\n src/gstreamer/gstlibcamera-utils.h | 1 +\n src/gstreamer/gstlibcamerasrc.cpp | 10 +---------\n 3 files changed, 13 insertions(+), 9 deletions(-)","diff":"diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\nindex 231f3c5..11c2d56 100644\n--- a/src/gstreamer/gstlibcamera-utils.cpp\n+++ b/src/gstreamer/gstlibcamera-utils.cpp\n@@ -160,3 +160,14 @@ gst_libcamera_configure_stream_from_caps(StreamConfiguration &stream_cfg,\n \tstream_cfg.size.width = width;\n \tstream_cfg.size.height = height;\n }\n+\n+void\n+gst_libcamera_resume_task(GstTask *task)\n+{\n+\t/* We only want to resume the task if it's paused. */\n+\tGLibLocker lock(GST_OBJECT(task));\n+\tif (GST_TASK_STATE(task) == GST_TASK_PAUSED) {\n+\t\tGST_TASK_STATE(task) = GST_TASK_STARTED;\n+\t\tGST_TASK_SIGNAL(task);\n+\t}\n+}\ndiff --git a/src/gstreamer/gstlibcamera-utils.h b/src/gstreamer/gstlibcamera-utils.h\nindex 51898a0..440f196 100644\n--- a/src/gstreamer/gstlibcamera-utils.h\n+++ b/src/gstreamer/gstlibcamera-utils.h\n@@ -17,6 +17,7 @@ GstCaps *gst_libcamera_stream_formats_to_caps(const libcamera::StreamFormats &fo\n GstCaps *gst_libcamera_stream_configuration_to_caps(const libcamera::StreamConfiguration &stream_cfg);\n void gst_libcamera_configure_stream_from_caps(libcamera::StreamConfiguration &stream_cfg,\n \t\t\t\t\t GstCaps *caps);\n+void gst_libcamera_resume_task(GstTask *task);\n \n /**\n * \\class GLibLocker\ndiff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 1e55916..fe60584 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -193,15 +193,7 @@ GstLibcameraSrcState::requestCompleted(Request *request)\n \t\tgst_libcamera_pad_queue_buffer(srcpad, buffer);\n \t}\n \n-\t{\n-\t\t/* We only want to resume the task if it's paused. */\n-\t\tGstTask *task = this->src->task;\n-\t\tGLibLocker lock(GST_OBJECT(task));\n-\t\tif (GST_TASK_STATE(task) == GST_TASK_PAUSED) {\n-\t\t\tGST_TASK_STATE(task) = GST_TASK_STARTED;\n-\t\t\tGST_TASK_SIGNAL(task);\n-\t\t}\n-\t}\n+\tgst_libcamera_resume_task(this->src->task);\n }\n \n static bool\n","prefixes":["libcamera-devel","v2","25/27"]}