[{"id":3875,"web_url":"https://patchwork.libcamera.org/comment/3875/","msgid":"<20200229150110.GV18738@pendragon.ideasonboard.com>","date":"2020-02-29T15:01:10","subject":"Re: [libcamera-devel] [PATCH v2 24/27] gst: libcamerasrc: Add a\n\tTODO comment","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nicolas,\n\nThank you for the patch.\n\nOn Thu, Feb 27, 2020 at 03:04:04PM -0500, Nicolas Dufresne wrote:\n> This is to guide upcoming contributors toward what is left to do to get\n> toward a production ready element.\n> \n> Signed-off-by: Nicolas Dufresne \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/gstreamer/gstlibcamerasrc.cpp | 19 +++++++++++++++++++\n> 1 file changed, 19 insertions(+)\n> \n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index 73a1360..1e55916 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -7,6 +7,25 @@\n> */\n> \n> /**\n> + * \\todo The following is a list of items that needs implementation in the GStreamer plugin\n> + * - Implement GstElement::send_event\n> + * + Allowing application to send EOS\n> + * + Allowing application to use FLUSH/FLUSH_STOP\n> + * + Prevent the main thread from accessing streaming thread\n> + * - Implement renegotiation (even if slow)\n> + * - Implement GstElement::request-new-pad (multi stream)\n> + * + Evaluate if a single streaming thread is fine\n> + * - Add application driven request (snapshot)\n> + * - Add framerate control\n> + * - Add buffer importation support\n> + *\n> + * Requires new libcamera API:\n> + * - Add framerate negotiation support\n> + * - Add colorimetry support\n> + * - Add timestamp support\n> + * - Use unique names to select the camera devices\n> + * - Add GstVideoMeta support (strides and offsets)\n> + *\n> * \\todo libcamera UVC drivers picks the lowest possible resolution first, this\n> * should be fixed so that we get a decent resolution and framerate for the\n> * role by default.","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5962B62689\n\tfor ;\n\tSat, 29 Feb 2020 16:01:34 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DDE3733E;\n\tSat, 29 Feb 2020 16:01:33 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1582988494;\n\tbh=sRwgDioLCEUWGu9EJxH2zMvdSsF5edW+VZBLOOMrSa4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=kYglxYTn3dUWnqsAwvoqBlGeAs5gwxb6Y0YJCa4Tsux4uWT8aUT6Oi9l0HxJeZG6m\n\tKR1KYZALc8Zxx4MYY2Tb1BRr0qW8QkTn7iBvuSNcRDUN3Ui442EqtZogkuxu0uL0aD\n\tn98CZOou01w5lIZG12KhnRdcI9NNsEc2OzfJRrg0=","Date":"Sat, 29 Feb 2020 17:01:10 +0200","From":"Laurent Pinchart ","To":"Nicolas Dufresne ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200229150110.GV18738@pendragon.ideasonboard.com>","References":"<20200227200407.490616-1-nicolas.dufresne@collabora.com>\n\t<20200227200407.490616-25-nicolas.dufresne@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200227200407.490616-25-nicolas.dufresne@collabora.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 24/27] gst: libcamerasrc: Add a\n\tTODO comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 29 Feb 2020 15:01:34 -0000"}}]