{"id":2905,"url":"https://patchwork.libcamera.org/api/patches/2905/?format=json","web_url":"https://patchwork.libcamera.org/patch/2905/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200227200407.490616-24-nicolas.dufresne@collabora.com>","date":"2020-02-27T20:04:03","name":"[libcamera-devel,v2,23/27] gst: libcamerasrc: Implement timestamp support","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"047099e41903eeb25a018e28107c5383c271caf3","submitter":{"id":31,"url":"https://patchwork.libcamera.org/api/people/31/?format=json","name":"Nicolas Dufresne","email":"nicolas.dufresne@collabora.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2905/mbox/","series":[{"id":693,"url":"https://patchwork.libcamera.org/api/series/693/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=693","date":"2020-02-27T20:03:40","name":"GStreamer Element for libcamera","version":2,"mbox":"https://patchwork.libcamera.org/series/693/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2905/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2905/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E621E6273D\n\tfor ;\n\tThu, 27 Feb 2020 21:04:28 +0100 (CET)","from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: nicolas) with ESMTPSA id 71D1F2949DF"],"From":"Nicolas Dufresne ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 27 Feb 2020 15:04:03 -0500","Message-Id":"<20200227200407.490616-24-nicolas.dufresne@collabora.com>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200227200407.490616-1-nicolas.dufresne@collabora.com>","References":"<20200227200407.490616-1-nicolas.dufresne@collabora.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 23/27] gst: libcamerasrc: Implement\n\ttimestamp support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 27 Feb 2020 20:04:31 -0000"},"content":"This is an experimental patch adding timestamp support to the libcamerasrc\nelement. This patch currently assume that the driver timestamp are relative to\nthe system monotonic clock. Without a reference clock source, the timestamp are\notherwise unusable, and without timestamp only minor use case can be achieved.\n\nSigned-off-by: Nicolas Dufresne \n---\n src/gstreamer/gstlibcamerapad.cpp | 23 +++++++++++++++++++++++\n src/gstreamer/gstlibcamerapad.h | 2 ++\n src/gstreamer/gstlibcamerasrc.cpp | 20 ++++++++++++++++++++\n 3 files changed, 45 insertions(+)","diff":"diff --git a/src/gstreamer/gstlibcamerapad.cpp b/src/gstreamer/gstlibcamerapad.cpp\nindex 2cf1630..31d3edd 100644\n--- a/src/gstreamer/gstlibcamerapad.cpp\n+++ b/src/gstreamer/gstlibcamerapad.cpp\n@@ -62,9 +62,24 @@ gst_libcamera_pad_get_property(GObject *object, guint prop_id, GValue *value,\n \t}\n }\n \n+static gboolean\n+gst_libcamera_pad_query(GstPad *pad, GstObject *parent, GstQuery *query)\n+{\n+\tauto *self = GST_LIBCAMERA_PAD(pad);\n+\n+\tif (query->type != GST_QUERY_LATENCY)\n+\t\treturn gst_pad_query_default(pad, parent, query);\n+\n+\t/* TRUE here means live, we assumes that max latency is the same as min\n+\t * as we have no idea that duration of frames. */\n+\tgst_query_set_latency(query, TRUE, self->latency, self->latency);\n+\treturn TRUE;\n+}\n+\n static void\n gst_libcamera_pad_init(GstLibcameraPad *self)\n {\n+\tGST_PAD_QUERYFUNC(self) = gst_libcamera_pad_query;\n }\n \n static GType\n@@ -172,3 +187,11 @@ gst_libcamera_pad_has_pending(GstPad *pad)\n \tGLibLocker lock(GST_OBJECT(self));\n \treturn (self->pending_buffers.length > 0);\n }\n+\n+void\n+gst_libcamera_pad_set_latency(GstPad *pad, GstClockTime latency)\n+{\n+\tauto *self = GST_LIBCAMERA_PAD(pad);\n+\tGLibLocker lock(GST_OBJECT(self));\n+\tself->latency = latency;\n+}\ndiff --git a/src/gstreamer/gstlibcamerapad.h b/src/gstreamer/gstlibcamerapad.h\nindex eb24000..a3291e8 100644\n--- a/src/gstreamer/gstlibcamerapad.h\n+++ b/src/gstreamer/gstlibcamerapad.h\n@@ -32,4 +32,6 @@ GstFlowReturn gst_libcamera_pad_push_pending(GstPad *pad);\n \n bool gst_libcamera_pad_has_pending(GstPad *pad);\n \n+void gst_libcamera_pad_set_latency(GstPad *pad, GstClockTime latency);\n+\n #endif /* __GST_LIBCAMERA_PAD_H__ */\ndiff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 70f2048..73a1360 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -151,6 +151,26 @@ GstLibcameraSrcState::requestCompleted(Request *request)\n \tfor (GstPad *srcpad : this->srcpads) {\n \t\tStream *stream = gst_libcamera_pad_get_stream(srcpad);\n \t\tbuffer = wrap->detachBuffer(stream);\n+\n+\t\tFrameBuffer *fb = gst_libcamera_buffer_get_frame_buffer(buffer);\n+\n+\t\tif (GST_ELEMENT_CLOCK(this->src)) {\n+\t\t\tGstClockTime gst_base_time = GST_ELEMENT(this->src)->base_time;\n+\t\t\tGstClockTime gst_now = gst_clock_get_time(GST_ELEMENT_CLOCK(this->src));\n+\t\t\t/* \\todo Need to expose which reference clock the timestamp relates to. */\n+\t\t\tGstClockTime sys_now = g_get_monotonic_time() * 1000;\n+\n+\t\t\t/* Deduced from: sys_now - sys_base_time == gst_now - gst_bae_time */\n+\t\t\tGstClockTime sys_base_time = sys_now - (gst_now - gst_base_time);\n+\t\t\tGST_BUFFER_PTS(buffer) = fb->metadata().timestamp - sys_base_time;\n+\t\t\tgst_libcamera_pad_set_latency(srcpad, sys_now - fb->metadata().timestamp);\n+\t\t} else {\n+\t\t\tGST_BUFFER_PTS(buffer) = 0;\n+\t\t}\n+\n+\t\tGST_BUFFER_OFFSET(buffer) = fb->metadata().sequence;\n+\t\tGST_BUFFER_OFFSET_END(buffer) = fb->metadata().sequence;\n+\n \t\tgst_libcamera_pad_queue_buffer(srcpad, buffer);\n \t}\n \n","prefixes":["libcamera-devel","v2","23/27"]}