[{"id":3881,"web_url":"https://patchwork.libcamera.org/comment/3881/","msgid":"<20200229152240.GA18738@pendragon.ideasonboard.com>","date":"2020-02-29T15:22:40","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: pipeline: rkisp1:\n\tdon't enable immutable link","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Helen,\n\nThank you for the patch.\n\nOn Thu, Feb 27, 2020 at 12:00:01AM -0300, Helen Koike wrote:\n> Link between resizer and capture is immutable and doesn't need to be\n> enabled.\n> \n> Signed-off-by: Helen Koike <helen.koike@collabora.com>\n\nJust with s/don't/Don't/ in the subject line,\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 8 --------\n>  1 file changed, 8 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 7f7e1ad..0589d38 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -915,14 +915,6 @@ int PipelineHandlerRkISP1::initLinks()\n>  \tif (ret < 0)\n>  \t\treturn ret;\n>  \n> -\tlink = media_->link(\"rkisp1_resizer_mainpath\", 1, \"rkisp1_mainpath\", 0);\n> -\tif (!link)\n> -\t\treturn -ENODEV;\n> -\n> -\tret = link->setEnabled(true);\n> -\tif (ret < 0)\n> -\t\treturn ret;\n> -\n>  \treturn 0;\n>  }\n>","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A40B362689\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 29 Feb 2020 16:23:04 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1AD5B33E;\n\tSat, 29 Feb 2020 16:23:04 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1582989784;\n\tbh=yfXzF5dYNMtuRBFCMLtEgVOlPCUb/ZNyQyBQ3wEsHvA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sz9GjV5ARefT8ypo0K0qRClj6BGaEyPwcX4a8nLg5hL5I4AtQWGg3O0E2B8Dav8oW\n\tTFv3lY3JiDg0L1KhUxWmnW9XChP6/Sqv+3sy4Gv07HzOV6CaITwHhVrIAxTGrfLPoQ\n\tFuxKPkqQogGiaXL4EAFheBbkm7SabdqlzYdYCNpw=","Date":"Sat, 29 Feb 2020 17:22:40 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Helen Koike <helen.koike@collabora.com>","Cc":"libcamera-devel@lists.libcamera.org, kernel@collabora.com","Message-ID":"<20200229152240.GA18738@pendragon.ideasonboard.com>","References":"<20200227030001.333291-1-helen.koike@collabora.com>\n\t<20200227030001.333291-3-helen.koike@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200227030001.333291-3-helen.koike@collabora.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: pipeline: rkisp1:\n\tdon't enable immutable link","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sat, 29 Feb 2020 15:23:04 -0000"}}]