{"id":2881,"url":"https://patchwork.libcamera.org/api/patches/2881/?format=json","web_url":"https://patchwork.libcamera.org/patch/2881/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200227030001.333291-3-helen.koike@collabora.com>","date":"2020-02-27T03:00:01","name":"[libcamera-devel,2/2] libcamera: pipeline: rkisp1: don't enable immutable link","commit_ref":"ad5d123578ca5b0cd8ed43a8d21a62cc55422870","pull_url":null,"state":"accepted","archived":false,"hash":"6f6391149e58697cdadd51a0174e9fd2ab0fcd4b","submitter":{"id":20,"url":"https://patchwork.libcamera.org/api/people/20/?format=json","name":"Helen Koike","email":"helen.koike@collabora.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2881/mbox/","series":[{"id":692,"url":"https://patchwork.libcamera.org/api/series/692/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=692","date":"2020-02-27T02:59:59","name":"rkisp1: don't enable immutable link","version":1,"mbox":"https://patchwork.libcamera.org/series/692/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2881/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2881/checks/","tags":{},"headers":{"Return-Path":"<helen.koike@collabora.com>","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 05B5960429\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Feb 2020 04:00:16 +0100 (CET)","from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: koike) with ESMTPSA id 002A1293DC8"],"From":"Helen Koike <helen.koike@collabora.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"kernel@collabora.com, tfiga@chromium.org, niklas.soderlund@ragnatech.se, \n\tdafna.hirschfeld@collabora.com","Date":"Thu, 27 Feb 2020 00:00:01 -0300","Message-Id":"<20200227030001.333291-3-helen.koike@collabora.com>","X-Mailer":"git-send-email 2.25.0","In-Reply-To":"<20200227030001.333291-1-helen.koike@collabora.com>","References":"<20200227030001.333291-1-helen.koike@collabora.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/2] libcamera: pipeline: rkisp1: don't\n\tenable immutable link","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 27 Feb 2020 03:00:16 -0000"},"content":"Link between resizer and capture is immutable and doesn't need to be\nenabled.\n\nSigned-off-by: Helen Koike <helen.koike@collabora.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 8 --------\n 1 file changed, 8 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 7f7e1ad..0589d38 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -915,14 +915,6 @@ int PipelineHandlerRkISP1::initLinks()\n \tif (ret < 0)\n \t\treturn ret;\n \n-\tlink = media_->link(\"rkisp1_resizer_mainpath\", 1, \"rkisp1_mainpath\", 0);\n-\tif (!link)\n-\t\treturn -ENODEV;\n-\n-\tret = link->setEnabled(true);\n-\tif (ret < 0)\n-\t\treturn ret;\n-\n \treturn 0;\n }\n \n","prefixes":["libcamera-devel","2/2"]}