[{"id":3882,"web_url":"https://patchwork.libcamera.org/comment/3882/","msgid":"<20200229152315.GB18738@pendragon.ideasonboard.com>","date":"2020-02-29T15:23:15","subject":"Re: [libcamera-devel] [PATCH 1/2] utils: rkisp1: don't enable\n\timmutable link","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Helen,\n\nThank you for the patch.\n\nOn Thu, Feb 27, 2020 at 12:00:00AM -0300, Helen Koike wrote:\n> Link between resizer and capture is immutable and doesn't need to be\n> enabled.\n> \n> Signed-off-by: Helen Koike <helen.koike@collabora.com>\n\nJust with s/don't/Don't/ in the subject line,\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  utils/rkisp1/rkisp1-capture.sh | 1 -\n>  1 file changed, 1 deletion(-)\n> \n> diff --git a/utils/rkisp1/rkisp1-capture.sh b/utils/rkisp1/rkisp1-capture.sh\n> index 4b789b6..4d09f5d 100755\n> --- a/utils/rkisp1/rkisp1-capture.sh\n> +++ b/utils/rkisp1/rkisp1-capture.sh\n> @@ -70,7 +70,6 @@ configure_pipeline() {\n>  \n>  \t$mediactl -l \"'$sensor':0 -> 'rkisp1_isp':0 [1]\"\n>  \t$mediactl -l \"'rkisp1_isp':2 -> 'rkisp1_resizer_mainpath':0 [1]\"\n> -\t$mediactl -l \"'rkisp1_resizer_mainpath':1 -> 'rkisp1_mainpath':0 [1]\"\n>  \n>  \t$mediactl -V \"\\\"$sensor\\\":0 [$format]\"\n>  \t$mediactl -V \"'rkisp1_isp':0 [$format crop:(0,0)/$sensor_size]\"","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 208A462689\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 29 Feb 2020 16:23:39 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B179B33E;\n\tSat, 29 Feb 2020 16:23:38 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1582989818;\n\tbh=RXVhIUc/Hivz7jKl+QmY3/Vo8Qb7qel6kXEva5Me0q8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pBcd3l+opkiTzM/Tf/wqtj+CAQKrr4PxAikGDBHxwJf+PFqBMP3h0GckQ3X4jK5vf\n\tx1/FmywAMJpywxnSXmeHKAVCbY2wwpD/F8pKWjb3oc0tS0zRozWot7/2d7S++JtIhB\n\t1TH7MRDTenkN3YiiadPGumgqOrbDDP2sXygMId+w=","Date":"Sat, 29 Feb 2020 17:23:15 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Helen Koike <helen.koike@collabora.com>","Cc":"libcamera-devel@lists.libcamera.org, kernel@collabora.com","Message-ID":"<20200229152315.GB18738@pendragon.ideasonboard.com>","References":"<20200227030001.333291-1-helen.koike@collabora.com>\n\t<20200227030001.333291-2-helen.koike@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200227030001.333291-2-helen.koike@collabora.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 1/2] utils: rkisp1: don't enable\n\timmutable link","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sat, 29 Feb 2020 15:23:39 -0000"}}]