[{"id":3840,"web_url":"https://patchwork.libcamera.org/comment/3840/","msgid":"<20200224234543.GJ16163@pendragon.ideasonboard.com>","date":"2020-02-24T23:45:43","subject":"Re: [libcamera-devel] [PATCH v2 1/4] test: camera: buffer_import:\n\tFix error messages","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Mon, Feb 24, 2020 at 08:35:58PM +0100, Niklas Söderlund wrote:\n> The error message for when a device name can't be resolved to an video\n\ns/an video/a video/\n\n> device is wrong and applies to the next operation bellow it. Move it to\n\ns/bellow/below/\n\n> it's correct location and add a new error message to highlight the\n\ns/it's/its/\n\n> resolution failure.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> test/camera/buffer_import.cpp | 9 ++++++---\n> 1 file changed, 6 insertions(+), 3 deletions(-)\n> \n> diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\n> index ab6e74bd1671e6f5..6997ea78c9f608c9 100644\n> --- a/test/camera/buffer_import.cpp\n> +++ b/test/camera/buffer_import.cpp\n> @@ -74,13 +74,16 @@ public:\n> \n> \t\tvideo_ = V4L2VideoDevice::fromEntityName(media_.get(), videoDeviceName);\n> \t\tif (!video_) {\n> +\t\t\tstd::cout << \"Failed to get video device from entity \"\n> +\t\t\t\t << videoDeviceName << std::endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (video_->open()) {\n> \t\t\tstd::cout << \"Unable to open \" << videoDeviceName << std::endl;\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> -\t\tif (video_->open())\n> -\t\t\treturn TestFail;\n> -\n> \t\t/* Configure the format. */\n> \t\tV4L2DeviceFormat format;\n> \t\tif (video_->getFormat(&format)) {","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 061436262D\n\tfor ;\n\tTue, 25 Feb 2020 00:46:07 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0FF61E89;\n\tTue, 25 Feb 2020 00:46:05 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1582587966;\n\tbh=PvxlcLkqu8b3P/qrcg72dY8BdzeYlXp12mZLRccOIy8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mZxx2zFzYV5JvXRAJMl65cCbJy3BJ63w3NsWbgDIL9RaJz9Hvf1nPALz0xLCcp1lA\n\tMiluDmXl/i9PhTwJflBZqVv1TPXfdcCGsgyQygvR7n0klj4za67TB5MtFukjuXYQyA\n\t8q9QCUCvzr5OGGPGOUaVyZbM43PdCIbqLtCI/5Ak=","Date":"Tue, 25 Feb 2020 01:45:43 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200224234543.GJ16163@pendragon.ideasonboard.com>","References":"<20200224193601.1040770-1-niklas.soderlund@ragnatech.se>\n\t<20200224193601.1040770-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200224193601.1040770-2-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 1/4] test: camera: buffer_import:\n\tFix error messages","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 24 Feb 2020 23:46:07 -0000"}}]