{"id":2875,"url":"https://patchwork.libcamera.org/api/patches/2875/?format=json","web_url":"https://patchwork.libcamera.org/patch/2875/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200224193601.1040770-2-niklas.soderlund@ragnatech.se>","date":"2020-02-24T19:35:58","name":"[libcamera-devel,v2,1/4] test: camera: buffer_import: Fix error messages","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4e2df824b9a36b10c6cbb34d8c890182e431231d","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2875/mbox/","series":[{"id":691,"url":"https://patchwork.libcamera.org/api/series/691/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=691","date":"2020-02-24T19:35:57","name":"libcamera: V4L2BufferCache: Improve cache eviction strategy","version":2,"mbox":"https://patchwork.libcamera.org/series/691/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2875/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2875/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C21D360438\n\tfor ;\n\tMon, 24 Feb 2020 20:36:24 +0100 (CET)","from bismarck.berto.se (p4fca2392.dip0.t-ipconnect.de\n\t[79.202.35.146]) by bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid ee190fbf-573c-11ea-9f40-0050569116f7;\n\tMon, 24 Feb 2020 20:36:19 +0100 (CET)"],"X-Halon-ID":"ee190fbf-573c-11ea-9f40-0050569116f7","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 24 Feb 2020 20:35:58 +0100","Message-Id":"<20200224193601.1040770-2-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.25.0","In-Reply-To":"<20200224193601.1040770-1-niklas.soderlund@ragnatech.se>","References":"<20200224193601.1040770-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 1/4] test: camera: buffer_import: Fix\n\terror messages","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 24 Feb 2020 19:36:25 -0000"},"content":"The error message for when a device name can't be resolved to an video\ndevice is wrong and applies to the next operation bellow it. Move it to\nit's correct location and add a new error message to highlight the\nresolution failure.\n\nSigned-off-by: Niklas Söderlund \n---\n test/camera/buffer_import.cpp | 9 ++++++---\n 1 file changed, 6 insertions(+), 3 deletions(-)","diff":"diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\nindex ab6e74bd1671e6f5..6997ea78c9f608c9 100644\n--- a/test/camera/buffer_import.cpp\n+++ b/test/camera/buffer_import.cpp\n@@ -74,13 +74,16 @@ public:\n \n \t\tvideo_ = V4L2VideoDevice::fromEntityName(media_.get(), videoDeviceName);\n \t\tif (!video_) {\n+\t\t\tstd::cout << \"Failed to get video device from entity \"\n+\t\t\t\t << videoDeviceName << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (video_->open()) {\n \t\t\tstd::cout << \"Unable to open \" << videoDeviceName << std::endl;\n \t\t\treturn TestFail;\n \t\t}\n \n-\t\tif (video_->open())\n-\t\t\treturn TestFail;\n-\n \t\t/* Configure the format. */\n \t\tV4L2DeviceFormat format;\n \t\tif (video_->getFormat(&format)) {\n","prefixes":["libcamera-devel","v2","1/4"]}